ChangeLog ========= OpenSRF 2.4.0-alpha ------------------- commit 4426a8a503baec5171ae4245eccd595444815358 Author: Galen Charlton Date: Thu Aug 21 16:30:05 2014 -0700 release notes for OpenSRF 2.4.0-alpha Signed-off-by: Galen Charlton 121 0 doc/RELEASE_NOTES.txt create mode 100644 doc/RELEASE_NOTES.txt commit e8f78636586aeca15632bcfbf0cae20beb2d66a6 Author: Galen Charlton Date: Thu Aug 21 10:02:14 2014 -0700 LP#1002028: set Access-Control-Expose-Headers This allows the OpenSRF JavaScript client library (or to be precise, one that has been modified to direct requests at a different domain) to take advantage of CORS support. Signed-off-by: Galen Charlton 1 0 src/gateway/apachetools.c commit bc914bf1933cc7a9272134fd4bbeb7601d233903 Author: Galen Charlton Date: Thu Aug 21 09:13:23 2014 -0700 LP#1002028: support CORS for HTTPS Signed-off-by: Galen Charlton 2 0 src/gateway/apachetools.c commit d8dbf0c4e44cf45f00ffe2785d0778658029b825 Author: Bennett Goble Date: Tue May 22 11:57:56 2012 -0400 LP#1002028: Cross Origin Resource Sharing for OpenSRF Background ---------- Browsers' same-origin policy currently restricts requests to the current website's domain to prevent various nefarious scenarios. However, because APIs and other web resources need to remain open to cross-site use Cross Origin Resource Sharing (CORS) was created to allow services to formally authorize cross-origin requests. CORS makes it simple to use OpenSRF's HTTP translator and gateway APIs on websites using separate domains. Example Scenarios ----------------- 1) A library would like an AJAX-driven "quicksearch" box on their main site, which is hosted on a different domain than their catalog. 2) A developer wants to create new web applications and services that tie into Evergreen, but does not wish to install EG locally or configure a proxy. Implementation -------------- The function crossOriginHeaders() has been added to apachetools.c. Incoming requests are checked to see if they have an Origin header. The value of the Origin header is checked against a whitelist defined in opensrf_core.xml config (XPath: /config/gateway/cross_origin/origin). The function returns 1 if CORS headers have been added to the response. Notes ----- * The OpenSRF Javascript client library (opensrf.js) defaults to the root of the current web host "/osrf-http-translator." In addition, synchronous requests are presumed in some situations: resulting in the oncomplete method never returning (Blocking requests are not possible with cross- domain XHR.) * It is also possible to enable CORS with the Apache "set header" configuration directive. However, this means that the necessary headers would be appended to every response. Links ----- Specification - http://www.w3.org/TR/cors/ Wikipedia Article - http://en.wikipedia.org/wiki/Cross-origin_resource_sharing Signed-off-by: Bennett Goble Signed-off-by: Galen Charlton 8 0 examples/opensrf_core.xml.example 36 0 src/gateway/apachetools.c 5 0 src/gateway/apachetools.h 5 0 src/gateway/osrf_http_translator.c 5 0 src/gateway/osrf_json_gateway.c commit 6ed6f2bc6bf56d0834ae43f00c193bce5a3867a1 Author: Galen Charlton Date: Thu Aug 21 08:58:18 2014 -0700 Revert "LP#1350457: Pass caller's session to subrequests called via method_lookup" This reverts commit 96917538c6b6fad688dd40c2a8f0cc9127053b24. 3 3 src/perl/lib/OpenSRF/Application.pm commit f0c02bf3cc4e8e2c1049fd2ba0fd24079b5aeba6 Author: Josh Stompro Date: Wed May 21 08:26:53 2014 -0500 (doc) Reorder changes to ejabberd.cfg in install instructions I found it annoying that the list of changes to make to ejabberd.cfg didn't follow the order that the options showed up in the default Debian ejabberd.cfg. I reordered them so after you finish changing one option, you can search forward in the document for the next term. (From Github pull request #3.) Signed-off-by: Josh Stompro Signed-off-by: Galen Charlton 4 4 README commit 96917538c6b6fad688dd40c2a8f0cc9127053b24 Author: Mike Rylander Date: Wed Jul 30 13:29:46 2014 -0400 LP#1350457: Pass caller's session to subrequests called via method_lookup In the process of looking up a method for an internal subrequest, we lose session info. This is a problem when the subrequest makes a remote request, because then the subrequest can't look up the proper locale, among other things. The forthcoming branch passes the caller's session to the subrequest. Signed-off-by: Mike Rylander Signed-off-by: Galen Charlton 3 3 src/perl/lib/OpenSRF/Application.pm commit 6cdd5251ac64651534e579f7e02a70a665f60283 Author: Bill Erickson Date: Thu Jul 17 11:37:53 2014 -0400 LP#1341687 listeners log/drop XMPP error msgs The most common form of XMPP error messages are "bounced" messages, i.e. those where the recipient is not available. Instead of passing these useless and confusing messages down to a drone for processing, log the error in the listener and drop the message. Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 9 0 src/libopensrf/osrf_prefork.c 5 1 src/perl/lib/OpenSRF/Server.pm commit 54da75bd2f045dbd2225317f74dc5fe38f415fe5 Author: Galen Charlton Date: Wed Aug 20 14:00:17 2014 -0700 LP#1343578: document in the example opensrf_core.xml Signed-off-by: Galen Charlton 12 0 examples/opensrf_core.xml.example commit 2f4ed86a136cfb7547f7e8c3e2109f4473139276 Author: Bill Erickson Date: Thu Jul 17 15:10:35 2014 -0400 LP#1343578: Perl/C syslog "logtag" additions. * Honor logtag value when applying a default appname for Perl and C * Extract / apply logtag in the router * Minor repair: avoid redundant strdup Signed-off-by: Bill Erickson Signed-off-by: Mike Rylander Signed-off-by: Galen Charlton 1 1 src/libopensrf/log.c 1 1 src/libopensrf/osrf_system.c 5 2 src/perl/lib/OpenSRF/Utils/Logger.pm 2 0 src/router/osrf_router_main.c commit 512f77b4652d6c793c21c7b6955480e6b9ada195 Author: Mike Rylander Date: Fri Jun 20 15:52:47 2014 -0400 LP#1343578: Add support for log tagging The ability to provide instance-specific log tagging via syslog would make running multiple instances much easier to manage. So this branch does that. Signed-off-by: Mike Rylander Signed-off-by: Galen Charlton 2 0 include/opensrf/log.h 26 1 src/libopensrf/log.c 3 0 src/libopensrf/osrf_system.c 4 0 src/perl/lib/OpenSRF/Utils/Logger.pm commit 6c3b1001c6183b2f633d0f43ccd3d28071c0c48d Author: Bill Erickson Date: Mon May 5 13:40:46 2014 -0400 LP#1316245: JS now uses browser-native JSON routines * Replace JSON2jsRaw() with JSON.parse() * Replace js2JSONRaw() with JSON.stringify() * Removed unit tests for JSON2jsRaw() and js2JSONRaw() * Removed jsonPretty() pretty-printing routine. Use JSON.stringify(json, null, ) instead. See also: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Using_native_JSON Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 2 94 src/javascript/JSON_v1.js 0 60 src/javascript/tests/testJSON_v1.js commit 2677f8e815a61f9b808bb57647f6ec9d448f0268 Author: Bill Erickson Date: Mon Aug 4 14:26:36 2014 -0400 LP#1268619: disable shared workers pending browser issues There appears to be a bug in Chromium where loading the same page multiple times (without a refresh or cache clear) causes the SharedWorker to fail to instantiate on every other page load. Further research pending. Disabling SharedWorker's entirely for now. Note, to replicate, load a page using shared workers, focus the browser address bar, hit Enter to load the page again. The shared worker will fail to load on every other page load, though it will appear to the SharedWorker caller (opensrf.js) that the port is open. Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 6 1 src/javascript/opensrf.js commit 755a58642281246df280877f7ad480503b1ddc4b Author: Bill Erickson Date: Wed Jul 30 12:05:36 2014 -0400 LP#1268619: update JS/WS/SSL code comment Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 1 4 src/javascript/opensrf_ws_shared.js commit c65c6d9f91c5372360619004c8602d2a262dfb8b Author: Bill Erickson Date: Thu Jul 10 11:29:49 2014 -0400 LP#1268619: JS status codes can come across as numbers; stringify for match Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 1 1 src/javascript/opensrf.js commit 17ae5ca5e6db6700dc4b61599c4394f80e727711 Author: Bill Erickson Date: Tue Jul 8 09:41:12 2014 -0400 LP#1268619: JS libs capture all method errors Instead of selecting specific errors to report as method errors, report all API calls which return 400 or 500-series errors as method errors. Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 2 1 src/javascript/opensrf.js commit 9fdef970f3785e958090f8edf4ad37ece4459343 Author: Bill Erickson Date: Sun May 4 15:58:17 2014 -0400 LP#1268619: websocket: avoid sharedworker for firefox 29 https://bugzilla.mozilla.org/show_bug.cgi?id=504553#c73 Avoid using SharedWorkers when useragent match "Firefox". FF supports shared workers, but it does not yet support WebSockets within shared workers. Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 8 3 src/javascript/opensrf.js commit f43286bf11119c731ee0dbe9b5b740d8715ace66 Author: Bill Erickson Date: Thu Apr 10 08:50:13 2014 -0400 LP#1268619: websockets: detect connectedness of JS default sockets Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 18 2 src/javascript/opensrf.js 10 1 src/javascript/opensrf_ws.js 3 1 src/javascript/opensrf_ws_shared.js commit 0cf0a8a5fe61228995f75d0f0c6e4f4731888c40 Author: Bill Erickson Date: Mon Apr 7 12:04:33 2014 -0400 LP#1268619: websockets: auto-upgrade to shared workers; SSL-always Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 42 4 src/javascript/opensrf.js 95 0 src/javascript/opensrf_ws.js 4 4 src/javascript/opensrf_ws_shared.js create mode 100644 src/javascript/opensrf_ws.js commit 8120314b86d2b6cafe2f5fd968b4475cc187acfb Author: Bill Erickson Date: Tue Mar 11 17:25:19 2014 -0400 LP#1268619: websockets: gateway code repairs & confing options * avoid unneccessary and wrong incantation of apr_thread_exit. The two sub-threads now both live for the duration of the process. * to be safe, create thread mutex before threads Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 8 1 README.websockets 252 206 src/gateway/osrf_websocket_translator.c commit 4ce075beeb5f81b8eb4c2cb2669b3a99ebab40ba Author: Bill Erickson Date: Mon Mar 10 15:55:24 2014 -0400 LP#1268619: websockets: apply syslog name in gateway Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 1 0 src/gateway/osrf_websocket_translator.c commit 77c7f5889e8f31038cd732feb3e6057a0d3788b5 Author: Bill Erickson Date: Mon Mar 10 08:41:45 2014 -0400 LP#1268619: websockets: README typo repairs Patch from Warren Layton to repair path to 'envvars' and clarify some text. Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 2 2 README.websockets commit bb424c1424193e4db340e3f6e17a939dc1dd821a Author: Bill Erickson Date: Thu Mar 6 15:47:36 2014 -0500 LP#1268619: websockets : additional apache config docs Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 20 40 README.websockets 0 43 examples/apache2/websockets.conf 73 0 examples/apache2/websockets/apache2.conf delete mode 100644 examples/apache2/websockets.conf create mode 100644 examples/apache2/websockets/apache2.conf commit 9f2d35e6f6b6ec5a3db109adb518cf270d49c683 Author: Bill Erickson Date: Thu Mar 6 15:05:12 2014 -0500 LP#1268619: websockets: apache conf -> info logging Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 1 1 examples/apache2/websockets.conf commit b1b3bf60f613b94d1455afb54dff4ad4a7e95ddd Author: Bill Erickson Date: Wed Mar 5 08:40:05 2014 -0500 LP#1268619: websockets: remove single-tab JS WS implementation It was falling behind the shared lib in bug fixes and features. A per-tab WS implementation is (maybe) a dangerous thing to have around, as well, since it encourages /many/ connections. Can resurrect later if needed. Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 0 165 src/javascript/opensrf_ws.js delete mode 100644 src/javascript/opensrf_ws.js commit 6765c6395b0fb2a1c501f7c94a04cfacc7d460db Author: Bill Erickson Date: Tue Mar 4 14:10:59 2014 -0500 LP#1268619: websockets: shared worker path; JS api_level Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 25 8 src/javascript/opensrf.js commit f5ada2850552560a24e473e02532e75870ab7307 Author: Bill Erickson Date: Mon Mar 3 16:23:44 2014 -0500 LP#1268619: websockets: initial C libs api_level support Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 4 1 src/libopensrf/osrf_message.c commit 2bcead2d3e1c560a30c5b9beba6d1cbfe58778ed Author: Bill Erickson Date: Mon Mar 3 16:01:58 2014 -0500 LP#1268619: websockets : gateway log inbound messages at internal Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 7 0 src/gateway/osrf_websocket_translator.c commit 5631bbdfa0f9a4fe2ea1b238c5e2ffee4b606dc1 Author: Bill Erickson Date: Mon Mar 3 12:06:12 2014 -0500 LP#1268619: websocket : add JS lib to makefile Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 1 1 src/Makefile.am commit 0054ea6684a933037af1cc3bc6358c7096dc051c Author: Bill Erickson Date: Mon Mar 3 10:29:23 2014 -0500 LP#1268619: websocket: avoid module auto configuration We don't want osrf_websocket_translator to be directly loaded as a module, since it is not an apache module, but a shared library loaded by an apache module (mod_websockets). This is especially true of the default apache instance. Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 1 1 src/gateway/Makefile.am commit e375a1e31b87a3d645b6da05e83f2a29f885f1fc Author: Bill Erickson Date: Mon Mar 3 10:05:26 2014 -0500 LP#1268619: websocket : apache gateway minor fixes Replace remaining remote_ip calls with a get_client_ip() function which operates for apache2 and apache4. Make log functions for applying a log trace value accept const char*'s Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 2 2 include/opensrf/log.h 11 16 src/gateway/osrf_websocket_translator.c 2 2 src/libopensrf/log.c commit 0a0d3f616c9531c7931c365e1912cbcf6358441b Author: Bill Erickson Date: Mon Mar 3 09:42:03 2014 -0500 LP#1268619: websocket : more JS api docs Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 83 20 src/javascript/opensrf_ws_shared.js commit aa1c088bd45a254290ad202875eb87c4bd4eeb2a Author: Bill Erickson Date: Thu Jan 16 11:41:01 2014 -0500 LP#1268619: websockets : added config docs to install readme Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 19 0 README.websockets 1 1 src/gateway/osrf_websocket_translator.c commit a64f10c4183a495ec3912458c9b6268856e8fe47 Author: Bill Erickson Date: Tue Jan 14 16:25:20 2014 -0500 LP#1268619: websocket JS libs: reconnect and auto-connect JS clients no longer need to explicitly call the shared WS setup routine. It happens under the covers now. JS client detects disconnects and reconnects when the next message send attempt occurs. Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 4 6 src/javascript/opensrf.js 55 45 src/javascript/opensrf_ws_shared.js commit a02360aadfcd113cbec88d9c2455e42fdd74e536 Author: Bill Erickson Date: Tue Jan 14 16:22:23 2014 -0500 LP#1268619: websocket translator idle timeout / graceful shutdown Added support for an idle timeout and idle check interval configuration variables. These allow each websocket apache process to kick off clients that have been connected and are idle for too long, thus hogging a process unnecessarily. Added a SIGUSR1 signal handler which forces the idle timeout to be very low and a short re-check period so that the client can be kicked as soon as there are no open conversations. Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 263 25 src/gateway/osrf_websocket_translator.c commit bef394a7c24df54f1e63fc3e83cd473195a46c3a Author: Bill Erickson Date: Fri Jan 10 11:57:29 2014 -0500 LP#1268619: websockets: support WS via shared web workers This allows mutiple browser tabs to share the same websocket connection. TODO: add tab (port) disconnect handler TODO: more docs / examples Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 55 0 src/javascript/opensrf.js 176 0 src/javascript/opensrf_ws_shared.js create mode 100644 src/javascript/opensrf_ws_shared.js commit fdb255a92f9fa687a50bed05ef918523cf902d8b Author: Bill Erickson Date: Thu Jan 9 15:00:03 2014 -0500 LP#1268619: websocket: do not disconnect ws() on osrf disconnect message Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 0 5 src/javascript/opensrf.js commit d546d7eacb183ba2ddd0c0ba5dc281dc5086ae81 Author: Bill Erickson Date: Tue Feb 5 10:22:34 2013 -0500 LP#1268619: temporary websocket installer README Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 47 0 README.websockets create mode 100644 README.websockets commit e4ef36f385c4f3b83ac4b49f2b07ee19c3166ff0 Author: Bill Erickson Date: Tue Feb 5 09:52:57 2013 -0500 LP#1268619: Sample Websocket translator Apache 2.2 configuration Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 43 0 examples/apache2/websockets.conf create mode 100644 examples/apache2/websockets.conf commit 32ab4b133c9c96780e8b202ab1efe46bbf321c3b Author: Bill Erickson Date: Fri Jan 25 12:38:13 2013 -0500 LP#1268619: websocket gateway: improved memory mgt; logging Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 1 1 src/gateway/Makefile.am 18 23 src/gateway/osrf_websocket_translator.c 2 2 src/javascript/opensrf_ws.js commit 0f3aa6480d2fbc9645571e057dac3f3be08709d1 Author: Bill Erickson Date: Mon Jan 21 11:34:57 2013 -0500 LP#1268619: websockets; free temporary osrf msgs; minor comment change Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 11 2 src/gateway/osrf_websocket_translator.c commit de238b740f3a54dacd07610d8e187f417bf5b677 Author: Bill Erickson Date: Mon Dec 10 14:33:14 2012 -0500 LP#1268619: websocket; docs, more memory mgmt Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 79 34 src/gateway/osrf_websocket_translator.c commit f990a29db95d9b1c06efa22c1b3f4fbc43206571 Author: Bill Erickson Date: Mon Nov 12 16:46:19 2012 -0500 LP#1268619: websocket translator * starting packet inspection * activity log; recipient removal * only cache connected recipients; use request_rec pool for session_pool parent * wrap all thread work in mutex * session memory goodness Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 278 72 src/gateway/osrf_websocket_translator.c commit 27707398e955b8a8a2df1a5311aebc19b8eb1708 Author: Bill Erickson Date: Thu Nov 8 12:36:16 2012 -0500 LP#1268619: websocket JS additions Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 51 50 src/javascript/opensrf.js 124 63 src/javascript/opensrf_ws.js commit cc42cb62c47edabd693e491ad0d939970d7dbc53 Author: Bill Erickson Date: Tue Oct 30 15:51:18 2012 -0400 LP#1268619: track websocket_plugin.h locally until replaced by makefile.install process Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 130 0 src/gateway/websocket_plugin.h create mode 100644 src/gateway/websocket_plugin.h commit 9e455c227be32bed4a16e6dab7045b6424e2ba15 Author: Bill Erickson Date: Mon Oct 29 17:27:44 2012 -0400 LP#1268619: websocket gateway repairs and cleanup * use jsonObjectFree() on jsonObjets, not free(); * removed some debugging logs * accommodate API changes for Apache 2.4 * safer logging: Avoid using ap_log_rerror, in particular referencing server->request from the responder thread, since the request_rec will be invalid after on_disconnect is called. Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 61 66 src/gateway/osrf_websocket_translator.c commit a77eb22c27183d23fb08ed40bc75469d8c54b884 Author: Bill Erickson Date: Fri Oct 26 15:06:13 2012 -0400 LP#1268619: Apache websocket translator module Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 6 2 src/gateway/Makefile.am 427 0 src/gateway/osrf_websocket_translator.c create mode 100644 src/gateway/osrf_websocket_translator.c commit 1dafbe7512f086a58212fcc66c07e348647f31ad Author: Bill Erickson Date: Thu Sep 20 15:55:04 2012 -0400 LP#1268619: OpenSRF JS websockets plugin Adds an opensrf_ws.js handler. Requries some small modifications to opensrf.js. Load opensrf_ws.js in DojoSRF. For now, to use, add to script: OpenSRF.Session.transport = OSRF_TRANSPORT_TYPE_WS; Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 1 0 src/javascript/DojoSRF.js 53 15 src/javascript/opensrf.js 104 0 src/javascript/opensrf_ws.js create mode 100644 src/javascript/opensrf_ws.js commit cb56fd32eb43f037c4126e1398b0e9cd546d9f19 Author: Mike Rylander Date: Fri Jun 20 16:48:51 2014 -0400 LP#1337401: Only care about our own processes OpenSRF can run mutiple times, as different users, on one host. Right now we look for all service processes, but we should only look for our own. This patch does that. Signed-off-by: Mike Rylander Signed-off-by: Galen Charlton 5 5 bin/opensrf-perl.pl.in commit 65ce998b02d0778541b3101379013448cba606d2 Author: Ben Shum Date: Fri Apr 18 16:36:38 2014 -0400 LP#1315525: Add trusty target and remove lucid from README Signed-off-by: Ben Shum Signed-off-by: Galen Charlton 1 1 README commit be5c3d82ecba066b1f4b811af9a32a85eb1c6d70 Author: Chris Sharp Date: Sun Jan 26 10:41:31 2014 -0500 LP#1315525: Updating Makefile.install for Ubuntu 14.04. Removing lucid support. Signed-off-by: Chris Sharp Signed-off-by: Ben Shum Signed-off-by: Galen Charlton 12 11 src/extras/Makefile.install commit 339ac28d47a466d2fd0009c24fe0385cb5326479 Author: Galen Charlton Date: Fri Feb 28 09:33:19 2014 -0800 LP#1286248: remove osrf_ctl.sh As osrf_ctl.sh was deprecated in favor of osrf_control, this patch removes the deprecated script entirely. Signed-off-by: Galen Charlton Signed-off-by: Bill Erickson 0 1 .gitignore 0 102 bin/osrf_ctl.sh.in 1 2 configure.ac 1 1 src/Makefile.am delete mode 100755 bin/osrf_ctl.sh.in commit 8fb4405a2768dd752743dab71d6e2e8a50ee6cd5 Author: Galen Charlton Date: Wed Apr 2 15:24:06 2014 -0700 LP#1285915: document that perl2JSON doesn't order hash keys This patch documents that JSON strings returned by OpenSRF::Utils::JSON->perl2JSON() should not be expected to have hash keys sorted in any particular order. It also adjusts a corresponding test case to consistently pass under Perl 5.18, which introduces hash order randomization. Forcing JSON output to be in canonical form is another option, and easily done by JSON::XS, but would add overhead. Signed-off-by: Galen Charlton Signed-off-by: Bill Erickson 2 1 src/perl/lib/OpenSRF/Utils/JSON.pm 5 1 src/perl/t/09-Utils-JSON.t commit 8a8b4cbbae62d3e927b24541f31fec93949b1752 Author: Galen Charlton Date: Wed Apr 2 16:05:33 2014 -0700 LP#1234816: improve const-correctness of osrfCachePutString and osrfCachePutObject Since the cache key is not modified by osrfCachePutString and osrfCachePutObject, this patch changes the key parameter of those two functions from char* to const char*. It also updates one caller osrfCachePutObject to not cast away const-ness. This patch has no functional impact, but enables future callers of osrfCachePut* to pass constant strings without having to cast away the const-ness. Signed-off-by: Galen Charlton Signed-off-by: Bill Erickson 2 2 include/opensrf/osrf_cache.h 1 1 src/gateway/osrf_http_translator.c 2 2 src/libopensrf/osrf_cache.c commit 0d2c6d74cf60e000646e534a7682b508c84ea55a Author: Bill Erickson Date: Thu Apr 10 13:27:34 2014 -0400 LP#1306044 Removing deprecated jabber register script This script is no longer user, since ejabberdctrl is used instead. What's more, this script uses a Perl package (libnet-jabber-perl) which is no longer available in Debian (Jessie). Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 0 1 Makefile.am 0 50 examples/register.pl delete mode 100755 examples/register.pl commit a53e3878ae172477582ae3cfe3ebd8ec9be14e65 Author: Bill Erickson Date: Thu Apr 10 12:05:08 2014 -0400 LP#1306044 Debian Jessie Makefile.install target * Removes Perl Net::Jabber as a dependency. There is no Jessie package for this and OpenSRF hasn't used it in a long time. * Leaving Debian Squeeze in place for now Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 1 0 README 15 3 src/extras/Makefile.install commit 2e919d795f0d6c5c17218fef68e894903b168a48 Author: Mike Rylander Date: Thu Mar 13 16:55:19 2014 -0400 LP#1292214: Improve docgen output Docgen output would be a bit more useful if it respected the formatting (such as it is) of the signature content provided by the developer. So, let's make that happen. Signed-off-by: Mike Rylander Signed-off-by: Galen Charlton 1 1 src/extras/docgen.xsl commit 951d97a32db426874c4bb6314e473660d765f302 Author: Bill Erickson Date: Mon May 13 16:19:51 2013 -0400 LP#1179660: remove OpenSRF.pm AUTOLOAD Instead of simply producing an error message in the OpenSRF logs, calls to nonexistent subroutines are now fatal errors which will stop code execution. Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 1 40 src/perl/lib/OpenSRF.pm