2011-04-03T00:44:27 *** adbowling-isl has quit IRC 2011-04-03T01:12:37 *** _deXter has joined #evergreen 2011-04-03T01:27:28 *** suho has quit IRC 2011-04-03T01:29:19 *** _deXter has quit IRC 2011-04-03T02:09:04 @later tell tsbere I like the idea of having the labels on the commands, so that multiple widgets referencing the command (say a main menuitem and a context menuitem) can share the label with less duplication of text in the file. Exceptions can be made for when we don't want such sharing 2011-04-03T02:09:04 phasefx: The operation succeeded. 2011-04-03T02:10:53 @later tell tsbere I didn't really grok the attribute forwarding properties of command when I first started, or I would have done that from the start 2011-04-03T02:10:53 phasefx: The operation succeeded. 2011-04-03T07:57:32 @later tell phasefx There are issues with putting label/accesskey on commands only, though, meaning some will be on menuitems still. Such as patron by barcode that exists as three "functions": Checkout item, Retrieve Patron by Barcode, Search for Patron by Barcode. Which should be the "primary" on the command node? 2011-04-03T07:57:32 tsbere: The operation succeeded. 2011-04-03T09:57:43 @later tell phasefx Also, the label (accesskey not being that useful) also may apply to toolbar buttons with the same command. Which in some cases use the same language string, in others use a shorter one? 2011-04-03T09:57:43 tsbere: The operation succeeded. 2011-04-03T10:02:00 *** flopaul has joined #evergreen 2011-04-03T10:05:43 *** rjackson-isl has joined #evergreen 2011-04-03T10:08:08 Good Sunday morning - was wondering if anyone is online that has had experience migrating a library onto 2.0.x? 2011-04-03T10:08:25 WHen the copy of bibs starts up it never seems to finish 2011-04-03T10:08:40 been running for over 15 hours now - about 30K bibs 2011-04-03T10:09:32 *** flopaul has quit IRC 2011-04-03T10:15:51 *** Dyrcona has joined #evergreen 2011-04-03T10:16:55 *** suho has joined #evergreen 2011-04-03T11:10:44 Is there a good reason that there is no foreign key constraint on asset.copy in action.circulation? 2011-04-03T11:11:04 I was able to load 325,000+ circulations without any copies in the database. 2011-04-03T11:11:16 Dyrcona: yes. serial.unit.id could be used there 2011-04-03T11:12:15 ok, then. makes sense and you can't make a foreign key that references either of two other tables. 2011-04-03T11:12:24 right 2011-04-03T11:12:30 now, i vaguely remember discussing this or something like it months ago. 2011-04-03T11:13:14 we could use a check constraint of BEFORE trigger, though. the letter being more "correct" 2011-04-03T11:13:49 yeah. a before trigger.... 2011-04-03T11:14:20 i'll see if i can come up with a good one in between the thousand other things that i'm doing this week/weekend. 2011-04-03T11:14:44 :) 2011-04-03T11:15:27 just a had a load blow up because of a typo in a query. we were going to update our demo server with newer code and data. 2011-04-03T11:16:01 *** bjwebb has joined #evergreen 2011-04-03T11:16:24 that's how i saw the circulations created with no copies. 2011-04-03T11:17:09 * tsbere missed a typo and accidently wiped out 20 minutes of work and missed it for 3 git commits 2011-04-03T11:18:56 Oh well. Now that I know what I am doing it is a set of 3 or 4 sed commands. 2011-04-03T11:20:23 sed is the answer to which is more powerful: vi or emacs. 2011-04-03T11:22:04 grabbing 0507 2011-04-03T11:28:32 tsbere: if you anticipate the need for separate labels for widgets using the same command, I say go ahead and use separate DTD's directly on the widget. Is that what you're asking/getting at? 2011-04-03T11:29:06 ah, two later's 2011-04-03T11:29:12 phasefx: I am saying there are 8 (1 commented out) cmd_blah IDs being used with multiple labels/accesskeys in the menus. 2011-04-03T11:31:28 and what are you wanting my opinion on? 2011-04-03T11:34:13 How do I determine which of the conflicting labels goes on the node? 2011-04-03T11:34:27 Or do I not put any on there and leave all of them on the menuitems? 2011-04-03T11:34:32 I think that 2011-04-03T11:34:37 the latter 2011-04-03T11:35:08 if the entities are different, I probably wanted to give translators an option to distinguish between context 2011-04-03T11:35:37 Take note, if there is something on the menuitem it should override the command node. 2011-04-03T11:35:38 but I don't really know how much of that is needed, and probably haven't been consistent in that regard 2011-04-03T11:35:49 ah 2011-04-03T11:35:54 So the "default" can be on the command node 2011-04-03T11:36:06 Which brings me back to "which one should be the default?" 2011-04-03T11:36:39 * tsbere notes that there are technically 9 commands with multiple menu entries, commented out or otherwise, but cmd_replace_barcode uses the same languge string 3 times 2011-04-03T11:36:56 I think if we want to do that, then any arbitrary rule is probably as good as any other. First occurance is the default? Last occurance? 2011-04-03T11:37:32 Occurance that seems to most closely match the name of the command in the english translation? 2011-04-03T11:37:39 tsbere++ btw, for getting an itch to clean things up 2011-04-03T11:37:48 that sounds good to me too 2011-04-03T11:38:41 This is part of an ongoing "prep" for an extension or feature to do major messing with the menus (and maybe toolbar) 2011-04-03T11:38:46 or, most prominent widget 2011-04-03T11:39:27 prominent or easiest widget to get to 2011-04-03T11:39:29 BTW, figured out that for toolbar use you can put the image= on the command too. Think I should move those while I am at it? 2011-04-03T11:40:57 tsbere: a little more iffy on images than labels. Let's say you want to have a dropdown menu on the toolbar that lists all toolbar commands, even if the toolbar is hiding some icons 2011-04-03T11:41:53 but I'm fine with changing things when you need to, and keeping stuff consistent/easy to find otherwise. So could have images on commands until and if they become an issue being there 2011-04-03T11:41:55 * tsbere notes that menu items don't show icons at all unless they have menuitem-iconic as a class, and thus ignore the image setting 2011-04-03T11:42:58 tsbere: I think you have more of a grip on this than I do; if you want to trailblaze I say have at it 2011-04-03T11:44:25 *** flopaul has joined #evergreen 2011-04-03T11:45:14 BTW, is there an easy way from the javascript layer to check permissions? 2011-04-03T11:46:09 I never wrapped such checks in a utility function, but berick may have in the opac code 2011-04-03T11:47:41 the dojo stuff may have it wrapped up nice too, not sure 2011-04-03T11:49:14 I am considering a "assign one or more permissions to each command node in a new custom attribute, then iterate over them on window open and disable any that the user doesn't have the permission for" addition 2011-04-03T11:50:21 Maybe cache somewhere so that it isn't doing it all the time 2011-04-03T11:50:25 there should be a batch perms check 2011-04-03T11:50:34 Would need to re-run the check on new operator, though 2011-04-03T11:52:36 I don't see much in the way of batch check. Hmmm. 2011-04-03T11:52:52 open-ils.actor.user.has_work_perm_at.batch 2011-04-03T11:53:02 I think that may do what you need 2011-04-03T11:53:24 * tsbere would probably do better if he spelled "batch" correctly when grepping 2011-04-03T12:00:33 *** suhothayan has joined #evergreen 2011-04-03T12:03:56 *** suho has quit IRC 2011-04-03T12:04:17 *** flopaul has quit IRC 2011-04-03T12:23:40 *** suhothayan is now known as suho 2011-04-03T12:52:09 hmm.... apparently postgres doesn't handle "not null default value" the same way that some other databases do. 2011-04-03T12:52:27 it gives an error when i insert NULL, rather than use the default value. 2011-04-03T12:53:50 yeah, I've noticed that 2011-04-03T12:54:21 kind of a pita when every other database i use would use the default. 2011-04-03T12:54:30 I think you can insert DEFAULT in psql 2011-04-03T12:56:27 phasefx: I have a client_menus branch in my git repo, if you want to see/comment on what I have done so far. http://git.mvlcstaff.org/?p=tsbere/ILS.git;a=shortlog;h=refs/heads/client_menus 2011-04-03T12:57:09 tsbere: cool deal 2011-04-03T12:59:13 * tsbere is happy he knows sed and vim regex replace because otherwise some of that would have taken days 2011-04-03T13:00:38 phasefx: Also, the current state (3 commits on it) should (given a quick test or two) be safe and equiv to what was there from the other side of things. Thus commitable to trunk if you wanted to. 2011-04-03T13:01:20 phasefx: Ok, it breaks the label change on operator swap. *grumble* 2011-04-03T13:02:13 * tsbere takes a much closer look and wonders if he broke labels, or the *slight* upgrade to xulrunner he did in the process changed something 2011-04-03T13:02:41 hotkeys still work after removing @key? 2011-04-03T13:03:51 command nodes ignore key=. Hotkeys work without them. However, between the two versions of xulrunner command node labels started to *override* other labels, like on toolbar buttons and menu items. 2011-04-03T13:04:03 * tsbere grumbles 2011-04-03T13:04:23 fun 2011-04-03T13:04:39 Luckily that was a different commit 2011-04-03T13:04:44 and can thus be reverted easily enough 2011-04-03T13:05:01 Given that, though, should I go the other way and put them on the menuitems? 2011-04-03T13:05:37 for the multi-label case or for all cases? 2011-04-03T13:06:16 In all cases, so that you don't run into "I want a shorter one for this toolbar button" and it won't let you. 2011-04-03T13:06:21 Or other similar things 2011-04-03T13:07:47 well, I'm torn. In either case, if you need a different label, you're going to be editing some xul. But I like things on command for the majority of cases, just because it makes the files smaller, and gives xmlent less work to do. But if everything is on menuitems, etc., then at least it's consistent and more comprehensible for newcomers 2011-04-03T13:08:51 With them on the items using the label you don't run into "I edited this *other* file (where the toolbars are) and can't set/change a label" issues too. 2011-04-03T13:08:52 maybe see what the convention is in Firefox, Thunderbird 2011-04-03T13:09:44 * tsbere notes that he aims to make it so that almost anything in the menus can be given a toolbar button, and thus may want to mess with labels a lot more than is currently done in that regard 2011-04-03T13:11:18 if it makes things easier for you to not have stuff on command, then go for it 2011-04-03T13:16:40 Pushed another commit to swing things the other way 2011-04-03T13:16:58 Although I think I restored a pile of oldaccesskey type settings in the process. 2011-04-03T13:19:48 my way of commenting out attributes. Probably a bad habit with VCS's 2011-04-03T13:20:39 Maybe. I only removed them because my regex stuff moved them to the command nodes and I was sanitizing the command nodes. 2011-04-03T13:20:49 Hence reverting that change putting them back 2011-04-03T13:22:40 I suspect before commit to svn that some squashing is going to be needed 2011-04-03T13:51:16 *** bjwebb has quit IRC 2011-04-03T14:45:33 *** rsinger has quit IRC 2011-04-03T15:40:19 *** suho has quit IRC 2011-04-03T15:57:27 *** rsinger has joined #evergreen 2011-04-03T16:19:58 *** Dyrcona has quit IRC 2011-04-03T16:21:46 *** Dyrcona has joined #evergreen 2011-04-03T16:49:19 denials: curious ... what's authority field 148 from? what cataloging standard, I mean 2011-04-03T17:08:32 eeevil: Where should a before trigger on action.circulation go that requires the asset and serials schemas both be loaded first, i.e. what file? 2011-04-03T17:09:46 eeevil: Unless I hear otherwise, i'll put it in 800.fkeys.sql. 2011-04-03T17:09:59 Dyrcona: you could put it in 800.fkeys.sql, since it's implementing an inherited-table fkey of sorts 2011-04-03T17:10:03 yeah 2011-04-03T17:10:10 :) 2011-04-03T17:10:57 and you don't have to check them separately, you can just do SELECT TRUE FROM asset.copy WHERE id = $1 or equiv 2011-04-03T17:11:28 that will find the id in asset.copy or any child table (only serial.unit for now, but others could be added later) 2011-04-03T17:12:02 the fkey checks are essentially SELECT TRUE FROM ONLY asset.copy WHERE id = $1 2011-04-03T17:12:08 (note the ONLY keyword) 2011-04-03T17:13:08 now, if you want it to be deferrable you can use an AFTER trigger and raise an exception from within the function 2011-04-03T17:13:38 that might be closer to what we want, as we almost always say DEFERRABLE INITIALLY DEFERRED 2011-04-03T17:14:44 (it's not really DEFERRED, but it at least allows BEFORE triggers to fill in the data before checking for it) 2011-04-03T17:15:16 will an after trigger that raises an exception prevent the bad data going in? 2011-04-03T17:16:13 i also see that there was a set null on the foreign key constraint that is commented out. should I try to support that and allow the target copy id to be null? 2011-04-03T17:17:07 Dyrcona: well, you can't really delete asset.copy objects, they're protected by a RULE 2011-04-03T17:17:17 so, I don't think that's necessary 2011-04-03T17:17:30 ok 2011-04-03T17:17:37 is the field currently nullable? 2011-04-03T17:17:43 if so, /that/ should be supported, yes 2011-04-03T17:17:55 but not the ON CASCADE SET NULL 2011-04-03T17:18:07 er, ON DELETE SET NULL 2011-04-03T17:18:22 no, it isn't, it turns out 2011-04-03T17:18:31 k 2011-04-03T17:18:53 so, a simple constraint that checks to see if asset.copy and kids has that value in the id field is enough 2011-04-03T17:19:20 denials: I found the 148, btw, no worries 2011-04-03T18:04:30 eeevil: git://git.mvlcstaff.org/jason/ILS branch ac_target_copy_trig 2011-04-03T18:16:43 *** suho has joined #evergreen 2011-04-03T18:18:31 *** suho has quit IRC 2011-04-03T18:20:30 created a launchpad bug anyway. 2011-04-03T18:26:30 that is more than enough for today. 2011-04-03T18:26:56 *** Dyrcona has quit IRC 2011-04-03T19:08:16 * Digital_Pioneer creates an Android app for Evergreen with all the functionality of Hello World. 2011-04-03T19:10:04 * tsbere notes that Digital_Pioneer has more functionality than he does when it comes to an Android app doing anything right now 2011-04-03T19:10:16 :D 2011-04-03T19:10:38 It seemed reasonable to make something that proves I can at least put something on the device. 2011-04-03T19:10:44 True 2011-04-03T19:14:28 * Digital_Pioneer ships said app to his phone. It worx. 2011-04-03T19:15:02 Let's see, here... I need an icon. 2011-04-03T19:15:54 Does Evergreen have an official logo? 2011-04-03T19:16:27 And does anyone happen to know where I could get a nice SVG of it? :P 2011-04-03T19:27:49 Hmmm 2011-04-03T19:28:39 We have .ico files in the staff client folder 2011-04-03T19:29:44 Ehh. I'll just take the little emblem on the homepage logo. 2011-04-03T19:30:02 * tsbere had some source files kicking around 2011-04-03T19:30:24 The main Evergreen logo info is here: http://www.georgialibraries.org/lib/pines/evergreenlogo/ 2011-04-03T19:30:35 But that icon for the staff client is the usual one, right? 2011-04-03T19:31:15 For an app icon, that seems like the best choice 2011-04-03T19:31:16 The icons in the staff client folder were created by mrpeters-isl, I think. I have the eps source files and some large png files I just found too. 2011-04-03T19:33:52 *** senator_ has joined #evergreen 2011-04-03T19:35:39 *** finnapz2 has quit IRC 2011-04-03T19:35:43 *** senator has quit IRC 2011-04-03T19:37:14 *** finnapz2 has joined #evergreen 2011-04-03T19:49:33 *** tsbere_ has joined #evergreen 2011-04-03T19:51:41 *** tsbere has quit IRC 2011-04-03T19:51:41 *** rjackson-isl has quit IRC 2011-04-03T19:51:44 *** eeevil has quit IRC 2011-04-03T19:51:46 *** agJohn has quit IRC 2011-04-03T19:51:46 *** Callender has quit IRC 2011-04-03T19:52:38 *** Callender_ has joined #evergreen 2011-04-03T19:52:39 *** eeevil_ has joined #evergreen 2011-04-03T19:52:44 *** JMCraig has joined #evergreen 2011-04-03T19:52:45 *** Callender_ is now known as Callender 2011-04-03T19:52:45 *** JMCraig is now known as agJohn 2011-04-03T19:55:09 *** eeevil_ is now known as eeevil 2011-04-03T19:55:43 *** Jbergy has joined #evergreen 2011-04-03T20:03:52 *** Jbergy has quit IRC 2011-04-03T20:04:17 *** leed-home has quit IRC 2011-04-03T20:07:21 I made this for the Android launcher icon. If anyone wants to make something else, feel free, and I'll put it in. Here's mine: http://dl.dropbox.com/u/453116/icon.png 2011-04-03T20:12:30 *** leed-home has joined #evergreen 2011-04-03T20:14:21 Digital_Pioneer: From trunk, I think this is what tsbere was referring to - http://svn.open-ils.org/trac/ILS/browser/trunk/Open-ILS/xul/staff_client/evergreen-icon.ico 2011-04-03T20:14:27 Digital_Pioneer: Nice icon though :) 2011-04-03T20:38:34 *** finnapz has quit IRC 2011-04-03T20:38:42 *** mrpeters-isl has quit IRC 2011-04-03T20:38:54 *** mrpeters-isl has joined #evergreen 2011-04-03T20:38:57 *** finnapz has joined #evergreen 2011-04-03T20:40:00 *** flopaul has joined #evergreen 2011-04-03T20:51:23 bshum / Digital_Pioneer : I have the eps files from mrpeters-isl for the one in trunk. And the beta variant. Dunno where they may live in a repo, if anywhere. 2011-04-03T21:00:45 *** Dmagick has quit IRC 2011-04-03T21:01:54 *** Dmagick has joined #evergreen 2011-04-03T21:02:10 *** atheos has quit IRC 2011-04-03T21:02:11 *** mjgiarlo has quit IRC 2011-04-03T21:02:37 *** moodaepo has quit IRC 2011-04-03T21:03:39 *** moodaepo has joined #evergreen 2011-04-03T21:07:33 *** atheos has joined #evergreen 2011-04-03T21:25:01 *** flopaul has quit IRC 2011-04-03T21:31:49 bshum: Yeah, but mine is more compliant with the Android icon standards (as I made it with them in mind). 2011-04-03T21:32:21 That said, an icon is an icon. :P I can use that one if you think it would be better. 2011-04-03T21:36:45 @later tell phasefx I updated my client_menus branch with the ability to set permissions on command nodes. No permission = command node disabled. Command node disabled = menu/toolbar items/hotkeys auto-disabled. 2011-04-03T21:36:45 tsbere_: The operation succeeded. 2011-04-03T21:36:50 *** tsbere_ is now known as tsbere 2011-04-03T21:46:46 *** flopaul has joined #evergreen 2011-04-03T21:58:33 *** flopaul has quit IRC 2011-04-03T22:23:36 *** artunit_ has joined #evergreen 2011-04-03T22:27:16 *** artunit has quit IRC 2011-04-03T22:27:28 *** artunit_ is now known as artunit 2011-04-03T22:54:24 *** dbwells_ has joined #evergreen 2011-04-03T22:55:17 *** atz_ has quit IRC 2011-04-03T22:55:17 *** mtate has quit IRC 2011-04-03T22:55:20 *** dbwells has quit IRC 2011-04-03T22:55:21 *** eby has quit IRC 2011-04-03T22:55:21 *** phasefx_ has quit IRC 2011-04-03T22:55:23 *** kbeswick has quit IRC 2011-04-03T22:55:27 *** dbwells_ is now known as dbwells 2011-04-03T22:55:29 *** atz_ has joined #evergreen 2011-04-03T23:00:55 *** tsbere has quit IRC 2011-04-03T23:01:00 *** sylvar has quit IRC 2011-04-03T23:01:01 *** leed has quit IRC 2011-04-03T23:01:03 *** csharp has quit IRC 2011-04-03T23:04:32 *** kbeswick has joined #evergreen 2011-04-03T23:04:35 *** eby has joined #evergreen 2011-04-03T23:04:37 *** phasefx_ has joined #evergreen 2011-04-03T23:04:52 *** tsbere has joined #evergreen 2011-04-03T23:04:52 *** csharp has joined #evergreen 2011-04-03T23:04:52 *** sylvar has joined #evergreen 2011-04-03T23:04:52 *** leed has joined #evergreen 2011-04-03T23:05:02 *** mtate has joined #evergreen 2011-04-03T23:26:54 *** rangi` has joined #evergreen 2011-04-03T23:27:20 *** _bott_1 has joined #evergreen 2011-04-03T23:28:49 *** bshum_ has joined #evergreen 2011-04-03T23:31:16 *** bshum_ has left #evergreen 2011-04-03T23:32:41 *** AaronZ-PLS has quit IRC 2011-04-03T23:32:46 *** _bott_ has quit IRC 2011-04-03T23:32:46 *** bshum has quit IRC 2011-04-03T23:32:46 *** rangi has quit IRC 2011-04-03T23:32:46 *** jeff has quit IRC 2011-04-03T23:36:54 *** jeff has joined #evergreen 2011-04-03T23:36:54 *** jeff has joined #evergreen 2011-04-03T23:38:14 *** bshum has joined #evergreen 2011-04-03T23:55:22 *** mtisi_ has joined #evergreen 2011-04-03T23:55:30 *** mtisi has quit IRC