2011-06-07T00:41:59 *** dbs has quit IRC 2011-06-07T00:48:47 *** StephenGWills has quit IRC 2011-06-07T00:51:36 *** atz_ has joined #evergreen 2011-06-07T00:55:32 *** atz has quit IRC 2011-06-07T02:38:22 *** Callender_ has joined #evergreen 2011-06-07T02:38:40 *** Callender has quit IRC 2011-06-07T02:38:44 *** Callender_ is now known as Callender 2011-06-07T03:05:37 *** artunit_ has joined #evergreen 2011-06-07T03:07:21 *** artunit has quit IRC 2011-06-07T03:07:30 *** artunit_ is now known as artunit 2011-06-07T05:45:00 *** phasefx has quit IRC 2011-06-07T05:46:03 *** phasefx has joined #evergreen 2011-06-07T07:30:58 *** gmcharlt has quit IRC 2011-06-07T07:31:04 *** gmcharlt has joined #evergreen 2011-06-07T07:31:46 *** RBecker has quit IRC 2011-06-07T07:31:46 *** adrienne has quit IRC 2011-06-07T07:32:51 *** adrienne has joined #evergreen 2011-06-07T07:32:58 *** RBecker has joined #evergreen 2011-06-07T07:45:51 *** kmlussier has joined #evergreen 2011-06-07T07:48:01 *** mrpeters-isl has joined #evergreen 2011-06-07T08:04:55 *** gmcharlt has quit IRC 2011-06-07T08:04:55 *** gmcharlt has joined #evergreen 2011-06-07T08:33:26 *** dbs has joined #evergreen 2011-06-07T08:49:30 bshum++ 2011-06-07T08:49:40 thanks for the minutes & agenda 2011-06-07T08:50:37 bjwebb: will you be able to attend today's dev meeting @ 16:00 UTC? 2011-06-07T09:02:32 *** Dyrcona has joined #evergreen 2011-06-07T09:03:28 *** Meliss has joined #evergreen 2011-06-07T09:16:08 *** Stompro has joined #evergreen 2011-06-07T09:18:42 *** jenny has joined #evergreen 2011-06-07T09:48:11 dbs: should be able to, yes 2011-06-07T10:04:13 bjwebb: cool - surviving exams? 2011-06-07T10:04:42 dbs: yeah. 2011-06-07T10:07:05 they've been a mixed bag, but nearly done now 2011-06-07T10:20:05 dbs: Glad to help. I asked awhile back about making a recommendation for OpenSRF 2.0.x to be used with Evergreen 2.0.x series. Would like to throw that on the agenda for today too, if we have room to just officially decide if that's a good recommendation or not. 2011-06-07T10:20:33 bshum: please do 2011-06-07T10:21:10 bshum: also, just pushed a couple more commits to user/dbs/fix-search-summary - status element in holdings XML should have grown an opac_visible attribute, if I didn't fumble-finger it 2011-06-07T10:21:52 bjwebb: excellent! looking forward to seeing you celebrate by overhauling Makefiles for DESTDIRness :) 2011-06-07T10:21:55 dbs: Neato, I'll check it out when I get a moment. Kicking our SIP config at the moment because 3rd parties didn't call me back properly to perform more testing... 2011-06-07T10:35:55 *** Meliss has quit IRC 2011-06-07T10:38:22 *** Meliss has joined #evergreen 2011-06-07T10:53:22 *** joseph_ has joined #evergreen 2011-06-07T10:56:22 *** mcarlson_ has joined #evergreen 2011-06-07T10:56:49 *** mcarlson has quit IRC 2011-06-07T10:56:49 *** mcarlson_ is now known as mcarlson 2011-06-07T10:58:20 *** bjwebb has quit IRC 2011-06-07T10:59:07 *** bjwebb has joined #evergreen 2011-06-07T10:59:07 *** bjwebb has joined #evergreen 2011-06-07T10:59:51 for meeting, i saw the "bugs with patches" section which is awesome -- wanted to add this https://bugs.launchpad.net/evergreen/+bug/776092 2011-06-07T11:00:01 has a patch, but in a git branch rather than as a patch file 2011-06-07T11:00:49 mrpeters-isl: you can add a link to the pullrequest tag query to the agenda 2011-06-07T11:01:52 ah, this is for something that needs to be backported? 2011-06-07T11:02:16 does look that way... 2011-06-07T11:02:59 Given that it's 1.6.1.2, it's not clear to me if the bug reporter is using the old seven-screen patron editor or the new Dojo-ish one 2011-06-07T11:03:11 it impacts both 2011-06-07T11:03:44 Sounds like it needs a separate set of fixes then 2011-06-07T11:03:53 i only know for certain that senator's patch fixes the newer iteration 2011-06-07T11:03:54 agreed 2011-06-07T11:05:08 I guess you could click "this affects me too" to increase the bug's "heat" if what you're saying is that you want more attention brought to it 2011-06-07T11:06:12 not that, so much as just exactly what you reccomended -- looking at bugs with pullrequests too 2011-06-07T11:06:17 berick: You around? 2011-06-07T11:06:52 tsbere: yo 2011-06-07T11:07:10 berick: You review the latest version of the active_date stuff? 2011-06-07T11:08:27 tsbere: not yet 2011-06-07T11:08:46 i'll add it to the dev mtg action items for this week, though 2011-06-07T11:09:13 as a form of personal encouragement/reminder/shame-maker 2011-06-07T11:11:22 mrpeters-isl: problem: there's nothing to pull for 1.6.1.2 in that bug, right? 2011-06-07T11:11:46 *** youdonotexist has joined #evergreen 2011-06-07T11:12:08 * tsbere pushes fix_checkout_overrides to his repo and to working 2011-06-07T11:12:16 would have to defer to senator on that, to be sure, but i'm pretty certain this would only fix the dojo iteration of patron reg 2011-06-07T11:12:25 Anyone want to take a look? I apparently broke a pile of checkout overrides during dynamic weighting and fallthrough. 2011-06-07T11:13:15 if nothing else, at least it could be fixed back through 2.x series 2011-06-07T11:14:19 mrpeters-isl: correct me if I'm wrong, but didn't senator say in that bug that the fix was applied to 2.0+ 2011-06-07T11:14:53 * dbs is testing out dbwells' 791974 2011-06-07T11:15:15 ah, i only saw that it was in a "working" branch and made note of it 2011-06-07T11:15:34 didn't comprehend that it was comitted...ignore me...sorry 2011-06-07T11:16:16 i actually don't see it in the master branch...unless i'm blind 2011-06-07T11:16:22 berick: Well, as for "you haven't gotten to it yet", I just got the contract for doing the work today ;) 2011-06-07T11:20:12 check this out, highlight parts of lines that go over 80 columns. .vimrc: 2011-06-07T11:20:12 highlight OverLength ctermbg=red ctermfg=white guibg=#592929 2011-06-07T11:20:13 match OverLength /\%81v.\+/ 2011-06-07T11:21:54 phasefx: nice 2011-06-07T11:21:56 Hi Everyone, quick question where would one look to see why certain fields in the receipt templates aren't printing? 2011-06-07T11:21:58 For instance on our hold slip the Notify by email: line shows up as %email_notify% and not if the patron is being notified that way. We are on 2.0.6 2011-06-07T11:22:09 tsbere: should I assume you have a good bit left to do with the branch? 2011-06-07T11:22:09 mrpeters-isl: you're right - I missed the working part of working/Evergreen.git 2011-06-07T11:22:18 berick: maybe I should default to 132 columns. This looks very sad for staff client javascript :) 2011-06-07T11:22:47 phasefx: yeah, probably not just the staff client 2011-06-07T11:22:48 phasefx: oh, please keep it at 80 columns! 2011-06-07T11:23:05 dbs: alright, just for you :-) 2011-06-07T11:23:54 * dbs doesn't mind long lines that much, but likes to be conscious of pushing past 80 cols 2011-06-07T11:23:55 berick: Beyond additional "make sure I didn't botch something un-obvious" testing I think it is done. 2011-06-07T11:24:07 Unless it no longer merges cleanly. Then I may have to rebase it a bit. 2011-06-07T11:24:31 * tsbere runs a merge test, gets a conflict 2011-06-07T11:24:33 tsbere: k 2011-06-07T11:24:45 132 chars isn't bad if 100 chars is whitespace :) 2011-06-07T11:24:47 Someone else touched asset schema since I last rebased. 2011-06-07T11:25:23 Oh. *I* did. Via stat cat stuff. 2011-06-07T11:25:24 >_<> 2011-06-07T11:25:31 *>_< 2011-06-07T11:25:40 * dbs lols 2011-06-07T11:27:03 you can pack a hell of a lot of confusing logic into 132 chars, though, which is the primary justification for trying to keep lines short; make them easy to scan and understand what's going on 2011-06-07T11:27:13 and then you can scroll through pages and pages... :) 2011-06-07T11:28:31 berick: Force-pushed a freshly rebased copy. 2011-06-07T11:29:36 tsbere: k, thanks 2011-06-07T11:30:24 Hmmm 2011-06-07T11:31:08 berick: Fair warning, the circ matrix portion of active_date has an issue that is resolved in my "fix_checkout_overrides" branch. I should probably apply that fix to my active_date branch. 2011-06-07T11:31:30 * tsbere knows that the two branches conflict with each other right now, but are both based on the same starting point 2011-06-07T11:31:54 or not...wow. I thought I touched the same functions? 2011-06-07T11:32:30 Oh, right, active_date's find function is the *hold* matrix. Ignore me. <_< 2011-06-07T11:38:23 berick: while you are around gmcharlt mentioned that you might have code hanging around to allow checkout overrides in SIP2. I'm just checking if that is so before I start working on the same things. 2011-06-07T11:43:22 Dyrcona: nope. no checkout overrides, only checkin overrides 2011-06-07T11:45:21 berick: any objections to a configurable checkout override, similar to the checkin overrides being added? 2011-06-07T11:45:37 some of our members would like to allow self-check to override a few things. 2011-06-07T11:48:21 Dyrcona: no objections. I think it would be a welcome addition 2011-06-07T11:49:33 berick: thanks. I'll start a branch, maybe make it a collab if anyone else wants to join in. 2011-06-07T11:49:54 Dyrcona++ 2011-06-07T11:51:30 * dbs runs to get some food 2011-06-07T11:54:24 meeting time! 2011-06-07T11:57:28 almost 2011-06-07T11:57:44 oh dear. i see some clock skew. 2011-06-07T11:58:11 for some reason my clock is always 30 minutes fast when i first boot up :/ 2011-06-07T12:00:23 what does it feel like to live in the future? 2011-06-07T12:00:40 don't apply the fix-future-dob patch! 2011-06-07T12:02:23 * dbs may lose connectivity if the microwave gets turned on 2011-06-07T12:02:34 my clock says 12:02... 2011-06-07T12:02:46 jeff: just speed up and your time will slow down (relative to us, anyway) 2011-06-07T12:04:55 *** ChanServ changes topic to "Dev meeting: http://ur1.ca/4d4gv | Welcome to the #Evergreen library system channel! | We are publicly logged. | Large pastes at http://pastebin.ca or http://paste.lisp.org/new/evergreen or something like that" 2011-06-07T12:05:17 * dbs uses the time travel excuse for the 2012 meeting date he posted for the last meeting 2011-06-07T12:05:46 *** KN2W has joined #evergreen 2011-06-07T12:06:03 dbs: or the year 0 offset 2011-06-07T12:06:04 Heh 2011-06-07T12:06:13 Any takers for minutes / leading the agenda? 2011-06-07T12:06:31 * gmcharlt can lead, need somebody else to take minutes 2011-06-07T12:06:48 * moodaepo will do minutes 2011-06-07T12:06:55 moodaepo: thanks 2011-06-07T12:07:00 gmcharlt++ moodaepo++ 2011-06-07T12:07:13 so to be redundant, agenda is http://evergreen-ils.org/dokuwiki/doku.php?id=dev:meetings:2011-06-07 2011-06-07T12:07:20 so reviewing action items 2011-06-07T12:07:36 3.i and 3.ii are about the release process using git 2011-06-07T12:07:47 eeevil is on vacation (unless he pops in) 2011-06-07T12:08:09 regarding 3.ii, I have yet to write up my thoughts, will try to do so by end of week 2011-06-07T12:08:22 any comments / questions before we move on? 2011-06-07T12:08:53 nope (but wait, that's a comment!) 2011-06-07T12:09:08 ok, moving on to 3.iii and 3.iv 2011-06-07T12:09:21 I have a key from artunit, and will git-ify syrup after the meeting 2011-06-07T12:09:33 gmcharlt++ 2011-06-07T12:09:33 I don't think I have a key from gfawcett yet 2011-06-07T12:09:46 I can take an action to poke gfawcett 2011-06-07T12:09:50 dbs++ 2011-06-07T12:09:56 related question.. best way to git-ify other projects, namely constrictor. just ask gmcharlt? 2011-06-07T12:10:12 berick: yep, tsbere can do it as well 2011-06-07T12:10:19 great, thanks 2011-06-07T12:10:24 will poke about that later 2011-06-07T12:10:32 * gmcharlt cringes in advance ;) 2011-06-07T12:10:55 :) 2011-06-07T12:10:55 3.v - pullrequest tagging - sounds like dbs has completed updating the wiki, any thoughts? 2011-06-07T12:11:39 diffs are here, I think: http://evergreen-ils.org/dokuwiki/doku.php?id=contributing&rev=1305395707&do=diff 2011-06-07T12:12:02 dbs++ 2011-06-07T12:12:26 moving on, 3.vi is a pair of interrelated bugs 2011-06-07T12:12:28 https://bugs.launchpad.net/evergreen/+bug/731521 2011-06-07T12:12:35 https://bugs.launchpad.net/evergreen/+bug/731516 2011-06-07T12:12:48 That's mine. 2011-06-07T12:12:58 The first I marked as duplicate of something jamesrf did recently. 2011-06-07T12:13:13 mrpeters-isl and jamesrf have competing approaches with that one 2011-06-07T12:13:27 Either way though, the second bug is a bigger problem 2011-06-07T12:13:45 And should be fixed before recommending the first change. 2011-06-07T12:14:29 *** slipscomb has joined #evergreen 2011-06-07T12:14:30 Having the full names (if too similar between system and branch) can lead to folks registering patrons at the wrong level. 2011-06-07T12:14:47 So having the full names showing led to... difficulties. During our test. 2011-06-07T12:14:54 Defer to a future meeting I guess. 2011-06-07T12:15:09 May try to resolve later this week (after my life calms slightly more) 2011-06-07T12:15:24 any volunteers to champion a fix for the bugs (or to help out bshum with a fix)? 2011-06-07T12:16:35 I can help w/ those 2 2011-06-07T12:16:48 berick++ # and action item for him, to report back next week 2011-06-07T12:17:49 gmcharlt: I like how you stepped up the meeting frequency, smooth! 2011-06-07T12:17:54 heh 2011-06-07T12:17:58 ok, omvoing on 2011-06-07T12:18:10 heh 2011-06-07T12:18:28 https://bugs.launchpad.net/evergreen/+bug/740320 and https://bugs.launchpad.net/evergreen/+bug/520175 2011-06-07T12:18:58 731521 probably is invalid if it caused problems when used in production 2011-06-07T12:19:06 740320 - I check with eeevil, but we'l get that patch of Joseph's tsed and pushed in the next couple days 2011-06-07T12:19:42 but, alas, if "Can have users" is properly configured (and that bug is fixed) then you wouldn't be able to register users at the wrong level (as in 1.6 and earlier which used "full name") 2011-06-07T12:19:42 520175 - there's some related work 2011-06-07T12:19:46 * gmcharlt looks 2011-06-07T12:20:12 http://git.evergreen-ils.org/?p=evergreen/equinox.git;a=shortlog;h=refs/heads/ext/pioneer-autogrid-improvements 2011-06-07T12:20:31 so I think that can be combined with what jamesrf is doing 2011-06-07T12:20:42 * gmcharlt volunteers to take that on this week 2011-06-07T12:21:23 i just have the one patch really 2011-06-07T12:21:38 kk 2011-06-07T12:23:10 3.viii - https://bugs.launchpad.net/evergreen/+bug/787150 2011-06-07T12:23:38 dbwells++ 2011-06-07T12:23:46 (I committed his fine work) 2011-06-07T12:24:18 ok, then I'll defer the 2.0.7 question to later 2011-06-07T12:24:22 in the agenda 2011-06-07T12:24:37 3.ix https://bugs.launchpad.net/evergreen/+bug/780665 2011-06-07T12:24:40 jamesrf, dbs? 2011-06-07T12:24:55 i'm working on it 2011-06-07T12:25:10 or rather i just have to push it someplace 2011-06-07T12:25:23 jamesrf++ 2011-06-07T12:25:37 (hey, you should send a pubkey to gitadmin@evergreen-ils.org!) 2011-06-07T12:25:42 i've followed miker's suggestion of using the label_Class on the record 2011-06-07T12:26:53 * dbs will review once published 2011-06-07T12:26:59 kk 2011-06-07T12:27:32 3.x - https://bugs.launchpad.net/evergreen/+bug/776583 2011-06-07T12:28:01 so that's pushed 2011-06-07T12:28:04 tsbere++ berick++ 2011-06-07T12:28:09 yeah, not much else to say. tsbere++ 2011-06-07T12:28:21 3.xi - 2.1-rc 2011-06-07T12:28:33 anybody available to put on an eeevil-suit and give an update? 2011-06-07T12:28:55 I'd like consideration of the OpenLibrary AC rewrite for 2.1, if anybody is interested 2011-06-07T12:29:19 user/dbs/openlibrary-read-api-master 2011-06-07T12:29:45 dbs: just needs reviewing? 2011-06-07T12:30:03 sign-off, etc. 2011-06-07T12:30:14 berick: the only piece that I'm iffy about is the hardcoded blank-image location Apache-side 2011-06-07T12:30:48 (it's hardcoded to http://localhost/opac/web/images/blank.png IIRC, which could be a problem for a site that uses /catalog/ instead of /opac/) 2011-06-07T12:31:22 dbs: gotcha. i'll look at the branch, see if anything sticks out and/or if I have any suggestions for that issue 2011-06-07T12:31:34 berick++ # mucho gracias 2011-06-07T12:32:05 we've got a checkout override bug fix that should go in before the rc. 2011-06-07T12:32:27 Dyrcona: where? 2011-06-07T12:32:37 tsbere just started working on it today. 2011-06-07T12:32:49 Dyrcona: eh... bug fixes can go in after RCs 2011-06-07T12:33:00 fix_checkout_overrides branch. Working/my repo. 2011-06-07T12:33:20 this one's a doozy. :) 2011-06-07T12:33:52 bugged / targeted / pullrequest it? 2011-06-07T12:34:00 will do. 2011-06-07T12:34:33 my guess is that 2.1-rc won't happen until eeevil returns from vacationing, unless he's willing to risk family wrath 2011-06-07T12:34:38 So defer RC release discussion to next meeting? 2011-06-07T12:34:56 * dbs would fear S.'s wrath 2011-06-07T12:35:02 sounds good to me. wouldn't want anyone to suffer any wrath. 2011-06-07T12:35:12 moodaepo: not necessarily - that's two weeks away 2011-06-07T12:35:40 dbs: that's a fair guess - when eeevil is back, I think we should encourage doing the RC1 as early next week as possible 2011-06-07T12:35:40 how about "barring any critical blockers, eeevil is welcome to roll 2.1-rc at his leisure"? 2011-06-07T12:36:01 +1 2011-06-07T12:36:11 looking at the checkout overrides patch, I agree that the bug it fixes would be a doozy 2011-06-07T12:36:58 yeah, its the second most "popular" bug on our internal ticket system. 2011-06-07T12:37:09 gmcharlt++ # meeting-leading and code-reading parallel processing 2011-06-07T12:38:00 Dyrcona: tsbere: I'll look at it this week - a specific use case or two on how to trigger the bug would help my review 2011-06-07T12:38:12 so, I think we're ready to move on 2011-06-07T12:38:26 4. recommending OpenSRF 2.0.x for EG 2.0.x? 2011-06-07T12:38:30 gmcharlt: mark item as status missing, try to check it out. ;) 2011-06-07T12:38:38 tsbere: heh. thanks 2011-06-07T12:38:59 so, quick poll - +1/0/-1 on the idea of recommending osrf 2.0.x for EG 2.0.x ? 2011-06-07T12:39:08 fwiw, we're running Evergreen 2.0.x on OpenSRF 2.0.x (everything except for the database server on Debian Lenny) 2011-06-07T12:39:16 0 2011-06-07T12:39:24 +1 (we're also using OpenSRF 2.0.0 with EG 2.0 on Ubuntu Lucid) 2011-06-07T12:39:28 +1 2011-06-07T12:39:41 I'm +1 (if only for the reduction in "OpenSRF was working until we rebooted..." questions) 2011-06-07T12:39:52 see also joseph_++ 2011-06-07T12:40:01 Agreed, joseph_++ for that 2011-06-07T12:40:18 indeed, joseph_++ 2011-06-07T12:40:24 +1 2011-06-07T12:40:30 +1 2011-06-07T12:40:58 * moodaepo nudges gmcharlt 2011-06-07T12:41:08 +1 2011-06-07T12:41:25 dbs and bshum, you're running osrf 2.0 in production? 2011-06-07T12:41:38 berick: yes, we're the Krazy Konifers 2011-06-07T12:41:41 * moodaepo << also on 2.0.6 2011-06-07T12:41:45 berick: We are, yep. 2011-06-07T12:41:50 dbs++ bshum++ 2011-06-07T12:41:51 MVLC is running "master" in production. 2011-06-07T12:42:00 ok, then I think we have a preponderance 2011-06-07T12:42:00 tsbere++ :) 2011-06-07T12:42:04 mvlc++ 2011-06-07T12:42:06 tsbere++ 2011-06-07T12:42:13 * gmcharlt nudges moodaepo back re updating website ;) 2011-06-07T12:42:17 yay for osrf 2.0 finally getting out there 2011-06-07T12:42:30 gmcharlt: Will do. 2011-06-07T12:42:35 moodaepo++ 2011-06-07T12:42:44 ok, moving on 2011-06-07T12:42:48 5. Notice: Conifer is holding TT OPAC development days @ University of Windsor, June 27-29th. If you hack on the TT OPAC and want to join us, get in touch with Dan Scott. 2011-06-07T12:43:04 moving on, patch review 2011-06-07T12:43:05 https://bugs.launchpad.net/evergreen/+bugs?field.searchtext=&orderby=-datecreated&field.status%3Alist=NEW&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&assignee_option=any&field.assignee=&field.bug_reporter=&field.bug_supervisor=&field.bug_commenter=&field.subscriber=&field.tag=&field.tags_combinator=A 2011-06-07T12:43:05 NY&field.has_cve.used=&field.omit_dupes.used=&field.affects_me.used=&field.has_patch.used=&field.has_patch=on&field.has_branches.used=&field.has_no_branches.used=&field.has_blueprints.used=&field.has_no_blueprints.used=&search=Search 2011-06-07T12:43:10 ... meep 2011-06-07T12:43:11 sorry about that 2011-06-07T12:44:11 https://bugs.launchpad.net/evergreen/+bug/790639 - sounds like phasefx has come up with an alternative, and needs review and singoff 2011-06-07T12:44:16 or even signoff 2011-06-07T12:44:28 though singoff might be more entertaining to watch 2011-06-07T12:44:48 Evergreen's Got Talent! 2011-06-07T12:45:07 https://bugs.launchpad.net/evergreen/+bug/787162 - I will review joseph_ 's patch 2011-06-07T12:45:08 gmcharlt++ singoff++ 2011-06-07T12:45:22 *** b_bonner_ has joined #evergreen 2011-06-07T12:45:49 https://bugs.launchpad.net/evergreen/+bug/783590 - phasefx, mind taking point on reviewing this one? 2011-06-07T12:45:51 2 patches enter, 1 patch leaves 2011-06-07T12:46:01 gmcharlt: I'll take it 2011-06-07T12:46:11 phasefx wins! mrpeters-isl will not sing! 2011-06-07T12:47:19 https://bugs.launchpad.net/evergreen/+bug/767507 - fix commited but tweaking needed, apparently 2011-06-07T12:48:24 https://bugs.launchpad.net/evergreen/+bug/758945 - /me will review and push 2011-06-07T12:49:06 * moodaepo needs to run soon but will complete minutes from logs 2011-06-07T12:49:17 https://bugs.launchpad.net/evergreen/+bug/702206 - to discuss with eeevil when he's back 2011-06-07T12:50:09 https://bugs.launchpad.net/evergreen/+bug/510959 - phasefx, any update on this? 2011-06-07T12:50:28 I guess I can take it back, thought I wiped my hands of it 2011-06-07T12:51:13 phasefx: thanks 2011-06-07T12:51:30 https://bugs.launchpad.net/evergreen/+bug/491594 - something that perhaps should be bumped up to a bigger agenda item for the next meeting? 2011-06-07T12:51:38 *** atz__ has joined #evergreen 2011-06-07T12:51:41 berick: anything thoughts on how TT-OPAC woudl deal with ^^ 2011-06-07T12:52:21 gmcharlt: it fixes it. item display is paged 2011-06-07T12:52:29 ok 2011-06-07T12:52:51 we still need to hammer out some sorting deatils, but it will not crash on large sets of holdings 2011-06-07T12:53:37 * dbwells needs to check out for a bit, but will respond later if his nick comes up 2011-06-07T12:53:38 It's also mitigated somewhat in 2.0 by being able to specify a maximum number of holdings to pull in BibTemplate / unAPI 2011-06-07T12:54:24 https://bugs.launchpad.net/evergreen/+bugs?field.tag=pullrequest 2011-06-07T12:54:45 *** atz_ has quit IRC 2011-06-07T12:54:53 then, moving on, looks like https://bugs.launchpad.net/evergreen/+bug/789747 is the most serious of these 2011-06-07T12:55:12 Does Holdings Maintenance deal with hundreds or thousands of copies yet in master? 2011-06-07T12:55:35 no 2011-06-07T12:56:51 phasefx: any thoughts on what it would take to resolve? 2011-06-07T12:57:26 gmcharlt: it's been a standing bug for 5 years, it's probably best to defer that discussion :) 2011-06-07T12:57:33 paging would be a bit thorny.. it's a tree structure with nested rows 2011-06-07T12:57:53 * phasefx thinks a rewrite ;) 2011-06-07T12:58:03 kinda what I figured 2011-06-07T12:58:16 as for unnest ()vs. search.explode_array(), that's a pretty serious one. all stumbling on my part with make-db-patch.pl in trunk aside, I can create separate branches for 2.0/2.1 that focus just on unnest() 2011-06-07T12:58:31 dbs++ 2011-06-07T12:58:35 dbs++ 2011-06-07T12:59:42 re the pull requests, does are there specific ones that anybody is willing to volunteer to review at the moment? 2011-06-07T12:59:53 790616 is ready to go into 2.0 IMO, and reasonably important as well 2011-06-07T13:00:31 dbs: do you mean 790916 ? 2011-06-07T13:00:37 uhh, yeah 2011-06-07T13:00:40 that :) 2011-06-07T13:01:39 I can try the other half of that patch later this afternoon if you need another tester. 2011-06-07T13:03:17 bshum: would be great 2011-06-07T13:03:20 cool 2011-06-07T13:03:57 * tsbere threw a few more pullrequests up just now, for the record 2011-06-07T13:04:41 one a broader note, I wonder if we need to have quick pullrequest review meetings? 2011-06-07T13:04:47 say, every other week? 2011-06-07T13:05:17 Weeks opposite dev meetings or something? Or some other day of the week? 2011-06-07T13:05:38 gmcharlt: you're suggesting "group reviews pullrequests collectively" meetings? 2011-06-07T13:05:40 opposite dev meetings 2011-06-07T13:05:46 dbs: yes 2011-06-07T13:05:51 sounds good to me 2011-06-07T13:05:54 pullrequest meetings being useful because there's an expectation of immediate response/committment, rather than the async delay of email? 2011-06-07T13:06:43 jeff: primarily to avoid bogging down the dev meetings 2011-06-07T13:06:58 async is probably better, as long as we stay on top of it 2011-06-07T13:07:35 so potentially, my suggestion may be more of a threat ;) - deal with pull requests or else we institute more review meetings! 2011-06-07T13:07:35 yep. don't want patches to moulder. 2011-06-07T13:09:04 probably something to discuss on the lists, then 2011-06-07T13:09:21 so then moving on, we have the EG release statuses 2011-06-07T13:09:32 1.6.1.x, 2.0.x, 2.1.x 2011-06-07T13:09:43 2.1.x we know is awaiting eeevil's return 2011-06-07T13:10:11 as is, if not I'm not mistaken, 1.6.1.9 and 2.0.7 2011-06-07T13:11:20 Nobody else has ever created an Evergreen release. 2011-06-07T13:11:22 which I think ties back to 3.i and 3.ii, getting the release cutting better documented 2011-06-07T13:11:42 so, full circle, and another potential agenda item for the next meeting 2011-06-07T13:12:46 OK, we're at 1:06 for the meeting so far; any last minute thoughts or issues before we confirm the next meeting time and go back to our regularly scheduled programming? 2011-06-07T13:13:22 going once 2011-06-07T13:13:48 going twice... 2011-06-07T13:13:59 bacon. :P 2011-06-07T13:14:04 ok, next meeting is currently scheduled for Tuesday, June 21th at 12:00 EST, 9:00 PST. 2011-06-07T13:14:18 which happily does *not* conflict with ALA 2011-06-07T13:14:31 gmcharlt++ # I missed the meeting whip :) 2011-06-07T13:14:39 gmcharlt++ 2011-06-07T13:14:42 so, unless there's any thing else burning, I declare the meeting closed 2011-06-07T13:14:46 gmcharlt++ 2011-06-07T13:14:59 gmcharlt++ moodaepoo++ 2011-06-07T13:16:24 *** jenny has quit IRC 2011-06-07T13:18:03 hey, did someone say bacon? 2011-06-07T13:18:35 http://www.bakonvodka.com/ 2011-06-07T13:19:55 > The Iberian Old-Fashioned - Bacon-infused rye whiskey,brown sugar, molasses, Angostura bitters, Peychaud's bitters, orange and lemon twists 2011-06-07T13:21:33 *** pmplett has joined #evergreen 2011-06-07T13:22:07 yick 2011-06-07T13:22:20 sound like it mighit knock out my cold though :) 2011-06-07T13:27:36 From earlier today, Meliss was asking a question... 2011-06-07T13:27:36 (11:21:56 AM) Meliss: Hi Everyone, quick question where would one look to see why certain fields in the receipt templates aren't printing? 2011-06-07T13:27:36 (11:21:58 AM) Meliss: For instance on our hold slip the Notify by email: line shows up as %email_notify% and not if the patron is being notified that way. We are on 2.0.6 2011-06-07T13:27:50 Any suggestions? 2011-06-07T13:28:03 Double-check the macros and where they are being used. 2011-06-07T13:28:45 We checked the macros and they're spelled (and cased) using what was suggested in the macros window. Unless that was a lie... 2011-06-07T13:29:17 Tried moving them between the header/line item areas to see if that made a difference. 2011-06-07T13:29:27 It seemed that hold slips don't print the line-item portions 2011-06-07T13:32:26 Or at last, it didn't seem to for us. 2011-06-07T13:32:34 I'm double-checking right now 2011-06-07T13:33:34 *** agJohn has joined #evergreen 2011-06-07T13:37:59 *** joseph_ has quit IRC 2011-06-07T13:47:51 *** slipscomb has left #evergreen 2011-06-07T14:01:34 tsbere: Verified that the problem seems to be the %notify_by_email% (or phone) options. 2011-06-07T14:01:49 The macros listing shows it as "email_notify" but the default seems to be "notify_by_email" 2011-06-07T14:01:55 Neither prints anything other than the variable though 2011-06-07T14:03:26 *** jenny1 has joined #evergreen 2011-06-07T14:03:58 Not sure. Would need to dig in....and I would be doing so on 2.1/master, not 2.0. 2011-06-07T14:07:29 Fair enough. 2011-06-07T14:07:34 Just picking at it. 2011-06-07T14:07:43 To see if we can't figure out what went wrong. 2011-06-07T14:19:58 gmcharlt: You got keys/syrup stuff today, or should I take a crack at the keys? 2011-06-07T14:20:34 tsbere: I've got it 2011-06-07T14:21:08 * tsbere wonders if he should fire off dev list emails for all the launchpad bugs he has opened today 2011-06-07T14:33:10 *** yboston has joined #evergreen 2011-06-07T14:37:16 can anyone tell me where asset.record_copy_count is used? i simply can't find it 2011-06-07T14:40:19 jamesrf: maybe in fulfILLment? 2011-06-07T14:43:29 ah i found it it's in open-ils.search.biblio.record.copy_count but it's dynamically generated 2011-06-07T14:43:40 doesn't appear to get used anywhere. there's a reference to biblio.record_copy_count in O:A:Storage that looks like it's confused between asset and biblio 2011-06-07T14:44:51 it's in sub record_id_to_copy_count some sneaky json_query building 2011-06-07T14:45:16 right, I see. hmm 2011-06-07T14:47:19 uh oh. just got our first negative balance owing ticket 2011-06-07T14:48:04 "Can you please tell us HOW to make this balance go to "0" instead of "-66.00"? We tried everything! .... I tried in that case to pay "Cash" for the 20$. It worked, but then he has a refund of 20$ coming to him" 2011-06-07T14:49:26 yeah. those are fun. i would like to kill the ability to create those without a specific permission. 2011-06-07T14:49:43 IS_BILLING_WIZARD perhaps 2011-06-07T14:49:46 :P 2011-06-07T14:49:58 mostly, getting away from voiding bills would be a start. 2011-06-07T14:50:21 forgive/write-off vs void. 2011-06-07T14:50:27 * dbs hasn't had a chance to dig into the backstory on this particular example, and if/whether its related to the 1.6->2.0 upgrade; just remembers seeing discussion about this 2011-06-07T14:50:55 * dbs wonders how many bills have been voided in the past two years 2011-06-07T14:51:13 3.6 voided billings per hour! 2011-06-07T14:51:39 * dbs also tries to finish testing user/dbs/explode_array_to_unnest_2_0 (although keeners can jump on it and its 2_1 / master variants if they so desire) 2011-06-07T14:53:32 we are having similar issues with voiding/billing 2011-06-07T14:54:41 *** shadowspar has quit IRC 2011-06-07T14:57:04 money.usr_circulation_summary is giving us a different answer than money.usr_summary, presumably due to "WHERE billable_xact_summary.xact_type = 'circulation'::name" 2011-06-07T14:59:28 *** gdunbar has quit IRC 2011-06-07T14:59:55 LOST stop_fines, xact_finish is NULL, these are ringing bells with tickets I've read I think 2011-06-07T15:01:14 Looks like the LOST fee was paid (checking SELECT * FROM money.payment WHERE xact = (action.circulation.id)) 2011-06-07T15:02:22 So it's WHERE ... materialized_billable_xact_summary.xact_finish IS NULL in money.open_usr_circulation_summary sticking a wrench into things 2011-06-07T15:03:58 nope, it's the xact_type = circulation 2011-06-07T15:04:17 * dbs needs IS_BILLING_WIZARD perms :) 2011-06-07T15:10:48 * dbs peers back in money.billable_xact_summary: "fine added to cancel balance of $-20.00 when a book found on the shelf was backdated and discharged" 2011-06-07T15:13:22 interesting entry: total_paid = 130.00, total_owed = 110.00, balance_owed = 20.00. I guess that's where the trouble began. 2011-06-07T15:16:32 jeff is also right, there's $20 worth of voided fines. oh headaches. 2011-06-07T15:22:10 dbs: we started seeing refunds that hadn't been there before in patron Bills screen after upgrading to 2.0 2011-06-07T15:22:36 IIRC fines on closed circs were completely invisible in the staff client pre-2.0 2011-06-07T15:25:10 jeffdavis: sounds like this might be in the same vein 2011-06-07T15:29:05 dbs: standard "fix improperly voided bills where there was a payment" for me is "add billing of type misc for voided amount with an obvious note" 2011-06-07T15:34:46 * dbs wondering if those $20 in fines were auto-voided on return of a lost item 2011-06-07T15:35:34 "System: VOIDED FOR BACKDATE" suggests so 2011-06-07T15:37:45 some libraries prefer that. the void lost fine on checkin logic uses a cutoff date. 2011-06-07T15:38:06 in our environment, we prefer things never be voided, and refunds not be generated/owed. 2011-06-07T15:38:39 so i've sketched out (on whiteboard only) logic to never void / auto-void, just to make Forgive payments for those kinds of things, and only for the remaining balance. 2011-06-07T15:38:58 not sure if others have that same desire. plan to ask on list sometime. 2011-06-07T15:39:27 if using something to tie payments to billing type, voiding bills on a transaction with payments can make the allocations incorrect. 2011-06-07T15:40:24 Yeah, that appears to be the case here, that WHERE clause in money.open_usr_circulation_summary isstock 2011-06-07T15:40:51 * dbs wouldn't care about void vs. forgive as long as it worked either way :) 2011-06-07T15:40:53 tsbere: Looks like it's data issue on our side. The values weren't showing up because there was no phone assigned or email for the patron. No way for the receipt to know that. Ignore us for now, sorry for the false alarm. 2011-06-07T16:02:28 *** Meliss has quit IRC 2011-06-07T16:07:06 btw, calling 0549 through 0554 2011-06-07T16:08:45 *** elaineg has joined #evergreen 2011-06-07T16:09:07 https://bugs.launchpad.net/evergreen/+bug/789747 (explode_array -> unnest) has a new set of branches for eager tester-committers 2011-06-07T16:09:29 including backporting through rel_2_0; easy credit! 2011-06-07T16:09:55 *** elaineg has quit IRC 2011-06-07T16:30:00 *** lisppaste has quit IRC 2011-06-07T16:30:10 *** KingNightWolf has joined #evergreen 2011-06-07T16:31:50 *** KingNightWolf has quit IRC 2011-06-07T16:32:47 *** lisppaste has joined #evergreen 2011-06-07T16:34:08 *** KN2W has quit IRC 2011-06-07T16:35:30 jeff:We would be intrested in code to forgive only unpaid balances 2011-06-07T16:37:38 AaronZ-PLS: specifically at things like check-in, places where the system currently auto-voids? 2011-06-07T16:38:04 AaronZ-PLS: or are you also concerned about things like staff over-paying a "forgive" payment? I don't recall the last time I tested that... 2011-06-07T16:47:07 *** kmlussier has quit IRC 2011-06-07T16:48:58 aha - https://bugs.launchpad.net/evergreen/+bug/758982 - this is the bug for LOST / billing madness I was thinking of 2011-06-07T16:49:22 https://bugs.launchpad.net/evergreen/+bug/758982/+affectsmetoo to increase the HEAT 2011-06-07T16:51:18 hrmm, I opened one recently that's probably dupe-worthy 2011-06-07T16:51:38 https://bugs.launchpad.net/evergreen/+bug/793550 2011-06-07T16:51:38 yeah, i think i saw phasefx's 2011-06-07T16:52:20 i think they might each have their nuances. 2011-06-07T17:04:04 dbs: regarding blank.png in openlibrary-read-api-master. you could set/read the path from a new opensrf.xml setting or apache env variable. 2011-06-07T17:04:19 though, i'm guesssing you already though of and discarded those for various reasons 2011-06-07T17:04:28 *thought 2011-06-07T17:06:00 berick: yeah, I was hoping to make it automatic 2011-06-07T17:06:01 in either case, I think we should pass the request rec ($r) down to the handlers via ->new, which accepts a hash 2011-06-07T17:06:22 for other config-y things 2011-06-07T17:06:24 can we use the existing apache env environment for images host, if available? 2011-06-07T17:06:34 i don't see why not 2011-06-07T17:06:49 i /think/ that env var will be availble to mod_perl 2011-06-07T17:09:39 They should all be available to mod_perl or CGI.pm. or even just $ENV{} in perl. 2011-06-07T17:17:59 pinesol: seen sylvar 2011-06-07T17:18:26 @seen sylvar 2011-06-07T17:18:26 berick: sylvar was last seen in #evergreen 2 weeks, 1 day, 1 hour, 16 minutes, and 0 seconds ago: * sylvar gives up on wrestling with git for now; tomorrow is another day 2011-06-07T17:18:33 Thanks berick 2011-06-07T17:18:37 yup 2011-06-07T17:21:36 *** b_bonner_ has left #evergreen 2011-06-07T17:21:44 * dbs imagines sylvar replacing Mickey Rourke 2011-06-07T17:21:46 @seen Waldo 2011-06-07T17:21:46 Dyrcona: I have not seen Waldo. 2011-06-07T17:22:16 Sorry. It has been a long day, need a little levity. 2011-06-07T17:23:49 @quote random 2011-06-07T17:23:49 berick: Quote #6: " i meant to use that quote in my talk :)" (added by gmcharlt at 07:24 PM, April 29, 2011) 2011-06-07T17:23:51 -= THIS MESSAGE NOT LOGGED =- 2011-06-07T17:24:21 @quote random 2011-06-07T17:24:21 Dyrcona: Quote #1: " much as a cancer would develop from chewing on uranium rocks ... but the tooth decay is lovely!" (added by gmcharlt at 11:22 AM, February 17, 2011) 2011-06-07T17:25:12 @quote 2 2011-06-07T17:25:12 Dyrcona: Error: The "Quote" plugin is loaded, but there is no command named "2" in it. Try "list Quote" to see the commands in the "Quote" plugin. 2011-06-07T17:25:24 @list quote 2011-06-07T17:25:24 Dyrcona: add, change, get, random, remove, search, and stats 2011-06-07T17:25:35 @quote get 2 2011-06-07T17:25:35 Dyrcona: Quote #2: " We need more quotes" (added by berick at 11:24 AM, February 17, 2011) 2011-06-07T17:26:10 @quote stats 2011-06-07T17:26:10 Dyrcona: There are 10 quotes in my database. 2011-06-07T17:26:56 @quote add There are 10 quotes in my database. 2011-06-07T17:26:56 Dyrcona: The operation succeeded. Quote #12 added. 2011-06-07T17:27:47 pinesol counts in base 12. :) 2011-06-07T17:28:42 ah well, about time to go home. 2011-06-07T17:29:44 *** Dyrcona has quit IRC 2011-06-07T17:36:53 *** yboston has quit IRC 2011-06-07T17:53:48 *** granitize has joined #evergreen 2011-06-07T17:55:39 dbs: you follow bkuhn and fontana too eh? such fun .. and educational too 2011-06-07T17:56:54 *** jenny1 has left #evergreen 2011-06-07T18:00:28 *** Stompro has quit IRC 2011-06-07T18:14:56 *** granitize has quit IRC 2011-06-07T19:09:39 *** dbs has quit IRC 2011-06-07T19:11:35 *** pmplett has quit IRC 2011-06-07T19:12:03 *** youdonotexist has quit IRC 2011-06-07T20:31:26 *** robbat2 has left #evergreen 2011-06-07T20:34:48 *** agJohn has quit IRC 2011-06-07T20:51:10 *** shadowspar has joined #evergreen 2011-06-07T22:11:13 *** phasefx has quit IRC 2011-06-07T22:11:13 *** jamesrf has quit IRC 2011-06-07T22:11:14 *** _dkyle_ has quit IRC 2011-06-07T22:11:14 *** rangi has quit IRC 2011-06-07T22:11:14 *** deel has quit IRC 2011-06-07T22:11:14 *** phasefx2 has quit IRC 2011-06-07T22:11:18 *** phasefx has joined #evergreen 2011-06-07T22:11:19 *** deel has joined #evergreen 2011-06-07T22:11:19 *** rangi has joined #evergreen 2011-06-07T22:11:21 *** rangi has joined #evergreen 2011-06-07T22:11:37 *** jamesrf has joined #evergreen 2011-06-07T22:12:12 *** _dkyle_ has joined #evergreen 2011-06-07T22:16:30 *** phasefx2 has joined #evergreen 2011-06-07T22:55:58 *** dbs has joined #evergreen 2011-06-07T22:55:59 *** dbs has joined #evergreen 2011-06-07T22:57:39 rangi: yeah, bkuhn and fontana are a FaiF comedy duo 2011-06-07T22:58:34 :)