2011-10-07T00:10:51 *** Callender has joined #evergreen 2011-10-07T00:21:38 *** Callender has quit IRC 2011-10-07T00:29:35 *** lisah_ has joined #evergreen 2011-10-07T00:40:50 *** Callender has joined #evergreen 2011-10-07T00:46:08 *** Callender has quit IRC 2011-10-07T01:01:25 *** lisah_ has quit IRC 2011-10-07T01:54:06 *** Callender has joined #evergreen 2011-10-07T02:11:18 *** Callender has quit IRC 2011-10-07T02:25:49 *** Callender has joined #evergreen 2011-10-07T02:37:35 *** youdonotexist has quit IRC 2011-10-07T03:55:21 *** dbwells_ has joined #evergreen 2011-10-07T03:57:22 *** dbwells has quit IRC 2011-10-07T04:40:18 *** jeffdavis has quit IRC 2011-10-07T04:40:23 *** jeffdavis has joined #evergreen 2011-10-07T06:01:08 *** Callender has quit IRC 2011-10-07T06:26:01 *** Callender has joined #evergreen 2011-10-07T06:39:38 *** Callender has quit IRC 2011-10-07T06:55:56 *** Callender has joined #evergreen 2011-10-07T07:50:17 tsbere: dbwells_: fwiw, we are dealing with the patron consternation around the behavior of the grace day. Our situation is complicated by the fact that the grace day used to be a "freebie", meaning that fines were *never* owed for the first day after the due date 2011-10-07T07:50:30 and patrons (and staff) came to expect that 2011-10-07T07:50:53 explaining that it now works like a real grace day does has been not so easy ;-) 2011-10-07T07:51:20 Wait, it used to not charge fines for the first day, period? 2011-10-07T07:51:32 * csharp likes the "new" behavior better and thinks its more in line with how things should be 2011-10-07T07:51:44 tsbere: yes, at least that's what I hear in PINES 2011-10-07T07:52:13 I think it was a side effect of the way fines were charged before 2011-10-07T07:52:43 they used to be charged at the end of the day, now they are charged at the beginning (as far as I understand) 2011-10-07T07:53:02 * csharp has never been an Evergreen end user 2011-10-07T07:59:15 Ahhh 2011-10-07T07:59:26 I can see that being the case 2011-10-07T07:59:45 At this point it doesn't matter when you generate them, really. At checkin in 2.1+ they get generated if needed anyway. 2011-10-07T08:00:01 yeah - that will be way better 2011-10-07T08:00:44 I think some of our issues arise from the fact that 1.6(.1) is a 1.4/2.0 hybrid and that we are using legacy circ, not in-DB 2011-10-07T08:01:40 we'll be more in line with everybody else when we move to in-DB with 2.1 (planned next month) 2011-10-07T08:01:41 legacy circ compared to indb doesn't actually have an effect on fines, though ;) 2011-10-07T08:01:58 right - I was speaking in general 2011-10-07T08:02:04 * csharp wasn't clear 2011-10-07T08:03:27 nearly every 1.6 issue we've faced has had the the answers "fixed in 2.0+" or "move to in-DB circ" 2011-10-07T08:04:00 which is a nice place to be ;-) 2011-10-07T08:06:37 *** collum has joined #evergreen 2011-10-07T08:07:49 heh 2011-10-07T08:27:14 *** AaronZ-PLS has joined #evergreen 2011-10-07T08:29:30 *** Dyrcona has joined #evergreen 2011-10-07T08:47:30 *** tsbere has quit IRC 2011-10-07T08:48:33 *** tsbere has joined #evergreen 2011-10-07T09:11:09 *** AaronZ-PLS has quit IRC 2011-10-07T09:16:57 *** Callender has quit IRC 2011-10-07T09:17:27 *** sal_ has joined #evergreen 2011-10-07T09:18:58 *** adbowling-isl has joined #evergreen 2011-10-07T09:21:37 *** atz has joined #evergreen 2011-10-07T09:24:25 *** atz_ has quit IRC 2011-10-07T09:32:40 *** Callender has joined #evergreen 2011-10-07T09:35:04 anyone ever tinkered with SIP to try and prevent users authenticating with a replaced actor.card.barcode ? 2011-10-07T09:35:29 mrpeters-isl: Yes. 2011-10-07T09:35:38 And gotten it committed to master, at least 2011-10-07T09:35:44 * tsbere isn't sure how far back that one is 2011-10-07T09:35:53 cool, ill dig then 2011-10-07T09:38:04 mrpeters-isl: there are a few ways to do it. entirely server-side, thankfully. :-) 2011-10-07T09:38:12 (well, it's sip -- so i'd hope so) 2011-10-07T09:38:15 do tell! 2011-10-07T09:38:34 mrpeters-isl: what are you running in production? 2011-10-07T09:38:37 2.0.4 2011-10-07T09:38:44 sip....not sure 2011-10-07T09:40:12 can't seem to find a version number 2011-10-07T09:41:27 perhaps easiest: change {barcode => $patron_id} to {barcode => $patron_id, active => 't'} on the search_actor_card call in SIP/Patron.pm: http://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/perlmods/OpenILS/SIP/Patron.pm;h=c628820a2d0dfa2da9f68241cb4deb4cd83b3d4a;hb=refs/heads/rel_2_0#l82 2011-10-07T09:41:38 my $card = $e->search_actor_card([{barcode => $patron_id, active => 't'}, $usr_flesh])->[0]; 2011-10-07T09:41:43 oh nice! 2011-10-07T09:41:56 master does it a slightly different way. 2011-10-07T09:43:15 we do transforms of some barcodes (lowercasing letters, stripping trailing digits). i need to make this master-friendly by making it configurable per sip client / configurable transforms: https://github.com/tadl/rel_2_1/blob/tadl_sip_barcode_transforms/lib/SIP/Patron.pm 2011-10-07T09:44:55 er, https://github.com/tadl/rel_2_1/commit/2d1e0a702dc5b7ae07ba9d5c2b9ad64e69909fbc 2011-10-07T09:50:14 *** sal_ has quit IRC 2011-10-07T09:53:03 2.0 > 2.1 upgrade wants to drop config.language_map but can't due to reporter.classic_current_circ. Should this be skipped, or set to CASCADE? 2011-10-07T09:53:57 FYI: my $card = $e->search_actor_card([{barcode => $patron_id, active => 't'}, $usr_flesh])->[0]; 2011-10-07T09:53:59 is dangerous if search_actor_card ever returns other than an arrayref. It can and does under the 2011-10-07T09:54:01 right circumstances. 2011-10-07T09:54:56 *** kmlussier has joined #evergreen 2011-10-07T10:03:22 I found a typo (I think) with the JSPac hold edit interface. 2011-10-07T10:04:58 Hmmm. Still not sure about how to deal with some of what is happening, though. 2011-10-07T10:21:07 In our experience, voiding bills is problematic at times. We're leaning toward having the system make Forgive payments instead of voiding, especially where there are existing payments on the transaction. 2011-10-07T10:21:16 Has anyone else here given thought to this? 2011-10-07T10:22:06 We generally recommend forgive payments. 2011-10-07T10:22:29 to our members' staff, that is. 2011-10-07T10:25:08 same here 2011-10-07T10:28:17 Voiding sucks. 2011-10-07T10:28:19 :) 2011-10-07T10:28:51 bshum: one can only hope 2011-10-07T10:28:57 *** yboston has joined #evergreen 2011-10-07T10:30:54 * mrpeters-isl would like to see TTPac use a payment type like "opac_cc_payment" to differentiate it from a staff client "credit_card_payment" 2011-10-07T10:31:04 *** sal_ has joined #evergreen 2011-10-07T10:33:55 I'm thinking of having bill-on-lost Forgive the remaining late fines rather than void, and on checkin of a lost item, forgive the lost billings instead of voiding. 2011-10-07T10:34:14 I'm not sure how best to re-bill for the overdues if that's still desired. 2011-10-07T10:35:03 But probably just walk the bills for the circ, and pair the overdue bills with payments to see how much we forgave, then re-bill that as a single bill. 2011-10-07T10:35:13 jeff: maybe it is better to articulate the problems with voided billings and then to fix those? 2011-10-07T10:35:48 they change history when you are attributing payments to billing types. 2011-10-07T10:36:08 mrpeters-isl: I strongly recommend dropping reporter.classic_current_circ, running the upgrade, then adding reporter.classic_current_circ back. it's an example view -- "here's something you can do!" -- and if other things are blocking the drop that are required objects (should not be, but...) then you'll want to know 2011-10-07T10:36:12 i can articulate that better at some point, but that's one of the issues in a nutshell. 2011-10-07T10:36:42 eeevil: i went ahead and did that, took care of things. worthy of a patch to the upgrade script? 2011-10-07T10:37:36 jeff: there's an "overbill" (not bill more, but bill even when there's a voided billing in that slot) mode in the fine generator. dunno if it's engaged by any end-user-accessible code, though 2011-10-07T10:38:24 eeevil: ooh, so in theory, with 2.1's bill late fee on checkin, and overbill, the system might take care of billing overdue fines up to maxfines when checking in a lost item. worth looking into. 2011-10-07T10:39:21 mrpeters-isl: because it's an example, I tend to say no ... instead, if you're feeling saucy, you might consider writing a stored proc that can be used to check for non-evergeen-core objects that place extra dependencies on tables/views/etc that the core is not aware of 2011-10-07T10:39:53 jeff: well, the overbill mode has been there ... since nearly the begining, I think, but yes that is do-able 2011-10-07T10:41:44 jeff: git blame says: 2011-10-07T10:41:45 2bf6f120 Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/action.pm (Mike Rylander 2006-08-28 19:31:33 +0000 784) my $overbill = shift; 2011-10-07T10:42:13 eeevil: but is "bill any remaining fines on checkin" new? 2011-10-07T10:42:27 where "remaining" == "not previously generated" 2011-10-07T10:43:27 jeff: automatically doing that at checkin, yes. the ability for the fine generator to do that, no 2011-10-07T10:44:05 got it. 2011-10-07T10:44:27 *** dbs has joined #evergreen 2011-10-07T10:44:27 *** dbs has joined #evergreen 2011-10-07T10:44:29 you can (at the cost of not knowing what the accrued fines are, patron or staff) effectively turn off the fine generator cron job now 2011-10-07T10:45:20 but, esp for high circ volume, I'd advise against doing that 2011-10-07T10:45:57 hoping to get mmpbbt and auto-lost without breaking mmpbbt going here. :-) 2011-10-07T10:46:04 looks like forgiving instead of voiding will help some 2011-10-07T10:51:03 *** wjr has quit IRC 2011-10-07T10:56:41 *** wjr has joined #evergreen 2011-10-07T10:59:41 osrfsys.log:open-ils.auth 2011-10-07 10:58:44 [DEBG:6304:osrf_cache.c:78:131799931965270] Failed to get key [oils_auth_admin_count] - NOT FOUND 2011-10-07T11:00:11 that's from an up-to-date master 2011-10-07T11:00:27 phasefx: I've been seeing that off an on for months in master. 2011-10-07T11:00:40 first time for me 2011-10-07T11:00:57 phasefx: I've not pinned it down to a problem with memcached or with osrf_cache.c, yet. 2011-10-07T11:01:26 happens intermittently, but leads to some problems with "network errors" and SIP2. 2011-10-07T11:02:18 well, not that error exactly, but failures to get various things from memcached. 2011-10-07T11:02:34 usually fails retrieving sessions. 2011-10-07T11:02:49 maybe it isn't the same thing after all...... :/ 2011-10-07T11:03:05 * phasefx was suspecting the recent bruteforce fixes 2011-10-07T11:03:25 For the record 2011-10-07T11:03:31 The "key not found" for that part there? 2011-10-07T11:03:41 Probably expected when no attempts to login with that user happened in the past 90 seconds. 2011-10-07T11:03:48 sounds right to me 2011-10-07T11:03:49 It loads the key to look for it 2011-10-07T11:04:02 If it isn't there, it creates it 2011-10-07T11:04:30 other stuff was breaking during login, so it didn't seem to be a harmless error 2011-10-07T11:04:43 *** bwicksall has quit IRC 2011-10-07T11:05:17 define "other stuff breaking" 2011-10-07T11:06:14 Error in global_utils.js, ses(): TypeError: data.list.au is undefined 2011-10-07T11:06:28 That has nothing to do with the login code 2011-10-07T11:06:40 at least not the C level code 2011-10-07T11:06:42 yeah, error's not happening now.. coincidence maybe 2011-10-07T11:07:10 I suspect if you had issues with the C level code your password would have been rejected instead ;) 2011-10-07T11:08:43 * phasefx had introduced a change; thought it was utterly safe, but apparently not. sorry for jumping the gun 2011-10-07T11:09:41 not even sure how I caught that key thing, though I was grepping for ERROR's, not DEBG's 2011-10-07T11:10:16 bah, '\[ERR|Fail' mislead myself 2011-10-07T11:10:49 * Dyrcona was going to edit osrf_cache.c to log memcached responses, but never did. 2011-10-07T11:11:24 I think I stopped seeing those errors on my dev machine, and would have to turn logging up to 4 to check production. 2011-10-07T11:11:49 that fills disk rather quickly. 2011-10-07T11:17:44 Not sure if this is true across the board yet, but I'm having some pretty big problems with the latest Lucid backport package for postgresql-common and friends. I accidentally upgraded one of our test servers to it, and then installed with another test server just now and now both are crippled. The system complains about being unable to open the right process and any /etc/init.d/postgresql actions die. 2011-10-07T11:18:01 Just thought I'd let you guys know in case anyone's trying to install PG 9 today on a Lucid machine 2011-10-07T11:21:32 *** sal_ has quit IRC 2011-10-07T11:22:43 *** nivardus has joined #evergreen 2011-10-07T11:22:56 *** nivardus is now known as bgoble 2011-10-07T11:24:24 bshum: how could I recreate that? Follow the install instructions on lucid and watch it fail? or would I need to install 8.4 and upgrade? 2011-10-07T11:24:54 csharp: I'm not entirely sure actually, I haven't gone from scratch yet, trying to make sure I don't lose all our test database data. 2011-10-07T11:25:06 bshum: "latest" = 9.1 or 9.0? 2011-10-07T11:25:11 just to be clear 2011-10-07T11:25:25 csharp: What appears to have happened is that PG9.0 was installed on my Lucid boxes and now upgrading them has led to this error 2011-10-07T11:25:41 upgrading from 9.0 to 9.1? 2011-10-07T11:25:42 dbs: 9.0 sorry. 2011-10-07T11:25:58 or upgrading EG? 2011-10-07T11:25:59 It looks to be only the postgresql-common package that's "stuck" 2011-10-07T11:26:09 It's really a postgresql problem 2011-10-07T11:26:12 ok 2011-10-07T11:26:24 I'll try to recreate it in a vm 2011-10-07T11:26:28 The LP backports that we've been using shows that that package was changed 2 hours ago 2011-10-07T11:26:46 ah - I see 2011-10-07T11:27:28 we might need to recommend apt pinning 2011-10-07T11:32:22 until, of course, the postgresql backports release a security fix and everybody's pinned with an insecure version 2011-10-07T11:33:03 if a bug hasn't been filed with ubuntu already, then it should be; then the problem can be fixed at the right place 2011-10-07T11:37:51 dbs: Unrelated to my problem, but I just noticed that the 2.1.0 README file says to use the official lucid-backports for postgresql 9. That won't work for us, since PG9 hasn't been backported for Lucid officially. 2011-10-07T11:38:06 I've been using a specific PPA, and so have some others I think. 2011-10-07T11:38:21 bshum: I don't run Ubuntu - please submit changes. 2011-10-07T11:38:27 dbs: Will do. 2011-10-07T11:38:32 Those instructions have been in the README for months 2011-10-07T11:39:25 http://www.dctrwatson.com/2010/09/installing-postgresql-9-0-on-ubuntu-10-04/ I guess? 2011-10-07T11:39:56 dbs: Yeah that looks like it. It's Pitti's PPA. 2011-10-07T11:40:03 long term support, short term usable 2011-10-07T11:40:09 Right 2011-10-07T11:40:56 phasefx-- 2011-10-07T11:41:12 well PPAs are not "in-channel" sources, fwiw 2011-10-07T11:41:23 05f49e9f344f988fb0fe70739b02d4 ain't no one-line obvious fix 2011-10-07T11:41:37 csharp: exactly 2011-10-07T11:43:49 dbs: modifying an example file with no sign off or launchpad entry? 2011-10-07T11:44:48 phasefx: I guess. 2011-10-07T11:45:10 * phasefx is a bad boy, but can do better 2011-10-07T11:45:36 We don't really have a policy about "stuff that is part of master repo but which isn't part of the default experience" 2011-10-07T11:46:41 *** jeffdavis has quit IRC 2011-10-07T11:56:44 do we have a launchpad tag for requesting reviews that don't actually deal with code in a branch that needs to be pulled? 2011-10-07T11:59:06 if the branch doesn't need to be pulled, then how does it get into master? 2011-10-07T11:59:18 I'm not sure I follow 2011-10-07T11:59:50 osmosis? ;) 2011-10-07T12:00:07 I guess it's just the default state of a bug.. they should all get looked at :) 2011-10-07T12:01:22 https://bugs.launchpad.net/evergreen/+bug/870094 2011-10-07T12:02:09 pinesol_green: you no reporty on URL's? that's awfully quiet/nice of you 2011-10-07T12:02:09 phasefx: Error: "you" is not a valid command. 2011-10-07T12:03:30 @eightball should we expect more features from pinesol_green? 2011-10-07T12:03:30 csharp: Come again? 2011-10-07T12:03:50 * phasefx can see us all playing hangman in here 2011-10-07T12:04:47 @roulette 2011-10-07T12:04:47 csharp: *click* 2011-10-07T12:09:21 *** jeffdavis has joined #evergreen 2011-10-07T12:09:27 *** sal_ has joined #evergreen 2011-10-07T12:12:51 there's my commitfest proposal that contains a reviewrequest (or similar) tag 2011-10-07T12:15:03 (aside: since we're all generating bigger feature branches for upcoming releases (which IMO would benefit from earlier exposure and review as compared to small feature and bugfix pullrequest branches), would anyone want to discuss my commitfest proposal, modifications thereto, etc?) 2011-10-07T12:20:40 eeevil: email? 2011-10-07T12:21:03 dbs: thoughts about the library settings section that I just added to the release notes? 2011-10-07T12:21:15 that's one part of it that can be generated mostly automatically 2011-10-07T12:22:43 berick: I'm looking for a little support for the idea (basically, something bigger than a 1-afternoon pullrequestfest) before putting in the effort to push it along, but yeah, we can discuss in email 2011-10-07T12:23:53 gmcharlt: looks good - formats nicely for me 2011-10-07T12:24:30 thanks 2011-10-07T12:25:08 eeevil: sorry, i meant, did you send something via email? 2011-10-07T12:25:17 not seeing a proposal anywhere 2011-10-07T12:25:49 dbs: looking at it is giving me an itch to revamp how the patron registration form preferences are managed 2011-10-07T12:25:50 eeevil: I'm hot and cold about commitfests. I feel like some important features didn't make it into 2.1 even though they landed 3 months ago, and I fear commitfest process may introduce more delay 2011-10-07T12:27:48 I still feel that broader, better, deeper automated testing would give us way more bang for the buck. "Does this break anything?" "Looks okay. Works in this VM with a handful of records." is sort of our current process 2011-10-07T12:28:14 berick: I'll get you the email link 2011-10-07T12:28:53 berick: thread begins at http://markmail.org/thread/nela4blxe7iriryl 2011-10-07T12:31:48 ah, thanks dbs 2011-10-07T12:32:16 dbs: fair enough ... if I still think it'll help after we /actually/ do faster releases, I'll re-raise it 2011-10-07T12:33:07 eeevil: i very much like the idea of communicating early, a la "Hey, I plan to work on X - here's how I plan to go about it - sound sane?" 2011-10-07T12:33:09 speaking of which, time to start pulling big branches into master? 2011-10-07T12:34:42 or small branches. :) 2011-10-07T12:35:00 eeevil: I'm not sure why this time is any different than any other time? Assuming the branches are reviewed, tested, etc 2011-10-07T12:35:22 If "big branch" means "lots and lots of code, haven't really tested all of it", then no 2011-10-07T12:35:40 in my opinion only, of course 2011-10-07T12:36:33 but really - it would be awfully nice to have a master that we're confident in cutting a release from at any time 2011-10-07T12:37:14 dbs: maybe I don't have a good handle on whats outstanding at this point. I'm talking more about any feature branches that we (well, I, personally) have been ignoring in preference to getting 2.1 out the door 2011-10-07T12:37:45 so, we're really talking about different sides of the same coin 2011-10-07T12:37:52 sounds like it 2011-10-07T12:39:54 looking at the pullrequest list in LP, there are 54 bugs ... some of them are big-ish, some are not ... but now would be the time to start pulling them in, I think (assuming quality allows, obv) 2011-10-07T12:40:30 * tsbere has had his hand in the code of a significant number of those 2011-10-07T12:42:58 * Dyrcona agrees with "but really - it would be awfully nice to have a master that we're confident in cutting a release from at any time" 2011-10-07T12:43:17 Dyrcona: I don't think anyone doesn't want that ;) 2011-10-07T12:43:53 quick! raise your hand if you *like* unstable code! ;) 2011-10-07T12:44:17 There are some projects that don't make any effort to have a working trunk or master branch. 2011-10-07T12:44:36 I know I'm on repeat, but we have many many times committed code that is pretty badly broken 2011-10-07T12:45:44 I think we've done way better recently. I just don't want to see a rush to close bugs / merge features deteriorate that. 2011-10-07T12:47:23 I don't want to sound like a downer; our project is really awesome on all kinds of fronts - very transparent, very open, lots of communication - that you often don't see in other projects 2011-10-07T12:53:42 gmcharlt: popped the updated release notes HTML into http://evergreen-ils.org/documentation/release/RELEASE_NOTES_2_1_0.html - thanks! 2011-10-07T12:54:08 should there be something about SVF in there? 2011-10-07T12:54:17 gmcharlt++ 2011-10-07T12:54:28 and dbs++ 2011-10-07T12:54:57 jamesrf: sure should. I had no idea of how to condense it down to something sensible though. 2011-10-07T12:55:35 * dbs can guarantee that there are lots of things that should be there, but they don't write themselves :) 2011-10-07T13:00:57 * thanks whoever updated the GUI w/ required patron dob field 2011-10-07T13:08:53 dbs: here's a few more things: http://pastebin.ca/2087703 2011-10-07T13:11:51 jamesrf: can you expand on them to provide more description, in line with what is already in the Release Notes? 2011-10-07T13:13:30 an extra sentence or two to point out how to configure the different toolbars, or hotkey settings, or what "weighting" circ and holds rules does would make a world of difference 2011-10-07T13:14:10 *** kmlussier has quit IRC 2011-10-07T13:15:34 hmm 2011-10-07T13:15:49 Probably want to mention fallthrough for the circ matrix too 2011-10-07T13:16:03 * tsbere can probably write about a lot of that, as he coded the features 2011-10-07T13:16:45 *** kmlussier has joined #evergreen 2011-10-07T13:20:50 tsbere: that would be awesome. we could link from a brief description to the excellent wiki docs that you provided, too 2011-10-07T13:21:17 http://pastebin.ca/2087711 2011-10-07T13:21:57 i don't really understand the hotkeys or SVF so i don't know what else to say about it 2011-10-07T13:22:19 jamesrf: Your example for the weighting seems like you are describing the *defaults* ;) 2011-10-07T13:22:30 * tsbere is working on a version of explanation for the stuff he wrote anyway 2011-10-07T13:22:56 *** atz__ has joined #evergreen 2011-10-07T13:23:45 jamesrf++ # getting the ball rolling 2011-10-07T13:24:01 *** Dyrcona has quit IRC 2011-10-07T13:24:15 *** Dyrcona has joined #evergreen 2011-10-07T13:24:33 er ok i don't fully understand some of these things anyway, just as dbs says trying to get the ball rolling 2011-10-07T13:25:20 *** atz has quit IRC 2011-10-07T13:25:43 sometimes vague and slightly inaccurate documentation is better than no documentation 2011-10-07T13:27:02 and sometimes vague and slightly inaccurate docs set the bar for more vague and slightly inaccurate docs :) 2011-10-07T13:29:26 let's call it the wikipedia principle :) 2011-10-07T13:30:00 [citation needed]! 2011-10-07T13:31:22 * tsbere can't remember everything he did get into 2.1, though 2011-10-07T13:32:50 dbs: I figure you're the best one to write about open-ils.resolver for the release notes 2011-10-07T13:33:04 gmcharlt: oh, good point. totally forgot about that 2011-10-07T13:33:51 *** Dyrcona has quit IRC 2011-10-07T13:34:00 *** Dyrcona has joined #evergreen 2011-10-07T13:34:37 *** Dyrcona has quit IRC 2011-10-07T13:38:27 dbs: http://pastebin.ca/2087715 is a quick shot. 2011-10-07T13:43:25 *** matt_carlson has joined #evergreen 2011-10-07T13:47:55 *** matt_carlson has quit IRC 2011-10-07T13:48:13 *** matt_carlson has joined #evergreen 2011-10-07T13:53:33 tell me a story about Printer Context... 2011-10-07T13:53:57 transit slips don't seem to fall under "Reciept" context 2011-10-07T13:53:59 tis a royal PITA that in a couple of cases makes no sense 2011-10-07T13:54:14 Transit and hold slips I think fall under "Default". Never did figure out why. 2011-10-07T13:54:19 thats what i was afraid of tsbere 2011-10-07T13:54:21 i think they do too 2011-10-07T13:54:27 I have thoughts on making it configurable, though. 2011-10-07T13:54:41 thought maybe it'd be a smimple tweak to add transit/hold to the reciept context 2011-10-07T13:54:43 Just involves touching every point in the entire system that deals with templates 2011-10-07T13:54:54 KCLS patches those to use receipt. I could see that being stock, or a slip role 2011-10-07T13:55:07 I have thoughts on making a slip role 2011-10-07T13:55:18 the main pain is that the printer settings editor is set-only 2011-10-07T13:55:20 phasefx: that's promising...do you know if those code changes are in a repo anywhere? 2011-10-07T13:55:21 So you can choose per template in the template editor what it uses 2011-10-07T13:55:34 yeah, that would be the best long term solution tsbere 2011-10-07T13:55:40 mrpeters-isl: it's a one-liner, you just add 'receipt' in new util.print in circ/util.js 2011-10-07T13:55:58 print = new util.print('receipt') 2011-10-07T13:58:29 aha 2011-10-07T13:59:10 if you could actually view configured print settings, that'd be heaven 2011-10-07T14:07:48 eeevil: Any thoughts on https://bugs.launchpad.net/evergreen/+bug/870032 ? 2011-10-07T14:14:27 * eeevil goes to look 2011-10-07T14:18:07 tsbere: just scanning the commitdiff ... do we need to use $U->isTrue() to test ou setting values? if($suppress_transit_circ ... and friends 2011-10-07T14:18:32 I don't think so 2011-10-07T14:18:52 suppress_transit_circ is set by perl code based on reading things to 0 or 1, I believe, for example. 2011-10-07T14:19:36 k ... json bool, I guess, in the db, turned into 0/1 in perl ... gotcha 2011-10-07T14:19:54 IE-- 2011-10-07T14:20:21 eeevil: Also, the DB settings for transit suppression are strings and compared as such elsewhere to decide if we are suppressing. 2011-10-07T14:21:04 tsbere: of course, you're right, nevermind me 2011-10-07T14:24:14 eeevil: I am more interested in your opinion on the handling of force and recall holds than the logic adjustment there ;) 2011-10-07T14:24:54 tsbere: on simple scan of the diff, I like it (only thing I'd whine about is some space v. tab stuff) 2011-10-07T14:25:46 * tsbere hates trying to figure out when he should use spaces and when he should use tabs as, for his own sanity when they are mixed, his editor shows tabs as four spaces 2011-10-07T14:26:11 fwiw, me too 2011-10-07T14:26:36 I also prefer using tabs to spaces, personally. 2011-10-07T14:26:38 me too. let's just expandtab the hell out of everything 2011-10-07T14:27:14 I also prefer using spaces to tabs, personally. 2011-10-07T14:27:18 Whee! 2011-10-07T14:27:19 * tsbere likes being able to say "this is a deep indentation....lets compress tab width down a bit for a few to make it easier to look at the more deeply indented code" 2011-10-07T14:27:39 * gmcharlt prefers spaces 2011-10-07T14:27:45 dbs: My statement was inteded as "I prefer using tabs" 2011-10-07T14:27:52 tsbere: I know 2011-10-07T14:27:57 shall we all thumb wrestle? ;) 2011-10-07T14:28:20 let's just convert each file to tabs or spaces as we prefer during each commit 2011-10-07T14:28:47 whoever commits last wins 2011-10-07T14:30:12 dbs: fwiw, I'm with you on spaces now ... used to be in the tab camp 2011-10-07T14:30:27 * dbs will happily accept unit tests formatted with tabs! 2011-10-07T14:31:05 * tsbere is considering rigging up some filters that do tab/space conversion for him in git 2011-10-07T14:31:34 * dbs tried to go with the established conventions of the project early on, diligently adding :noet modelines; when we subsequently agreed to go with spaces, I fear those have bitten us 2011-10-07T14:31:57 * dbs just doesn't want to go through another round of space/tab conversion 2011-10-07T14:32:55 * dbs will now create a large "change noet to et" branch 2011-10-07T14:34:37 *** matt_carlson has quit IRC 2011-10-07T14:35:07 *** matt_carlson has joined #evergreen 2011-10-07T14:39:10 * tsbere wonders what his git will say after his filters are applied 2011-10-07T14:39:10 senator++ # just tried out LP869581 for acq lineitem delete fix and works well for us. Thanks! 2011-10-07T14:41:44 Oh, right, I didn't use the filters before because they break your abilit to jump branches (due to messing with the whitespace of every file git touches) 2011-10-07T14:53:26 * dbs posts user/dbs/no-noet @ working for consideration 2011-10-07T14:58:02 If we are going for "use spaces everywhere" then should we just run a "go put spaces everywhere" pass? 2011-10-07T14:58:19 *** sal_ has quit IRC 2011-10-07T15:00:29 *** lisah___ has joined #evergreen 2011-10-07T15:01:02 *** bgoble has quit IRC 2011-10-07T15:01:03 tsbere: optionally. phasefx has done that in the past with much of the staff client code 2011-10-07T15:01:26 * dbs just wanted to start by fixing modelines that could cause inadvertent damage 2011-10-07T15:01:40 * tsbere has modeline reading turned off 2011-10-07T15:01:51 tsbere: for grace periods, would the slight rewording of: "They are also no longer based on a number of fine intervals, but are instead defined by their own explicit separate interval." work? 2011-10-07T15:01:58 not everybody is tsbere 2011-10-07T15:02:18 s/explicit separate// 2011-10-07T15:02:33 dbs: tweak the wording as you feel works best 2011-10-07T15:02:46 I'm just trying to ensure that I'm not making stuff up :) 2011-10-07T15:03:24 Basically I wanted to make sure people know you can, say, have a 15 minute grace period for an hourly fine. :P 2011-10-07T15:04:47 dbs++ 2011-10-07T15:05:01 and also tsbere++ 2011-10-07T15:05:02 obv 2011-10-07T15:05:08 *** lisah___ has quit IRC 2011-10-07T15:13:27 damn, conflict 2011-10-07T15:17:05 cleaned up - yay 2011-10-07T15:17:13 gmcharlt++ 2011-10-07T15:17:54 updated the release notes 2.1.0 html again (this time with Table o' Contents) 2011-10-07T15:23:51 dbs: since they bother my tiny mind, I'm going to get rid of the trailing colons in the headings on the release notes 2011-10-07T15:25:13 also, I may have a couple more more signficant updates to it tonight 2011-10-07T15:45:47 gmcharlt: go right ahead; I will acquiese to your "no trailing colon" preference :) 2011-10-07T15:46:09 :) 2011-10-07T16:10:20 *** akilsdonk has joined #evergreen 2011-10-07T16:22:53 Hmm, acq-related error message: http://paste.lisp.org/display/125166 - it speaks of "colliding purchase orders" 2011-10-07T16:23:10 Using the acq search, I found 3 PO's with the same name 2011-10-07T16:23:29 Some sort of database thing that prevents that? But the interface doesn't understand it 2011-10-07T16:25:42 bshum: acq.po_org_name_date_unique() is called before insert or update 2011-10-07T16:26:44 dbs: Aha, thanks. That's a good clue. 2011-10-07T16:26:50 looks like it's preventing two POs with the same name from being created on the same day 2011-10-07T16:28:53 dbs: That explains it then. The library that complained was trying to create 3 PO's with the same name, probably roughly same day/time. 2011-10-07T16:29:37 dbs: Workaround problem we created ourselves then due to the bug of not being able to create a PO with more than 20 line items. But that'll be "fixed" this weekend when we apply senator's patch to production. 2011-10-07T16:30:31 Thanks dbs! 2011-10-07T16:31:56 bshum: happy to help in some small way 2011-10-07T16:32:23 * dbs knows it will be paid back in full with interest when Conifer finally adopts acq 2011-10-07T16:32:35 dbs: It was entertaining trying to track it down. On the staff client side, the error message isn't very explanatory. 2011-10-07T16:32:51 The library just gets a very unfriendly "DATABASE_QUERY_FAILED-> The attempt to query to the DB failed." 2011-10-07T16:33:04 Which is the message you get for pretty much screwing up anything in Acq actually 2011-10-07T16:33:04 * dbs was playing a little bit of Burnout a few nights ago, the thought of collisions makes me smile 2011-10-07T16:33:29 yeah. our error handling often doesn't bubble database-level problems up very nicely 2011-10-07T16:33:44 dbs: We'll be happy to see you guys play with acq someday :) 2011-10-07T16:34:16 * dbs needs to get out of dodge 2011-10-07T16:34:22 have a good weekend, all 2011-10-07T16:34:23 Have a good weekend, dbs. 2011-10-07T16:34:53 *** collum has quit IRC 2011-10-07T16:39:19 *** dbs has quit IRC 2011-10-07T16:56:45 *** kmlussier has quit IRC 2011-10-07T17:10:05 *** akilsdonk has quit IRC 2011-10-07T17:10:33 *** _bott_ has quit IRC 2011-10-07T17:10:52 *** _bott_ has joined #evergreen 2011-10-07T18:34:26 *** matt_carlson has quit IRC 2011-10-07T19:14:02 *** yboston has quit IRC 2011-10-07T21:19:44 *** Callender_ has joined #evergreen 2011-10-07T21:22:13 *** Callender has quit IRC 2011-10-07T21:22:21 *** Callender_ is now known as Callender