2012-01-17T01:04:55 *** dzeiger1 has quit IRC 2012-01-17T01:41:39 *** kivilaht1o has quit IRC 2012-01-17T05:04:06 *** kivilaht2o has quit IRC 2012-01-17T05:04:34 *** kivilaht3o has quit IRC 2012-01-17T06:36:17 *** bshum has quit IRC 2012-01-17T06:36:27 *** bshum has joined #evergreen 2012-01-17T06:37:49 *** atheos_ has joined #evergreen 2012-01-17T06:38:25 *** eeevil has quit IRC 2012-01-17T06:38:32 *** eeevil has joined #evergreen 2012-01-17T06:40:34 *** atheos has quit IRC 2012-01-17T06:40:34 *** atheos_ is now known as atheos 2012-01-17T07:21:56 *** kmlussier has joined #evergreen 2012-01-17T07:52:29 *** collum has joined #evergreen 2012-01-17T07:56:02 *** bshum has quit IRC 2012-01-17T07:56:02 *** bshum has joined #evergreen 2012-01-17T08:07:28 *** akilsdonk has joined #evergreen 2012-01-17T08:08:47 *** adbowling-isl has joined #evergreen 2012-01-17T08:15:27 *** tspindler has joined #evergreen 2012-01-17T08:24:02 we're ironing out a couple of receipt printer setup things here, and I wanted to clarify something.... 2012-01-17T08:25:29 in 2.1, when you set a Default printer, does the client then assume that it needs to send all print jobs to the default printer, even if you set up a receipt printer? or is it just the "fallback" printer if you don't have a printer configured for a specific task 2012-01-17T08:25:33 ? 2012-01-17T08:25:50 just wanted to make sure we're using this (very cool) feature as intended 2012-01-17T08:30:56 csharp: It should be the fallback printer. Except for some things that print there outright, like hold and transit slips (I think) 2012-01-17T08:31:16 tsbere: great - thanks 2012-01-17T08:32:19 csharp: master has/2.2 will have a "force" selection for the templates themselves to say "use this printer context for this template" to solve the problem of "we print X on Y, not Z!" issues 2012-01-17T08:32:41 that sounds ideal 2012-01-17T08:32:55 MVLC libraries usually print hold/transit slips on the receipt printer, for example, but they go to the default printer normally... 2012-01-17T08:32:57 * csharp adds to list of things to convince people the next upgrade is worth it 2012-01-17T08:33:58 *** AaronZ-PLS has joined #evergreen 2012-01-17T08:34:03 csharp: If you are sneaky enough you could upgrade them without them knowing, thanks to the automatically updating staff clients. "Oh, just a little security fix....." ;) 2012-01-17T08:34:16 yeah! 2012-01-17T08:36:34 *** _bott_ has quit IRC 2012-01-17T08:37:33 *** _bott_ has joined #evergreen 2012-01-17T08:54:32 *** graced has joined #evergreen 2012-01-17T09:03:14 *** bwicksall has joined #evergreen 2012-01-17T09:10:57 *** dbs has joined #evergreen 2012-01-17T09:26:46 *** dzeiger has joined #evergreen 2012-01-17T09:28:29 *** dbs has quit IRC 2012-01-17T09:28:58 *** Meliss has joined #evergreen 2012-01-17T09:32:33 *** mrpeters-isl has joined #evergreen 2012-01-17T09:34:36 *** jenny has joined #evergreen 2012-01-17T09:44:02 *** alynn26 has joined #evergreen 2012-01-17T09:45:12 *** alynn26 has quit IRC 2012-01-17T09:48:32 *** dbs has joined #evergreen 2012-01-17T10:10:27 *** moodaepo has joined #evergreen 2012-01-17T10:11:02 Is there going to be a developer meeting today? 2012-01-17T10:11:23 * tsbere has no clue 2012-01-17T10:17:21 any objections to porting the patch for 870029 to rel_2_1? 2012-01-17T10:18:06 *** bwicksall has quit IRC 2012-01-17T10:18:13 I have no objections to that. eeevil might feel that it will "break functionality" that libraries are using in the wild. >_> 2012-01-17T10:18:47 * csharp is in the wild and wants the patch anyway :-P 2012-01-17T10:20:07 gmcharlt: I did write https://bugs.launchpad.net/evergreen/+bug/916501 saturday to deal with said "broken functionality" >_> Note that I didn't bother to tag it for 2.2, though. 2012-01-17T10:20:07 Launchpad bug 916501 in Evergreen "Staff cannot place unfillable holds" (affected: 1, heat: 6) [Low,New] 2012-01-17T10:26:03 well, those does raise a use case that csharp might be interested in 2012-01-17T10:28:01 they're not "unfillable" FOR ALL TIME and "staff" knows more than software about the "real world" ... (discard quotes, simply for effect) 2012-01-17T10:29:03 eeevil: As far as I can tell, every last one of our holds that qualify for the fixed INDB check are unintentional holds from staff using the wrong place hold button. Does not inspire confidence in your view for me ;) 2012-01-17T10:29:45 *** AaronZ-PLS has quit IRC 2012-01-17T10:29:46 tsbere: luckily, inspiring you is not my goal ;) 2012-01-17T10:30:16 *** bwicksall has joined #evergreen 2012-01-17T10:36:36 okay - I can see eeevil's point about wanting to create a "placeholder" hold for something not yet available... however, in practice, our libraries are seeing this as "patrons are placing holds on items that are not supposed to be available for holds" such as reference items 2012-01-17T10:37:07 csharp: this is to allow staff to place such holds, not patrons 2012-01-17T10:37:14 since there's not a point at which the patron is told about this problem, the patron walks away thinking that the hold request is successful 2012-01-17T10:37:17 oh 2012-01-17T10:37:23 yes, oh :) 2012-01-17T10:37:26 csharp: tech services departments in particular 2012-01-17T10:37:53 I was under the impression that statuses like "on order" existed for the purpose of placeholder holds, myself. And that having the requestor's permission group as a check in the hold matrix was to allow differentitation between staff and patron placed holds. 2012-01-17T10:38:05 * csharp tries to reprocess that 2012-01-17T10:38:21 *** sal_ has joined #evergreen 2012-01-17T10:38:56 tsbere: that covers the common cases, and is not my argument for staff being able to force a hold 2012-01-17T10:39:15 IOW, the "on order" status is a straw man 2012-01-17T10:39:22 are staff prompted to force the action for unfillable holds? 2012-01-17T10:39:47 or does it just assume they know what they're doing 2012-01-17T10:39:55 -= THIS MESSAGE NOT LOGGED =- 2012-01-17T10:39:57 t 2012-01-17T10:40:25 Before 870029 and 916501? No extra prompt (because the hold doesn't *fail*). After both you have to override. 2012-01-17T10:40:54 If you only have 870029 then you can't place them in general, staff or not 2012-01-17T10:40:59 and between, it's not possible (hold always fails) 2012-01-17T10:41:57 csharp: they've always been able to, without a prompt. currently in master, they can't at all. 916501 adds it back with an override prompt. 2012-01-17T10:42:53 (last part is an assumption on my part, haven't looked at the code yet) 2012-01-17T10:43:29 eeevil: It adds it in with a permission check. No permission, no override prompt. 2012-01-17T10:46:52 okay - well our biggest problem with this is an apparently tangential display issue that activates the estimated wait column in the patron view on the OPAC 2012-01-17T10:47:11 csharp: Totally hid that column 2012-01-17T10:47:16 csharp: Recently, on our OPAC 2012-01-17T10:47:22 I have yet to figure out what causes that. Due to not caring enough when I have time too. 2012-01-17T10:47:53 csharp: well, sounds like pursuing that approach will be faster 2012-01-17T10:48:01 It has something to do with people setting the active date of the holds. 2012-01-17T10:48:06 Or changing it. 2012-01-17T10:48:18 Suddenly the estimated wait column would start to appear. 2012-01-17T10:48:28 as it stands, 870029 by itself might be an issue for staff users -- you'd have to find out whether *your* staff users would be concerned 2012-01-17T10:49:39 yeah - we may still want the patch from 870029 just to avoid the chinese water torture of multiple tickets/questions about it as people find it ;-) 2012-01-17T10:50:02 bshum: if you can share your method with me I'd be indebted ;-) 2012-01-17T10:50:18 csharp: Happy to oblige. I think it's in myopac_holds.xml 2012-01-17T10:50:28 But I'm checking now 2012-01-17T10:51:32 csharp: Ah, nope, it's in the js file 2012-01-17T10:51:52 csharp: /openils/var/web/opac/skin/default/js/myopac.js 2012-01-17T10:52:33 In the estimated wait section, there's some unHideMe commands for the wait_column 2012-01-17T10:52:43 We just commented those out, so the columns never show up. 2012-01-17T10:52:50 Not efficient, but effective. 2012-01-17T10:53:26 I think we just put // in front of those two lines for myopac_holds_estimated_wait_column and myopac_holds_estimated_wait 2012-01-17T10:53:56 bshum: excellent - thank you very much 2012-01-17T10:56:13 csharp: Presumably it works the same way in 2.1... I always forget we're the dinosaurs now on 2.0 2012-01-17T10:56:16 *** dbs has quit IRC 2012-01-17T10:56:28 csharp: Good luck :) 2012-01-17T10:56:38 *** dbs has joined #evergreen 2012-01-17T10:56:41 thanks - looks like it hasn't changed 2012-01-17T11:11:00 csharp: I think I see what the problem may be now 2012-01-17T11:11:05 *** dbs has quit IRC 2012-01-17T11:14:36 * tsbere has figured out the base problem, but not all the details of how to fix it 2012-01-17T11:21:21 *** dbs has joined #evergreen 2012-01-17T11:30:39 * dbs wonders whether "if(qstats.estimated_wait || myopacShowHoldEstimate) {" should be an && condition - that's some weird logic 2012-01-17T11:34:03 *** jbondharris has joined #evergreen 2012-01-17T11:35:00 Good morning. Is there anyone online who could coach me through my OpenSRF/networking configurations? I don't need to do it 2012-01-17T11:36:23 here, unless everyone wants to watch. I am pretty sure that I have used "localhost" in places where I needed to put in a host name, such as "Library", or "Library.xxx.local" 2012-01-17T11:37:00 But I am floundering, so some guided coaching might speed things along. Thanks. 2012-01-17T11:38:02 dbs: No, that logic is fine. Just one catch in it. 2012-01-17T11:39:15 tsbere: oh yeah? it seems like qstats trumping myopacShowHoldEstimate runs counter to the normal way those "myopacFoo" vars are used (as configuration options) 2012-01-17T11:39:27 dbs: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/tsbere/fix_estimated_wait 2012-01-17T11:40:00 dbs: Near as I can tell, the on/off switch for estimated wait is "turn on the estimated wait OU settings", in which case the backend fills in data.... 2012-01-17T11:42:00 tsbere: ah, it makes more sense to be an OU setting. So there's not much reason for myopacShowHoldEstimate to even exist, then 2012-01-17T11:42:35 dbs: Yes, there is. It is used as a "have we shown the hold estimate at all yet? if so, keep showing the column even if we have no estimate" flag. 2012-01-17T11:43:06 Which is not perfect (say, your first two holds were suspended and have no estimates type deal....) 2012-01-17T11:44:37 dbs: Given where that variable is positioned in the js file I don't think it was ever intended to be edited as a setting. 2012-01-17T11:45:54 tsbere: I see what you mean. The naming convention for enabling / disabling functionality elsewhere threw me off entirely. "haveShownHoldEstimate" if I was to go back in time, I guess :) 2012-01-17T11:48:23 * tsbere opens 917748 with a pullrequest on that branch, after having it appear to work in his dev machine 2012-01-17T11:49:00 and.....yuck. A bug report with a docx as "screenshots" 2012-01-17T11:49:43 Well, at least it is screenshots with comments alongside them. Better than a docx for just pictures. 2012-01-17T12:05:48 tsbere: I thought about doing a lightning talk about "how to do screenshots" at last years EG conf for that very reason 2012-01-17T12:06:27 csharp: But none of the people that need that lesson attend these things. Or trainings in general, it seems. 2012-01-17T12:06:36 true dat 2012-01-17T12:07:50 csharp: 1. Install greenshot. 2. Press PrintScr. 3. Attach screenshot to email with explanation. ? 2012-01-17T12:08:00 dbs: yeah ;-) 2012-01-17T12:08:00 or 2012-01-17T12:08:15 1. Attach lifeloggers to all staff. 2. Monitor all actions of all staff. 2012-01-17T12:08:34 I know some library circ managers who want exactly that 2012-01-17T12:10:02 Then we just need to monitor all actions of all patrons, and PROFIT 2012-01-17T12:10:14 * dbs wonders if we'll have a dev meeting some day 2012-01-17T12:12:01 like, figuring out 2.1.2 and 2.2.0-alpha2 release plans 2012-01-17T12:16:14 when we have the next meeting, i think we should re-raise the meeting schedule. i'm convinced that having them at lunch time (eastern) is a contributing factor 2012-01-17T12:18:54 tip: "git diff" != "diff" 2012-01-17T12:19:59 for one thing, it silently returns when asked to diff a file against one not in revision control. :P 2012-01-17T12:21:45 Perhaps we should do a thread about the dev meeting schedule/time. I agree with berick about lunch time for EST being really horrible. 2012-01-17T12:22:31 I think we used to have them earlier in the day, but moved it back so that west coast people could attend easier. Maybe we need to find a quieter afternoon time? 2012-01-17T12:26:49 bshum: mid-afternoon seems reasonable to me. +1 to thread. 2012-01-17T12:28:50 berick: Maybe I'll write something about it in a moment. Still trying to sift out all the emails I got while I was on vacation :( 2012-01-17T12:33:10 I'm not sure the time is a core factor, to be honest. Nobody is putting forward agenda items for discussion or decision on the dev list. 2012-01-17T12:33:37 Over-meeting'd? 2012-01-17T12:34:09 The other reason for it being at noon Eastern was to try and ensure that the developer IISH was bringing on board would be able to attend (Amsterdam time), but we've heard almost nothing unfortunately. 2012-01-17T12:48:01 *** akilsdonk has quit IRC 2012-01-17T12:59:01 * tsbere is running on the assumption that the lack of meetings has been due in part to the sheer volume of people on vacation over the past couple of months, and the resulting overloading that did to coworkers not on vacation and similar catches 2012-01-17T13:04:25 OK, so let me try this. As before, I can login on my new server using srfsh. When I login from a Staff Client on another machine, the login part is successful but I get a "Not Found" message when th eserver tries to provide the ws_info.xul file. 2012-01-17T13:05:34 I have uploaded log files and configurations, as a tar file, to http://pastebin.com/v21jrQbS. Hopefully someone can take a look and provide some additional input. 2012-01-17T13:06:23 (My boss is not very happy that we can't get this working - he is trying to save us some $$ by using Evergreen and not going to a commercial vendor) 2012-01-17T13:07:37 jbondharris: That is amazingly unhelpful. :( 2012-01-17T13:07:38 BTW: error message on client: Not Found. The requested URL /xul/rel_2_1_1/server/main/ws_info.xul was not found on this server. 2012-01-17T13:08:39 jbondharris: The "not found" error implies that something is going wrong with the staff client portion of the make install step. Unless you are 100% positive that /xul/rel_2_1_1/server/main/ws_info.xul *does* exist, at which point I suspect your staff client is talking to a proxy of some kind. 2012-01-17T13:08:56 Alternatively, for some reason your apache isn't serving up xul files, period. 2012-01-17T13:09:25 WHAT is "amazingly unhelpful??" I have done the troubleshooting, without any reported errors. I know you hate to see me back again, but how can I get this to work????????? 2012-01-17T13:09:26 *** goood has joined #evergreen 2012-01-17T13:09:53 jbondharris: the pastebin "tar" file is very difficult to use as it is showing it in plain text form. Thus, unhelpful. 2012-01-17T13:10:38 tsbere: Yes, so no one has any input to help figure it out? Am I just SOL with this, then? 2012-01-17T13:12:36 jbondharris: I have *never* seen the issue you are reporting, nor have I been able to duplicate it, when ws_info.xul does in fact exist where the staff client is looking for it. The only way I could easily debug this quickly in that case would be if you gave *me* remote access (ssh and web) to your server. 2012-01-17T13:13:03 I am running on the assumption that for some reason the file itself does not exist, or if it does apache refuses to serve it for some reason. *why* it refuses to serve it I can't say. 2012-01-17T13:13:22 In other words, right now, the best I can do is guess. And I threw a guess or two out above. 2012-01-17T13:14:31 tsbere: I appologize to you and the group for my frustrated outburst. I figure the problem lies in the apache stuff, but can't seem to get a handle on it. I will re-install the staff client, and see if that will help. 2012-01-17T13:14:37 jbondharris: In fact, the most useful piece of your logs there is the fact that the server agrees that ws_info.xul cannot be found in the location in question. Not sure why it can't be found, mind you, just that it can't be found, as the access.log entries just say 404. 2012-01-17T13:15:51 tsbere: Yeah, I saw that too; and what makes it wierder to me is that the LOGIN is successful, it's just the ws_info file that somehow can't be found. 2012-01-17T13:16:18 jbondharris: For a list of reasons I have seen apache not find a file that is there (assuming it is in fact there): Bad permissions in the filesystem, wrong user running apache, bad vhost entries, bad rewrites, apache has been told to, apache is clueless how to return the file type and is in "pretend it isn't there" config for unknown types... 2012-01-17T13:18:50 This was al installed as per the instructions, on a fresh Ubuntu LTS 10.04 box (sigh), So it might point to either the client, or to me being too inexperienced with the Apache setup to know when I am screwing it up. 2012-01-17T13:19:49 I didn't change anything, but then the values I input may have been based on incorrect assumptions (and those can be hard to get at.) 2012-01-17T13:21:11 To my knowledge if you follow the default instructions everything works. Which either means you missed a step, or something else is installed that you aren't aware of screwing with things. My first thing to check, though, would be the permissions of ws_info.xul and all paths leading to it, and the apache run user. 2012-01-17T13:25:06 tsbere: I will check that to be sure. 2012-01-17T13:28:34 Going to lunch, then the client reinstall. I'll report back after that. Thanks again, tsbere. I do appreciate it. 2012-01-17T13:32:24 *** goood2 has joined #evergreen 2012-01-17T13:32:24 *** goood has quit IRC 2012-01-17T13:32:33 *** goood2 has quit IRC 2012-01-17T13:33:39 *** tecoripa has joined #evergreen 2012-01-17T13:34:04 I have a question about form validation in the patron registration screen 2012-01-17T13:34:50 I'm editing Open-ILS/web/js/ui/default/actor/user/register.js 2012-01-17T13:35:12 I notice that whenever I load the registartion screen, many of the required fields come up pre-validated: 2012-01-17T13:35:36 highlighted in yellow, with the triangle-exclamation mark sign 2012-01-17T13:35:47 these are the fields that are marked as "required" 2012-01-17T13:35:52 now my question: 2012-01-17T13:36:10 I have some patron statistical categories that are marked as required... 2012-01-17T13:36:34 and I'd like those ones to be pre-validated when the page loads, also 2012-01-17T13:37:06 but surveys and stat_cats are handled somewhat differently in the javascript 2012-01-17T13:37:22 *** goood has joined #evergreen 2012-01-17T13:37:26 and the only time they are validated is after you click on the text box 2012-01-17T13:38:14 id there a way to force pre-validation? I'm thinking of doing something like "dojo.connect(mywidget, "onLoad", widget.isValid()) 2012-01-17T13:38:28 but that feels wrong, and it's not being done elsewhere 2012-01-17T13:41:31 tecoripa: You should be setting the required flag on the entry boxes 2012-01-17T13:43:30 you mean on the entries within the combo box? 2012-01-17T13:45:16 there are no entry boxes. Just a patron stat_cat, and a select list of entries in a combo (freetext/select list) box 2012-01-17T13:45:50 The combo box itself should be able to be built with the required flag set 2012-01-17T13:46:00 Yes, and I am doing that 2012-01-17T13:46:20 and it's behaving as it should, except for the fact that it won't prevalidate 2012-01-17T13:46:33 until you click in it, or try to submit the form 2012-01-17T13:46:44 I don't think all of the input boxes do prevalidate to begin with. 2012-01-17T13:47:01 tecoripa: will calling myForm.isValid() do the job? 2012-01-17T13:48:06 tsbere: no, the survey questions don't prevalidate 2012-01-17T13:48:39 but it seems that all of the required input form elements do elsewhere 2012-01-17T13:48:48 tecoripa: What I am saying is that may be *by design*. As in "don't yell at me about something I haven't reached yet" 2012-01-17T13:49:00 phasefx: I could do that, but that's really ugly: validationg the whole form for just one element 2012-01-17T13:50:11 tsbere: that makes sense. But it does send mixed messages to the user then, some of these things I want you to fill in RIGHT NOw, and others you also have to fill in, but later, after I get around to seeing if they're valid. 2012-01-17T13:51:04 tecoripa: if it's a one-liner and gets the job done, doesn't seem too ugly to me :) 2012-01-17T13:51:44 phasefx: I'm mainly concerned about performance: many of the validations do callbacks to the server 2012-01-17T13:51:59 tecoripa: So only run the entire form validator *after* loading all the stat cats that need it? 2012-01-17T13:52:54 tsbere: I could do that, as you and phasefx are suggesting 2012-01-17T13:52:55 tecoripa: ah 2012-01-17T13:53:19 though it bothers me that my one little element would affect the entire state of the form. 2012-01-17T13:55:53 I guess I'm curious why, for instance, why "Primary Identification Type" comes up when the page loads as flagged, but my patcatstat doesn't 2012-01-17T13:55:57 *** goood has quit IRC 2012-01-17T13:57:27 the only clue I have is that the fields that load prevalidated and flagged are all hardcoded with the attribute "required='required'" in register_table.tt2 2012-01-17T13:58:01 *** goood has joined #evergreen 2012-01-17T13:58:02 which is not an option for me, because I won't know which patron stat_cats are required and which aren't until I load them and build them 2012-01-17T13:58:34 Well that attribute should be easily added *before* you create the fields themselves 2012-01-17T13:58:43 As in before the widget creation call (or part of it) 2012-01-17T13:58:56 I add it when I create the row 2012-01-17T13:59:10 before the digit comboBox widget is created 2012-01-17T14:00:26 but each row is created dynamically, one per patron stat_cat 2012-01-17T14:00:34 hmmm, but an idea occurs to me... 2012-01-17T14:01:13 the template row currently has "required='suggested'" 2012-01-17T14:01:26 You may want to see what my "dynamically increase the 'required' level" code does. 2012-01-17T14:01:31 Because I believe that works fine 2012-01-17T14:01:59 what elements, data is that used for? 2012-01-17T14:02:34 your code? 2012-01-17T14:04:47 My code is around line 866 I think, in master, and uses row.setAttribute and the required bool that is passed into dijitArgs. Both are needed for a couple of reasons (the row.setAttribute is actually only important for CSS reasons) 2012-01-17T14:05:15 ah, dijitArgs... I was going down that path... thanks 2012-01-17T14:05:21 I think that may be the clue I need 2012-01-17T14:05:34 On a different note, please put in code to ensure that the *header* for stat cats is set to show when in "required" mode 2012-01-17T14:05:45 right, got that already 2012-01-17T14:05:57 if(required) { 2012-01-17T14:05:57 row.setAttribute('required','required'); 2012-01-17T14:05:57 openils.Util.show('stat-cat-divider', 'table-row'); 2012-01-17T14:05:57 } 2012-01-17T14:06:19 *** jbondharris has quit IRC 2012-01-17T14:07:38 tsbere: 866 in master, the register.js file? 2012-01-17T14:08:31 tecoripa: For the stat-cat-divider, you should be adjusting it to show itself. I think it gets a "required='suggested'" by default, change that to "required='required'" via setAttribute. That way mode-switching works better. 2012-01-17T14:08:44 ok, will do 2012-01-17T14:12:29 tsbere: found your code, thanks. I had noted that required setting, but I hadn't traced it down to the point where it becomes part of dijitArgs. I'll work on that. 2012-01-17T14:14:07 *** goood has quit IRC 2012-01-17T14:20:21 *** goood has joined #evergreen 2012-01-17T14:24:35 *** goood has quit IRC 2012-01-17T14:29:25 *** tecoripa has left #evergreen 2012-01-17T14:32:24 * tsbere has no clue what died in memcache, but something did, as he had to restart it to get bibs to load and save properly again in the staff client.....but logins were working fine. 2012-01-17T14:33:25 tsbere: That doesn't sound good. 2012-01-17T14:33:57 Even better, I can't find any hint of things failing server-side. Even for the times I intentionally triggered the failures. 2012-01-17T14:36:17 So... I have a fun holds question, for whenever. Someone here tried retargeting a hold where the item was "in transit" to the location (but had been taking too long or whatever). And doing so, reset the hold as expected, but then put the item checked back in (reshelving). 2012-01-17T14:36:23 Instead of leaving it as "in transit" 2012-01-17T14:36:41 Is that expected behavior or have we done something really odd and unexpected there? 2012-01-17T14:39:19 My assumption is that somehow the act of retargeting the hold is causing the transit entry to go away as well. 2012-01-17T14:46:06 Actually we get an error message when trying to find new target for a hold where the item is already in transit - http://pastie.org/3203151 2012-01-17T14:46:23 When hitting retry, it moves on then, but maybe that's why things are breaking down on us. 2012-01-17T14:46:54 *** akilsdonk has joined #evergreen 2012-01-17T14:47:45 *** Meliss has quit IRC 2012-01-17T14:49:35 bshum: That happens because the hold transit is being removed, I suspect. 2012-01-17T14:49:39 bshum: resetting the copy and clearing the transit appears to be the expected behavior, as far as the code is concerned. 2012-01-17T14:50:40 bshum: It sounds like it wasn't expected to you and the rest of your library though 2012-01-17T14:50:44 I think the idea is "if you are finding another target you think the one that captured shouldn't be captured" and runs on the assumption of "oh, and you probably still have the item in hand, so clean up the transit that you didn't send it out for too" 2012-01-17T14:50:46 * berick does not recall why, though 2012-01-17T14:51:26 tsbere: probably something along those lines.. 2012-01-17T14:51:50 dbs: Right, I think what they expected was for the item to remain in transit, but the hold to be looking for a new item to target on. But if that's not what's there, then that's not what's there. 2012-01-17T14:52:45 Might just be an opinion though, for future wishlist. 2012-01-17T14:54:45 it's also problematic to have an item linked to a hold transit for a hold that the item is not captured for.. though, i suppose the code could replace the hold transit w/ a regular transit during hold reset, if maintaining the transit was necessary 2012-01-17T14:54:48 Perhaps it should ask if the transit should be aborted....although I thought it already did ask for most "there is a transit I think should go away" type actions. 2012-01-17T14:55:32 berick: I think the system is perfectly fine with the hold no longer being involved as it is....*goes to look in the code* 2012-01-17T15:00:11 Huh. looks like a hold_transit, unless canceled, will try and fill when it gets there, without any additional checks. 2012-01-17T15:00:28 berick: perhaps that checkin code needs a "and we didn't fill this hold already" check? 2012-01-17T15:00:44 Or at least "and this is still the right copy for the hold" check 2012-01-17T15:00:49 tsbere: with a "is this the right copy?" check 2012-01-17T15:00:50 yeah 2012-01-17T15:16:40 tsbere: Just so that I can read along, this is stuff in Holds.pm? 2012-01-17T15:17:13 bshum: Circulate.pm, actually (I was looking at the checkin code) 2012-01-17T15:17:38 * tsbere isn't making any attempts at changing it right now, though 2012-01-17T15:17:50 Not sure if berick jumped on it 2012-01-17T15:21:13 tsbere: Ah okay, I'm just peeking since I'm not a perl guy, but I like to try learning how this stuff works. 2012-01-17T15:21:19 * berick is not jumping 2012-01-17T15:21:38 So we all agree it needs to be fixed! We just aren't jumping in to fix it. ;) 2012-01-17T15:26:57 *** jcpl-jasonb has joined #evergreen 2012-01-17T15:28:42 *** Shae has joined #evergreen 2012-01-17T15:28:52 Attention all: the Reports Taskforce Meeting will begin in approximately 2 minutes 2012-01-17T15:29:58 *** joanne has joined #evergreen 2012-01-17T15:31:01 Ok - time to get started with the Evergreen Reports Taskforce January Meeting. 2012-01-17T15:31:08 The agenda is posted: http://open-ils.org/dokuwiki/doku.php?id=evergreen-reports:meetings:2011-12-14-agenda 2012-01-17T15:31:53 Try not to be confused by the December date...we'll be following that agenda, since the meeting was canceled due to low attendance. 2012-01-17T15:32:15 We'll start with introductions. 2012-01-17T15:32:29 And if I could get a volunteer for minutes, I would really appreciate it. 2012-01-17T15:32:37 * jenny is Jenny Turner, PALS 2012-01-17T15:32:47 is Shae Tetterton, Equinox 2012-01-17T15:32:49 * bshum is Ben Shum, Bibliomation 2012-01-17T15:32:52 * tspindler is Tim Spindler C/W MARS 2012-01-17T15:33:36 * jeff is Jeff Godin, TADL 2012-01-17T15:33:55 *** afterl has joined #evergreen 2012-01-17T15:34:19 Any volunteers to compile minutes? 2012-01-17T15:35:21 I would volunteer pinesol_green, but I haven' 2012-01-17T15:35:29 *haven't learned enough to control it. 2012-01-17T15:35:51 I've only heard rumors of it's awesomeness. 2012-01-17T15:36:33 Ok, well, as people join, they can introduce themselves. And, really, if any one gets the urge to compile minutes later, please let me know! 2012-01-17T15:36:46 #startmeeting 2012-01-17T15:36:46 Meeting started Tue Jan 17 15:36:46 2012 US/Eastern. The chair is bshum. Information about MeetBot at http://wiki.debian.org/MeetBot. 2012-01-17T15:36:46 Useful Commands: #action #agreed #help #info #idea #link #topic. 2012-01-17T15:37:15 #link Agenda: http://open-ils.org/dokuwiki/doku.php?id=evergreen-reports:meetings:2011-12-14-agenda 2012-01-17T15:37:37 Thanks for attending, everyone - and for re-arranging your schedules to accommodate a change in plans! 2012-01-17T15:39:33 #topic On to agenda item 2: reviewing past minutes 2012-01-17T15:39:54 #chair jenny 2012-01-17T15:39:54 Current chairs: bshum jenny 2012-01-17T15:40:02 #info past minutes can be found http://open-ils.org/dokuwiki/doku.php?id=evergreen-reports:meetings:2011-11-09 2012-01-17T15:40:32 Any comments on/corrections to the minutes? 2012-01-17T15:41:18 Looks fine to me. 2012-01-17T15:41:42 Cool - anyone else? 2012-01-17T15:41:43 Missed the last meeting so can't comment 2012-01-17T15:41:51 me too 2012-01-17T15:42:33 We can probably consider them good enough. 2012-01-17T15:42:53 *** chtrotter has joined #evergreen 2012-01-17T15:42:55 #info minutes passed 2012-01-17T15:43:27 hey y'all, sorry i'm late...busy day at the desk! 2012-01-17T15:43:31 #topic agenda item 3.I. Documentation 2012-01-17T15:43:32 *** pinesol_green changes topic to "agenda item 3.I. Documentation" 2012-01-17T15:43:48 chtrotter: thanks for joining us! 2012-01-17T15:44:02 we're just moving on to discussing documentation. 2012-01-17T15:44:29 #info the documentation for reports was moved over from 2.0 to 2.1 2012-01-17T15:45:12 jenny++ 2012-01-17T15:45:13 Has anyone seen any pieces that need to be corrected? Or pieces that are needed...and/or pieces they are working on? 2012-01-17T15:46:08 as always, just let me know if you notice any holes. 2012-01-17T15:46:19 I'll relay the info to DIG. 2012-01-17T15:46:30 i had walked through the documentation, and the process looks good but I think longterm more explanation of what specific data sources represent would be helpful 2012-01-17T15:46:43 tspindler: agreed. 2012-01-17T15:46:51 definitely. 2012-01-17T15:47:09 has anyone worked on this? I feel under qualified to write this, personally 2012-01-17T15:47:32 i think i could eventually but may not get to it for another 6 months 2012-01-17T15:47:49 #help Need people to review 2.1 documentation further 2012-01-17T15:48:05 jenny: I can review it further and look at how the data sources are described. 2012-01-17T15:48:16 thanks, shae! 2012-01-17T15:48:18 we just upgraded to 2.1 this weekend! 2012-01-17T15:48:31 How did it go chtotter? 2012-01-17T15:48:58 So far, so good. 2012-01-17T15:49:04 2.1, yay! 2012-01-17T15:49:28 #action Shae to review 2.1 documentation further and look at how the data sources are described. 2012-01-17T15:50:20 #action tspindler to look at data source descriptions at a later date (6 months, or so) 2012-01-17T15:51:21 tspindler: thanks for the offer of future help! 2012-01-17T15:51:33 and good news on 2.1 - hooray! 2012-01-17T15:51:41 Anything else on documentation? 2012-01-17T15:53:02 #info also remember that if you have documentation that doesn't quite fit the DIG documentation, you can post it on the DocuWiki page, as chtrotter has done! 2012-01-17T15:54:01 The docuwiki page is http://evergreen-ils.org/dokuwiki/doku.php 2012-01-17T15:54:48 Hearing only crickets, let's move on. 2012-01-17T15:55:06 #topic JasperReports - do we have an update? 2012-01-17T15:55:06 *** pinesol_green changes topic to "JasperReports - do we have an update?" 2012-01-17T15:56:22 * bshum pokes jeff 2012-01-17T15:57:14 sorry, was stuck in email and brief meeting. 2012-01-17T15:57:40 no worries, jeff 2012-01-17T15:57:44 TADL continues to use JasperReports, and we're training additional staff on creating reports. The self-service interface is starting to get some good use. 2012-01-17T15:58:17 Assuming I'm able to make it to the conference (still verifying a few things there), it sounds like I'll be presenting on JasperReports there. 2012-01-17T15:58:26 jeff++ 2012-01-17T15:58:31 TADL also plans to have a JasperReports demo instance up, but I don't have an ETA. 2012-01-17T15:59:03 I'll be reaching out to some folk running Evergreen demo servers with data, to see if we can report against their sample data, as well as having some sample data of our own. 2012-01-17T15:59:47 #info TADL is up and running on JasperReports. 2012-01-17T16:00:38 #action jeff to keep us posted on Evergreen Conference presentation, JasperReports demo instance, and further testing 2012-01-17T16:00:43 thanks, Jeff! 2012-01-17T16:00:50 If anyone has some favorite reports they'd like to see represented in the JasperServer demo instance, or if anyone has a challenging report they'd like to see tackled, please pass the ideas my way. 2012-01-17T16:00:58 you're welcome! 2012-01-17T16:01:34 Sounds great - I hope you can travel to the conference: it sounds like your presentation will be great! 2012-01-17T16:01:53 #action send ideas for demo reports to jeff 2012-01-17T16:02:41 This kind of leads us naturally to the next topic (EG conference), unless there are any other updates 2012-01-17T16:03:15 #topic Evergreen reports-related activities at the Evergreen Annual Conference 2012-01-17T16:03:15 *** pinesol_green changes topic to "Evergreen reports-related activities at the Evergreen Annual Conference" 2012-01-17T16:03:47 Does anyone know when the reports interest group is meeting at the conference? I assume it's some time on Hackfest opening day? 2012-01-17T16:03:55 #info unfortunately, we won't be able to have an SQL training event at the conference. 2012-01-17T16:04:16 *** collum has quit IRC 2012-01-17T16:04:19 *** akilsdonk has quit IRC 2012-01-17T16:04:29 I believe Shauna is sending out program acceptances today - I just got one so hopefully the program is coming soon. 2012-01-17T16:05:07 * dbs busts in to note that Jim Corridan of Evergreen Indiana had told the Oversight Board today to expect the program by the end of the week 2012-01-17T16:05:37 dbs: thanks 2012-01-17T16:05:38 bshum: from 1:00 to 4:30 on Wed, with a "snack break" from 2:30-2:45 2012-01-17T16:07:06 jeff: I think what I saw - and now cannot locate - implied that our group would meet either before or after the "snack break" 2012-01-17T16:07:58 got it. 2012-01-17T16:08:01 thanks. 2012-01-17T16:08:22 #info the reports interest group will meet sometime between 1:00 and 4:30 on Wed - we've traditionally had ~2 hours allotted 2012-01-17T16:08:45 does anyone have any "agenda items" for our in-person meeting? 2012-01-17T16:08:56 emails about programs just went out 2012-01-17T16:09:00 last year we had about 50 people attend 2012-01-17T16:09:01 for those that were accepted 2012-01-17T16:10:04 give some time for them to trickle out, of course, because i think shauna is emailing individuals 2012-01-17T16:11:09 mrpeters-isl: thanks! 2012-01-17T16:12:16 Ok, does anyone have any ideas for the interest group meeting at conference? Last year we had about 50 people attend - which was WAY more than I'd planned on. Attendees were from all backgrounds. Some investigating EG, some live...libraries of all sizes... 2012-01-17T16:13:15 jenny: I def think mentioning the work on JasperReports is a good topic and that could direct folks to the program being offered at the conference 2012-01-17T16:13:29 Shae: good idea! 2012-01-17T16:13:32 jenny: what were some of the agenda items last year that got people excited? 2012-01-17T16:15:08 jenny et al: you might want to get people to plot out interest items on the mailing list in advance and maybe enable people to divide up by areas of interest? 2012-01-17T16:15:11 jenny: could also highlight the general report templates that are available for download. I know they were fairly new last year so people might have more questions now. 2012-01-17T16:15:26 shae: I pretty much had to throw my whole plan out of the window last year...didn't have a projector and had about 40 more people than anticipated. So, we just did small group sharing about what we wished EG reports would do - either real or - in the case of libraries looking to move to EG - potential. I'd have to dig to find out what I had originally planned on. 2012-01-17T16:15:31 dbs: i was thinking the same thing 2012-01-17T16:15:40 dbs: good idea 2012-01-17T16:15:53 shae: also good idea 2012-01-17T16:16:02 idea stolen from http://fedoraproject.org/wiki/FUDCon:Blacksburg_2012#Hackfests_.26_Workshops 2012-01-17T16:16:18 jenny: do i remember correctly that there was a document that came out of last year's interest group? 2012-01-17T16:16:23 Does anyone want to volunteer to work with me on this? 2012-01-17T16:16:30 jeff: yes, our wishlist 2012-01-17T16:16:48 http://open-ils.org/dokuwiki/doku.php?id=evergreen-reports:taskforce_wish_lists 2012-01-17T16:17:15 jenny: when I find out more about my travel plans, if I'm there in time, I'm happy to work with you on the interest group and agenda.... 2012-01-17T16:17:27 jenny: got it! 2012-01-17T16:17:31 shae: that would be great! 2012-01-17T16:17:33 and I love wishlists - especially when it comes to reports :) 2012-01-17T16:18:30 I'm sorry I will be missing it this year. Jenny, are you going to bring enough cookies this time? 2012-01-17T16:18:35 #action jenny - and potentially Shae - to work on agenda for interest group meeting at Evergreen 2012-01-17T16:20:00 chtrotter: I think I will pass on bringing cookies this year - if I could take a train and bake them at home, I could afford it. But buying cookies in bulk is a challenge...plus, we get a "snack break" this year! 2012-01-17T16:20:05 :) 2012-01-17T16:20:49 #action everyone continue sending jenny ideas for the reports interest group meeting in Indianapolis! 2012-01-17T16:21:31 Ok, all, I have another meeting in 10 minutes, so time to move this along... 2012-01-17T16:21:49 #topic Any thing from past meetings that I missed in the agenda? 2012-01-17T16:21:49 *** pinesol_green changes topic to "Any thing from past meetings that I missed in the agenda?" 2012-01-17T16:21:53 jenny: maybe the hackfest & all the interest groups could sort things out in one wiki page or something. maybe too anarchic 2012-01-17T16:21:57 * dbs shuts up 2012-01-17T16:22:13 dbs: another good idea - thanks 2012-01-17T16:23:02 #info hearing nothing, moving on... 2012-01-17T16:23:19 #topic New Business 2012-01-17T16:23:19 *** pinesol_green changes topic to "New Business" 2012-01-17T16:23:28 Any new business, anyone? 2012-01-17T16:23:36 not from me 2012-01-17T16:24:02 I thought it was nice that tspindler started using the reports list to talk about templates, etc. 2012-01-17T16:24:03 none here 2012-01-17T16:24:10 none here. 2012-01-17T16:24:17 bshum: agreed! 2012-01-17T16:24:19 We should send more folks there to discuss further. 2012-01-17T16:24:35 I'm poking one of my coworkers who does most of our template construction to join us. 2012-01-17T16:24:45 bshum: thanks, i don't think i got much response unfortunately, forgot about it 2012-01-17T16:24:53 #action everyone nudge people towards the evergreen-reports list! 2012-01-17T16:25:16 *** adbowling-isl has quit IRC 2012-01-17T16:26:09 does February 8 work for our next meeting? Theoretically we can go back to our regularly scheduled time 2012-01-17T16:26:22 #topic Set next meeting date 2012-01-17T16:26:22 *** pinesol_green changes topic to "Set next meeting date" 2012-01-17T16:26:44 jenny: looks like it works for me 2012-01-17T16:26:44 the normal time is 2:30 ET 2012-01-17T16:26:59 msg/ tspindler: I've been so busy preparing for upgrade, i missed your message...will go look for it. 2012-01-17T16:27:02 jenny: 2:30 on the 8th works for me. 2012-01-17T16:27:03 I will probably not be able to attend, traveling that week. 2012-01-17T16:27:39 That time works for me. 2012-01-17T16:27:45 bshum: we'll miss you, but it sounds like 2:30 on Feb. 8 it is! 2012-01-17T16:27:48 But go ahead if it works for the majority of everyone. 2012-01-17T16:28:00 Don't forget to info that for the notes! 2012-01-17T16:28:03 :) 2012-01-17T16:28:24 #action jenny to convene next meeting at 2:30pm ET, Feb. 8 on IRC 2012-01-17T16:28:36 Ok, everyone - thanks for coming! 2012-01-17T16:28:54 *** tspindler has quit IRC 2012-01-17T16:28:56 #endmeeting 2012-01-17T16:28:56 Meeting ended Tue Jan 17 16:28:56 2012 US/Eastern. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 2012-01-17T16:28:56 Minutes: http://evergreen-ils.org/meetings/evergreen/2012/evergreen.2012-01-17-15.36.html 2012-01-17T16:28:56 Minutes (text): http://evergreen-ils.org/meetings/evergreen/2012/evergreen.2012-01-17-15.36.txt 2012-01-17T16:28:56 Log: http://evergreen-ils.org/meetings/evergreen/2012/evergreen.2012-01-17-15.36.log.html 2012-01-17T16:28:56 *** pinesol_green changes topic to "Welcome to the #evergreen library system channel! | We are publicly logged. | Large pastes at http://pastebin.ca or http://paste.lisp.org/new/evergreen or something like that" 2012-01-17T16:29:45 jenny++ # you'll be a meetbot master soon enough! 2012-01-17T16:29:58 jenny++ 2012-01-17T16:30:16 bye, y'all! 2012-01-17T16:30:31 *** chtrotter has quit IRC 2012-01-17T16:32:23 I'm having an issue with some book covers not showing up, but I suspect it has to do with the MARC record. In the 20a subfields there are multiple ISBN's but the first one is (hbk.) and the rest end in (eISBN). It seems it's not pulling the book cover from amazon because of the ISBN? Does it pull them in a different way? 2012-01-17T16:37:24 enhancin: we've gone through several rounds of ISBN cleaning, I think. can't remember offhand but default code might only check the first ISBN in the record 2012-01-17T16:37:26 *** joanne has left #evergreen 2012-01-17T16:38:03 hm, i'm looking at the AddedContent::Amazon.pm module, is there a specific file I can edit to make it go through the next fields if the first returns nothing? 2012-01-17T16:38:19 I wish I knew the whole map of the thing..heh...it's really inefficient for me to make customizations 2012-01-17T16:38:46 enhancin: the request comes at the JS layer in rdetail.js in this case 2012-01-17T16:39:19 that's in opac/skin/default/js right? 2012-01-17T16:39:28 jeff had worked on code to move the responsibility for parsing into AddedContent modules (enabling UPC / ISSN / etc) but not surfaced yet I think 2012-01-17T16:39:36 found it! 2012-01-17T16:39:36 enhancin: yep 2012-01-17T16:39:42 cleanISBN 2012-01-17T16:40:37 acCollectData(cleanISBN(record.isbn()), rdetailhandleAC); 2012-01-17T16:41:21 *** kmlussier has left #evergreen 2012-01-17T16:41:23 hah! we were JUST talking about that! :-) 2012-01-17T16:42:07 and cleanISBN is located in web/opac/common/js/opac_utils.js 2012-01-17T16:43:37 i can already feel my eyes glazing over at the amount of code i'm going to be reading tonight 2012-01-17T16:44:04 enhancin: can you point us at a record? 2012-01-17T16:44:54 *** jcpl-jasonb has quit IRC 2012-01-17T16:45:01 http://dl-572-118.slc.westdc.net/opac/en-US/skin/default/xml/rdetail.xml?r=12 this one, I think i'm going to look into the record.isbn() function and see if maybe that can be a workaround 2012-01-17T16:45:44 uh, yeah, I'm pretty sure you're getting just the first 020a back in that case. horrible data there!@ 2012-01-17T16:46:04 yeah, i know...i've been ripping my hair out. 2012-01-17T16:46:23 IIRC, record.isbn() is the slim MODS object - you would be better off using bibtemplate to iterate through the 020 $a subfields until you find something worthy :) 2012-01-17T16:46:27 i was hoping I could just have a simple regex check if there is a 10 or 13 digit number in there 2012-01-17T16:46:36 mmk 2012-01-17T16:47:09 but yes, the default pulls the first isbn. i believe what i have to dig out passes the first isbn and upc found, and had at least hooks for "nope, try again with the next identifier" 2012-01-17T16:47:17 * jeff makes himself a big todo list entry 2012-01-17T16:48:37 regex would make it easier, if it could find a valid ISBN before doing any searching that would be nice. I'm looking around for that to code 2012-01-17T16:49:44 enhancin: becomes easier if you normalize it further than cleanISBN does (e.g. also strip hyphens, delete any non-digits after the first string of digits) 2012-01-17T16:49:59 oh, except for [xX] :) 2012-01-17T16:50:40 right. i love regex, it's what got me interested in perl. I was solely C++,PHP kind of person before evergreen. 2012-01-17T16:51:04 enhancin: mebbe check out the source for http://laurentian.concat.ca/opac/en-CA/skin/lul/xml/rdetail.xml?r=939646&t=rainbow's%20end&tp=keyword&l=105&d=1&hc=5&rt=keyword - specifically the "getISBN()" function 2012-01-17T16:51:47 http://git.evergreen-ils.org/?p=contrib/Conifer.git;a=blob;f=Open-ILS/web/opac/skin/lul/xml/rdetail/rdetail_summary.xml;h=be7d383483f3ed6700c704351d52e913175f5f82;hb=refs/heads/feature/skins-bulk_2_1#l561 2012-01-17T16:51:53 *** afterl has left #evergreen 2012-01-17T16:52:43 Yeah, i think that's going to help, the first issue still occurs where the first field isn't even an ISBN 2012-01-17T16:54:15 enhancin: yeah :/ 2012-01-17T16:54:30 I will definitely but that in part of my solution though 2012-01-17T17:25:40 *** dbs has quit IRC 2012-01-17T17:54:44 *** jenny has quit IRC 2012-01-17T17:59:50 *** matt_carlson has joined #evergreen 2012-01-17T18:04:21 *** matt_carlson has quit IRC 2012-01-17T18:04:57 *** matt_carlson has joined #evergreen 2012-01-17T18:36:45 *** sal_ has quit IRC 2012-01-17T18:38:35 *** Callender has quit IRC 2012-01-17T18:52:28 *** Callender has joined #evergreen 2012-01-17T19:09:24 *** matt_carlson has quit IRC 2012-01-17T20:05:59 *** edoceo has joined #evergreen