15:00:04 #startmeeting 2024-08-13 - Developer Meeting 15:00:04 Meeting started Tue Aug 13 15:00:04 2024 US/Eastern. The chair is Bmagic. Information about MeetBot at http://wiki.debian.org/MeetBot. 15:00:04 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 15:00:04 The meeting name has been set to '2024_08_13___developer_meeting' 15:00:10 #info Agenda at https://wiki.evergreen-ils.org/doku.php?id=dev:meetings:2024-08-13 15:00:14 #topic Introductions 15:00:18 #info Bmagic = Blake GH, MOBIUS 15:00:28 #info scottangel = Scott Angel, MOBIUS 15:00:28 #info redavis - Ruth Frasur Davis, ECDI 15:00:30 #info Stompro = Josh Stompro, LARL 15:00:33 #info sandbergja = Jane Sandberg, PUL 15:00:34 #info sleary = Stephanie Leary, Equinox 15:00:36 #info shulabramble = Shula Link, GCHRL 15:00:37 #info mmorgan = Michele Morgan, NOBLE 15:00:39 #info collum = Garry Collum, KCPL 15:00:46 #info smayo = Steven Mayo, PINES 15:01:02 #info berick Bill Erickson, KCLS 15:01:16 #info eeevil = Mike Rylander, EOLI 15:01:35 feel free to introduce yourself as you arrive 15:01:38 #info abneiman = Andrea Buntz Neiman, Equinox 15:01:50 #info terranm = Terran McCanna, PINES 15:01:50 #topic Action Items from Last Meeting 15:02:02 mmorgan - should I skip? 15:02:06 #info jeff = Jeff Godin, Traverse Area District Library (TADL) 15:02:19 Bmagic: I opened the bug - bug 2076932 15:02:21 Launchpad bug 2076932 in Evergreen "Launchpad Statistics Tracking" [Undecided,New] https://launchpad.net/bugs/2076932 15:02:26 oh! 15:02:33 #info mmorgan will open a ticket for moving LP stats to community site & automating same 15:02:39 #info https://launchpad.net/bugs/2076932 15:02:51 mmorgan++ 15:02:51 mmorgan++ 15:02:57 mmorgan++ 15:02:59 mmorgan++ 15:03:06 Feel free to add code, ideas, etc. 15:03:21 #link https://launchpad.net/bugs/2076932 15:03:22 Launchpad bug 2076932 in Evergreen "Launchpad Statistics Tracking" [Undecided,New] 15:03:23 I meant link 15:03:54 #info dluch = Debbie Luchenbill, MOBIUS 15:04:02 Any discussion on that? 15:04:47 Hopefully the bug will gather some! I will add some of the scripts I tried with lp api. 15:04:51 mmorgan++ 15:04:52 #info jvwoolf = Jessica Woolford, Bibliomatin 15:05:03 mmorgan: great work 15:05:18 I do like knowning the big picture 15:05:40 ok, next up 15:05:43 #info eeevil will open a bug for cross-column stats targets 15:06:00 ha! nope... not this month :( 15:06:15 #action eeevil will open a bug for cross-column stats targets 15:06:21 no worries 15:06:28 #info gmcharlt - create a Git commit message type and update bug 2051946 15:06:29 Launchpad bug 2051946 in Evergreen "institute a Git commit message template" [Wishlist,New] https://launchpad.net/bugs/2051946 - Assigned to Galen Charlton (gmc) 15:06:39 Galen is away 15:06:42 I'll make a stub soon, but $someone will need to spend time digging through "slow" query logs... 15:06:56 eeevil++ 15:07:09 #action gmcharlt - create a Git commit message type and update bug 2051946 15:07:18 #info redavis will look at making a regular calendar event for translation work in lock step with point releases 15:07:39 gonna give that a pass this month. I've not forgotten though. 15:07:59 please carry over to next month 15:08:01 ok, perfect. Thanks for keeping it in mind 15:08:09 #action redavis will look at making a regular calendar event for translation work in lock step with point releases 15:08:16 #info Dyrcona will look into git integration with POEditor 15:09:41 Dyrcona is out of office currently 15:09:54 oh, lol, I was about to say something like "must be a lot of typing" 15:10:01 but I see he's MIA 15:10:15 #action Dyrcona will look into git integration with POEditor 15:10:21 #info sandbergja, abneiman, redavis, and mmorgan will put out said point release 15:10:37 hey we deffo did that 15:10:47 yeah, with Dyrcona's help! 15:10:47 Said point releases went out on July 19. 3.11.7, 3.12.5 and 3.12.2 15:10:53 deffo cool! 15:10:56 sandbergja++ abneiman++ redavis++ mmorgan++ 15:10:57 :) 15:11:01 with Dyrcona's immense help 15:11:12 sandbergja++ abneiman++ redavis++ mmorgan++ 15:11:16 Dyrcona++ 15:11:16 sandbergja++ abneiman++ redavis++ mmorgan++ Dyrcona++ 15:11:16 sandbergja++ abneiman++ redavis++ Dyrcona++ 15:11:25 Dyrcona++ 15:11:35 Dyrcona++ sandbergja++ abneiman++ mmorgan++ 15:11:40 #info abneiman will review existing EOLI PRs for test plans 15:11:57 Dyrcona++ sandbergja++ abneiman++ mmorgan++ 15:12:47 I reviewd them but did not add test plans to any. Will do so in advance of BSW. 15:13:08 abneiman++ 15:13:24 abneiman++ # that's awesome 15:13:34 abneiman++ 15:13:43 abneiman++ 15:13:46 abneiman++ 15:13:47 want that carried? 15:14:05 abneiman++ 15:14:08 nah 15:14:16 #info abneiman will add a discussion item for next meeting: test plans for big features 15:14:31 I ninja-edited that into the agenda 10 minutes ago :) 15:14:37 I see that, lol 15:14:48 * redavis was also ninja editing 15:14:48 sandbergja++ abneiman++ redavis++ mmorgan++ (belatedly, lol) 15:14:56 alright, that does it for last meeting stuffs 15:15:15 #topic Evergreen 15:15:17 ninja-editing++ 15:15:20 #info Roadmap: Evergreen Development Roadmap 15:15:25 #link https://wiki.evergreen-ils.org/doku.php?id=faqs:evergreen_roadmap 15:16:00 Um...the 3.14 release team has been meeting... 15:16:04 ninjas++ editing++ 15:16:15 i guess it's 3 o' clock .14 somewhere 15:16:36 redavis: Should we share the Launchpad tracking sheet? Or is it not ready for prime time yet? 15:16:36 who's working on the pi graphic for the release? 15:16:53 It's Dyrcona, Stompro, jvwoolf, and myself 15:17:14 jvwoolf, I think it's fine to share, but definitely a working document 15:17:33 feel free to hash link it 15:18:10 Stompro and Dyrcona worked through some postgresql 16 and ubuntu 24 things and that all is "ready to go." Next up is Bug Squash Week... 15:18:32 whoohoo! 15:18:41 new_postgres++ 15:18:50 The 3.14 roadmap wiki page is a living document as always but here is what's shaping up so far - https://wiki.evergreen-ils.org/doku.php?id=faqs:evergreen_roadmap:3.14 15:19:30 Here's our launchpad tracking sheet right now...https://docs.google.com/spreadsheets/d/1xodq5mLdU7Cjlw-gi8KYAyI6wmfGKRYUE7LYDdpscJY/edit?usp=sharing 15:20:07 I love the organization of it 15:20:21 friggin_spreadsheets++ 15:20:31 So, there are a lot of things that had a 3.next target that were just kind of hanging on each release. We're working on going through those, but others might want to take a look. We also have page as yet unpopulated for things we might pass on to Terran for BSW 15:20:37 whoa, total spreadsheet props 15:20:38 redavis++ #for keeping us on task 15:20:42 redavis++ 15:20:43 * redavis also loves a spreadsheet 15:20:56 thank you all for cleaning out the 3.next target 15:21:00 Nice! 15:21:15 redavis++ 15:21:15 All the LP foo from jvwoolf on that. 15:21:20 jvwoolf++ 15:21:22 jvwoolf++ 15:21:25 jvwoolf++ 15:21:47 jvwoolf++ 15:22:03 release_team++ 15:22:11 jvwoolf++ redavis++ 15:22:17 jvwoolf++ redavis++ Stompro++ Dyrcona++ 15:22:18 Dyrcona++ jvwoolf++ redavis++ Stompro++ 15:22:25 3.14 is going to be so cool! 15:22:30 stompro++ dyrcona++ 15:22:31 * sleary wishes a happy tenth birthday to several of those 3.next bugs 15:22:38 Dyrcona++ jvwoolf++ redavis++ Stompro++ 15:22:53 redavis++ jvwoolf++ Stompro++ Dyrcona++ 15:22:55 Oh...I guess we're talking about releases. There are going to be some point releases next week (please volunteer ye ol' buildmasters) 15:23:03 lol, ten years! Like a fine wine. But don't drink 'em 15:23:20 #info Maintenance releases 3.11.7, 3.12.5, 3.13.2 on July 19. 15:23:25 lolsob 15:23:40 #info Merge Pause on Friday, August 16. Should be able to lift pause on Tuesday, August 20. 15:23:53 #info 3.13.3 and 3.12.6 monthly maintenance releases on Wednesday, August 21. 15:24:14 redavis prompted me to info those 15:24:33 are they on the 19th or 21st? 15:24:34 Volunteers for building the releases will be heartily compensated (with many accolades of praise...until the next release(s)) 15:24:40 I'm availablel for building next week 15:25:00 oh whoops, I was reading the July thing, ignore me 15:25:06 Bmagic++ 15:25:21 I could help on the 21st too 15:25:23 * mmorgan can help 15:25:24 sandbergja, I wrote the stuff and still asked the exact same question to myself more than once. 15:25:53 I signed myself up for release notes, which I can do early next week 15:26:08 abneiman++ 15:26:09 Great. I'll send out an email to bmagic, sandbergja, abneiman (cuz I see your release notes name on the spreadsheet) to see if we can schedule a quick talk time. 15:26:19 redavis++ 15:26:22 good idea 15:26:25 I might be around, but at the very least I can help with web uploading/updating 15:26:30 redavis++ 15:26:33 sleary++ 15:26:34 sleary++ 15:26:42 redavis: I can help too. 15:26:48 mmorgan++ 15:26:58 lol, alright, including all y'all! 15:27:03 blamo 15:27:11 #info Bug squash week for 3.14 release, August 26-30. 15:27:17 terranm++ 15:27:50 terranm++ 15:28:02 terranm++ 15:28:04 terranm++ 15:28:12 terranm++ 15:28:12 Yep 10 year anniversary, let's make it good! 15:28:17 terranm++ 15:28:27 terranm++ 15:28:33 10 year anniversary and PIE!!!!! 15:28:33 I can't believe it, we've been doing BSW for 10 years, OMG 15:28:48 terranm++ 15:29:09 moving onto docs 15:29:11 #topic Documentation 15:29:15 #info DIG met on August 1 15:29:20 #info We are running our style guide through Vale to find errors in the docs. Images without alt tags was first–all fixed now! Next up is consistent word use for certain terms 15:29:35 #info Plans to work on docs bugs and especially reviewing older bugs during Bug Squashing Week 15:29:42 #info Next meeting, September 5 15:29:50 dluch you have the floor 15:31:23 Sorry, I was distracted, lol 15:31:43 I don't have anything else to add. Any questions? Any other DIGgers want to add/comment? 15:32:13 cool about Vale 15:32:39 dluch++ 15:32:51 dluch++ bmagic++ 15:32:52 shoutout to sandbergja for Vale! 15:33:01 sandbergja++ 15:33:01 dluch++ DIG++ 15:33:02 sandbergja++ 15:33:08 sandbergja++ 15:33:08 sandbergja++ 15:33:09 DIG++ 15:33:16 DIG++ 15:33:37 sandbergja++ 15:33:44 #topic Launchpad Status (as of noon Eastern) 15:33:54 hit the deck, we got incoming! 15:33:57 #info Open Bugs - 3119 15:33:57 #info Pullrequests - 96 15:33:57 #info Signedoff - 15 15:34:04 #topic Launchpad Status since last meeting 15:34:08 #info Bugs Added - 69 15:34:08 #info Pullrequest tag Added - 29 15:34:08 #info Signedoff tag Added - 18 15:34:08 #info Needswork tag Added - 2 15:34:09 #info Needstestplan tag Added - 0 15:34:10 #info Needsrebase tag Added - 5 15:34:12 #info Fix Committed - 22 15:34:19 #topic New Business - (Jane) How can we encourage more automated testing?, What are current barriers to writing and running the automated tests? 15:34:33 ok, my turn to paste some stuff: 15:34:35 #link https://wiki.evergreen-ils.org/doku.php?id=dev:contributing:qa 15:34:41 During the 3.12 and 3.13 release process, we found a number of big issues that we were able to resolve before cutting the release, for example: 15:34:49 an unpredictable intermittent failure in search, a bug that prevented users from adding new action trigger event defs, a case where I had committed the wrong patch from a launchpad ticket, one where the holdings view wouldn't load, and a major accessibility regression that detached form inputs from their labels across the client. 15:35:02 And the way we found those was by one of our automated tests failing, alerting us to the issue, which is great!  Very nice that we discovered those before they were in production. 15:35:09 However, it makes me think how many more regressions we could be catching if we'd been writing and running tests more often over the past 9 years. 15:35:15 So... I'd like to know: how can we get there?  What barriers can we iron out around automated testing? 15:36:12 sandbergja++ 15:36:36 sandbergja++ 15:37:12 those node nightwatch tests are clever. Automating the process of clicking on the interface like a human would. Not sure what the barriers are? Hard to write? 15:38:22 IIRC there are two (maybe three?) different QA/guideline documents for contributions that have different instructions, and we need to consolidate them into one coherent process. 15:38:40 consolidate! +1. Got links? 15:38:48 For me personally it is just the time it takes to create the tests, but I know if I do it more often it wouldn't take me as long. 15:39:15 working on links 15:40:01 Stompro++ sleary++ Bmagic++ 15:41:05 giving sleary a minute 15:41:19 https://wiki.evergreen-ils.org/doku.php?id=dev:angular_dev_best_practices 15:42:44 I know there is one out ther esomewhere for PG and one for perl 15:42:55 https://wiki.evergreen-ils.org/doku.php?id=dev:contributing:qa 15:43:08 there it is 15:43:16 that's the one I was thinking of 15:43:18 sleary++ 15:43:24 consolidating and refining those seems like a great place to start 15:43:27 https://wiki.evergreen-ils.org/doku.php?id=dev:meetings:common_qa_problems might also be relevant 15:44:07 +1 to a single page just about writing tests 15:44:12 do we need to make assignments around this? 15:44:14 sandbergja I will be happy to help with that... about a month from now, lolsob 15:44:27 sleary++ 15:44:40 sleary++ sandbergja++ 15:44:41 +1 to a page about writing tests 15:44:56 a month sounds great!  And I'm also happy to help as needed! 15:45:03 +1 to a page about writing, and also running them 15:45:09 do we need to do anything to remove barriers to running the tests? i.e., is setting up an environment where you can run the tests challenging or not-well-documented? 15:45:09 sandbergja++ sleary++ 15:45:14 I know that sandbergja has given a couple of talks in New Devs about test-driven development, and we can pull things from those meeting archives 15:45:26 jeff, good question 15:45:30 #action sleary and sandbergja will create/consolidate the test writing wiki page(s) 15:45:57 It always makes sense when I watch Jane do it, but then confusion returns 15:46:02 jeff: the docker container image now days is including the pre-reqs which is nice 15:46:14 jeff I think there is one quirk around Firefox, but it's mentioned in the eg2 CHEAT SHEET doc 15:46:52 Imma preserve those wiki urls 15:46:54 for me, reloading a test database from scratch can take a while, and a clean db is necessary for some of the tests 15:46:55 #link https://wiki.evergreen-ils.org/doku.php?id=dev:meetings:common_qa_problems 15:47:03 #link https://wiki.evergreen-ils.org/doku.php?id=dev:contributing:qa 15:47:49 I added a feature to the the dev container, which I find myself using a bunch, that automates the creation of new databases by editing a text file 15:47:51 the e2e tests take a while to run, and the syntax for running them on a single file or directory is not easy to remember 15:48:18 true sleary 15:48:35 we can probably script our way out of that problem :) 15:48:42 Bmagic I know you've told me this before, but I gotta start using the dev containers! 15:49:05 sandbergja: the water is fine, lol 15:49:57 the takeaway was consolidating the wiki pages 15:50:13 shall we add something else? 15:50:54 maybe step 2 can be writing some simple example tests or pinpointing old ones as good examples for basic tasks 15:50:54 maybe as part of that process we can look into the syntax for nightwatch on a single file or directory -- whether it is a docs fix or a script fix? 15:51:11 sandbergja++ 15:52:05 making sure I'm understanding: making the test run differently depending on what was committed? 15:52:31 running the tests on only the files you changed rather than the whole Angular project 15:52:48 gotcha, and what's missing for that to work? 15:52:54 memorable syntax 15:52:59 documentation is missing basically? 15:53:15 it's documented in the Nightwatch docs, but it's hard to remember 15:53:20 not sure it's in our cheat shee 15:53:22 sheet 15:53:36 I would appreciate a how-to, for sure. fwiw 15:53:47 so better syntax and better docs perhaps 15:54:18 maybe a wrapper that takes some evergreen-community arguments. like ./wrapper --one-test path/to/file 15:54:40 that's what I was thinking, but docs would be simpler :) 15:54:54 docs would be simplier :) 15:55:25 docs++ ;-) 15:55:29 I suppose that can be part of the same action? Or woudl you like a new action? Anyone want to put their name on it? 15:56:03 that should probably be a separate action from the wiki page consolidation 15:56:42 would you like to have it? 15:56:48 you could put my name on it 15:56:57 #action sandbergja will make it easier for folks to know how to run the tests in single file mode and all-mode 15:57:09 sandbergja++ 15:57:10 sandbergja++ 15:57:14 thanks everyone! 15:57:20 thanks for bringing up this topic! 15:57:22 sandbergja++ 15:57:28 we're coming up on the hour 15:57:33 #topic New Business - Hatch extension 'may soon no longer be supported' Hatch Chrome Extension 15:57:42 #link https://chromewebstore.google.com/detail/hatch-native-messenger/ppooibdipmklfichpmkcgplfgdplgahl 15:57:57 sandbergja++ 15:57:58 sandbergja++ 15:58:09 count me in for helping with Hatch work. hopefully i can pitch in starting next week 15:58:25 * berick runs off to another meeting 15:58:27 happy to help / help test. 15:58:30 berick++ 15:58:32 jeff++ 15:58:47 berick++ jeff++ 15:58:48 csharp opened bug 2004058 15:58:54 also, noting for the benefit of any who have the ability to make use of policies across their chrome fleet: 15:58:58 > Enterprises using the ExtensionManifestV2Availability policy to ensure the continued functioning of Manifest V2 extensions in their organization will have one additional year - until June 2025 - to migrate the Manifest V2 extensions in their organization. Browsers with the policy enabled won't be impacted by the rollout of the deprecation until that time. 15:59:07 ( from https://developer.chrome.com/docs/extensions/develop/migrate/mv2-deprecation-timeline ) 15:59:16 I'll also add that to the bug as a comment. 15:59:34 berick++ jeff++ 15:59:43 #action berick and jeff will look at making Hatch look better in the chrome store, so that it's not removed 15:59:57 #topic New Business - DokuWiki needs updating 16:00:30 that was me! Just a note for those of us who have website/db access; we should update 16:00:41 berick++ jeff++ 16:00:46 I see, you mean upgrade dokuwiki version 16:00:49 yes 16:01:00 cool, who usually does that? 16:01:16 do we have a dev environment to make sure the upgrade works before doing it for real? 16:01:38 I think has fallen on Rogan and/or Galen the last few times 16:01:42 csharp_ most likely. I think I can, but I'm reluctant to touch things without taking time to make my own backups 16:02:29 I can help too :) 16:02:54 #action Bmagic will work on upgrading the version of DokuWiki 16:03:06 #topic (ABN) Test plans for big features? 16:03:24 We're almost done... sorry we're going over 16:03:32 yes, so, briefly 16:03:50 what does the community want to / need to see out of test plans for new features? 16:04:10 things that are beyond the scope of "X is broken, install patch Y, follow steps 1 2 3, profit" 16:04:41 are you finding that certain things need more than our bsw and bff ? 16:04:52 asking because several EOLI feature PRs are either forthcoming soon, or carryovers from 3.13, and I want to make sure I'm doing what is needed to facilitate review & commit of those things 16:05:11 I always appreciate notes on how to configure the system if certain lib settings need to be enabled, etc. 16:05:34 varies, but maybe starting with: "here is a summary of / pointer to description of what this code should add/change/fix; here is a recommended way to test / how we tested; here are special considerations / gotchas"? 16:05:45 Stompro++ jeff++ 16:05:48 What Stompro said. Also if certain data is needed. 16:05:48 both helpful thanks 16:05:56 mmorgan++ 16:06:19 Stompro++ jeff++ mmorgan++ 16:06:34 and Bmagic, regarding BSW, I acknowlege that it's hard to test big features when there's a lot of other fixes flying around ... which is fine, IMO, that's what BSW is about. 16:06:52 Stompro++ jeff++ mmorgan++ 16:07:19 abneiman++ # I think I took your query the wrong direction after reading Stompro, jeff and mmorgan's ideas 16:07:21 like I said, I want to make sure we're doing what we can to faciliate merges of features. And to maybe offer similar guidelines to other feature developers 16:07:36 abneiman++ 16:07:43 abneiman++ 16:07:56 abneiman++ 16:08:05 thanks all, just a couple things and we're outta here 16:08:09 #topic Announcements 16:08:10 anyway, I appreciate the thoughts shared ... any others can come to me here, or directly at abneiman@equinoxoli.org and I'll put them.... somewhere public 16:08:14 abneiman++ 16:08:16 abneiman++ 16:08:18 #info Next Meeting is Tuesday, September 10th 2024 16:08:27 #info Hack-A-Way, November 12-14 in Boston, MA 16:08:34 #endmeeting