2011-08-12 Mike Rylander * Open-ILS/src/perlmods/lib/OpenILS/Application.pm, Open-ILS/src/sql/Pg/002.schema.config.sql, README: Bumping version numbers Signed-off-by: Mike Rylander 2011-08-12 Mike Rylander * Open-ILS/src/sql/Pg/2.0-2.1-upgrade-db.sql: Upgrade script (based on 2.0.8, currently) Signed-off-by: Mike Rylander 2011-08-12 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0599.data.fix_author_other_index.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.fix_author_other_index.sql: Stamped upgrade script for "lp 823496: do not fail to index personal names that have relators" Signed-off-by: Mike Rylander 2011-08-09 Galen Charlton * Open-ILS/src/sql/Pg/950.data.seed-values.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.fix_author_other_index.sql: lp 823496: don't fail to index personal names that have relators The default definition for the author|other index inadvertantly excluded names from 600, 700, 720, and 800 fields that have relator values ($e) or codes ($4). Signed-off-by: Galen Charlton Signed-off-by: Mike Rylander 2011-08-12 Thomas Berezansky * Open-ILS/xul/staff_client/chrome/content/util/print.js: Don't escape_html numbers in util/print.js Signed-off-by: Thomas Berezansky Signed-off-by: Jason Etheridge 2011-08-10 Thomas Berezansky * Open-ILS/xul/staff_client/chrome/content/util/print.js: Escape HTML characters in template subs This prevents injection of random HTML from various sources. Like bad bib records, org unit settings, patron info, etc. Signed-off-by: Thomas Berezansky Signed-off-by: Jason Etheridge 2011-08-10 Thomas Berezansky * Open-ILS/xul/staff_client/chrome/content/util/print.js: Use openDialog to make go_print workaround vanish By passing params and the go_print function into openDialog we get to ignore race conditions, as the window is created with the passed in arguments. Oh, and we can stop using js2JSON and such. Signed-off-by: Thomas Berezansky Signed-off-by: Jason Etheridge 2011-08-10 Thomas Berezansky * Open-ILS/xul/staff_client/chrome/content/util/window.js: Add openDialog to window class Uses window.openDialog instead of window.open. https://developer.mozilla.org/en/DOM/window.openDialog Signed-off-by: Thomas Berezansky Signed-off-by: Jason Etheridge 2011-08-12 Jason Etheridge * Open-ILS/xul/staff_client/server/skin/cat.css: No more lightpink for disabled copy editor Folks can still provide custom CSS against those class hooks if desired Signed-off-by: Jason Etheridge 2011-08-11 Jason Etheridge * Open-ILS/web/opac/locale/en-US/lang.dtd, Open-ILS/xul/staff_client/server/cat/copy_editor.js, Open-ILS/xul/staff_client/server/cat/volume_copy_creator.js, Open-ILS/xul/staff_client/server/cat/volume_copy_creator.xul, Open-ILS/xul/staff_client/server/skin/cat.css, Open-ILS/xul/staff_client/server/skin/global.css: in lieu of Ready Item Editor We're trying to prevent folks from using the item attribute editor in the unified interface when the volume pane is still updating its information (i.e. building the copies to feed to the attribute editor), so that a given editing widget isn't ripped out from under staff while its being used. This change removes the heavy-handed Ready Item Editor button and instead tries to more gracefully manage the editor state based on change and keypress events. Also change the color scheme for a disabled editor from red to light pink. Signed-off-by: Jason Etheridge Signed-off-by: Mike Rylander 2011-08-08 Jason Etheridge * Open-ILS/xul/staff_client/server/patron/display.js: Fix stop sign page race condition with checkout This would happen most often when retrieving multiple patrons at the same time from patron search--the stop sign page would show but then get trampled by the checkout interface, which normally loads first. Signed-off-by: Jason Etheridge Signed-off-by: Thomas Berezansky 2011-08-08 Mike Rylander * : commit e0b53ca41132ce228117706128de0b638e5ce8a9 Author: Lebbeous Fogle-Weekley Date: Fri Aug 5 16:01:09 2011 -0400 2011-08-05 Lebbeous Fogle-Weekley * Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Biblio.pm: In a middle-layer method for returning holdable formats on a metarecord, Do a better test of copy holdability than we were doing previously. We can't do a perfect test: we don't really know what patron we're doing this for, and even if we did, from here it's nontrivial to figure out whether we're doing indb holds or script-based, much less run the tests. Still, we can test whether a copy's in a holdable status, a holdable location, and is itself not explicitly marked unholdable. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Mike Rylander 2011-08-04 Jason Etheridge * Open-ILS/xul/staff_client/server/patron/items.js: mrpeters caught this; wrong variable fed to error dialog Signed-off-by: Jason Etheridge 2011-08-04 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/Application/Cat/AssetCommon.pm, Open-ILS/src/perlmods/lib/OpenILS/Application/Vandelay.pm: Repaired copy private/public note vandelay bug Previously, all copy notes imported through vandelay were coming in as public copy notes. Signed-off-by: Bill Erickson Signed-off-by: Lebbeous Fogle-Weekley 2011-08-04 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0592.data.ACQ_INVOICE_REOPEN-perm.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.lp818311.sql: Stamped upgrade script for ACQ_INVOICE_REOPEN permission addition Signed-off-by: Mike Rylander 2011-08-04 Jason Stephenson * Open-ILS/src/sql/Pg/upgrade/XXXX.lp818311.sql: Upgrade script for LP818311 branch. Signed-off-by: Jason Stephenson Signed-off-by: Mike Rylander 2011-08-04 Michael Peters * Open-ILS/src/sql/Pg/950.data.seed-values.sql: LP#818311: ACQ_INVOICE_REOPEN is missing This patch adds the missing ACQ_INVOICE_REOPEN to the Acquisitions Administrator user. Signed-off-by: Michael Peters Signed-off-by: Jason Stephenson 2011-08-03 Jason Etheridge * Open-ILS/xul/staff_client/server/patron/holds.js: Fix staff client Clear Expired Hold Shelf action Accomodate an API change. FIXME: See if can remove some of the redundant and/or un-needed data being sent over the wire. Signed-off-by: Jason Etheridge Signed-off-by: Mike Rylander 2011-07-28 Thomas Berezansky * Open-ILS/xul/staff_client/server/cat/marcedit.js: Only update MARC on full entry of fixed fields AKA: Lang is 3 characters long. Entering 1 character would cause focus to leave. MARC would also update incorrectly. This only triggers the update when the full 3 characters are entered. This not only prevents issues with catalogers editing multi-character fixed fields but also makes it less likely they accidentally corrupt the records. Signed-off-by: Thomas Berezansky Signed-off-by: Mike Rylander 2011-08-04 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0591.schema.circ_holds_history_repairs. sql, Open-ILS/src/sql/Pg/upgrade/XXXX.schema.circ_holds_history_repairs. sql: Stamped upgrade script for schema.circ_holds_history_repairs Signed-off-by: Mike Rylander 2011-08-04 Bill Erickson * Open-ILS/src/sql/Pg/090.schema.action.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.schema.circ_holds_history_repairs. sql: Repair holds history func; sort circ history desc. Update holds history to use oils_json_to_text instead of oils_json_to_string, which does not exist. Sort circ history newest to oldest by default. Signed-off-by: Bill Erickson Signed-off-by: Mike Rylander 2011-08-03 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0590.schema.more_cache_visibility_break age.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.more_cache_visibility_breakage.sql: Stamped upgrade script for more_cache_visbility_breakage Signed-off-by: Mike Rylander 2011-07-25 Thomas Berezansky * Open-ILS/src/sql/Pg/upgrade/XXXX.more_cache_visibility_breakage.sql: Unwrapped upgrade script for more_cache_visbility_breakage Signed-off-by: Thomas Berezansky Signed-off-by: Mike Rylander 2011-07-25 Thomas Berezansky * Open-ILS/src/sql/Pg/999.functions.global.sql: Extraneous semicolons break SQL Remove them so that cache_copy_visibility can function. Signed-off-by: Thomas Berezansky Signed-off-by: Mike Rylander 2011-08-01 Jason Etheridge * Open-ILS/xul/staff_client/server/cat/copy_editor.js: Fix overzealous template application The idea was that we'd track templates if they were applied prior to copies actually being specified in the unified interface, and then apply them "for real" once copies were entered. But these remembered templates kept applying themselves whenever changes were made in the volume/copy creator portion of the interface (possibly overriding tweaks made by staff). So now we delete the list of tracked templates once they're applied to actual copies. Signed-off-by: Jason Etheridge Signed-off-by: Mike Rylander 2011-08-01 Jason Etheridge * Open-ILS/web/opac/locale/en-US/lang.dtd, Open-ILS/xul/staff_client/chrome/content/util/widgets.js, Open-ILS/xul/staff_client/server/cat/copy_editor.js, Open-ILS/xul/staff_client/server/cat/volume_copy_creator.js, Open-ILS/xul/staff_client/server/cat/volume_copy_creator.xul, Open-ILS/xul/staff_client/server/skin/global.css: robustify (and klunkify) unified volume copy creator Disable/style the Item Editor while changes in the volume/item pane are being considered, and require an explicit press of a Ready Item Editor button to enable the interface. This reduces the chance of editing widgets in the item editor from being ripped out from under you (for example, if you try to go straight from editing a call number to editing an item attribute). Signed-off-by: Jason Etheridge Signed-off-by: Mike Rylander 2011-07-21 Jason Etheridge * Open-ILS/xul/staff_client/server/cat/util.js, Open-ILS/xul/staff_client/server/locale/en-US/cat.properties: lp#792595: Don't allow pre-cats into record buckets via Item Status -> Actions for Catalogers Alerts with the number of pre-cat records skipped prior to invoking the title bucket dialog. Signed-off-by: Jason Etheridge 2011-07-28 James Fournie * Open-ILS/web/conify/global/actor/org_unit.html, Open-ILS/web/conify/global/actor/org_unit.js, Open-ILS/web/opac/locale/en-US/conify.dtd: This adds a SAN box to the org unit editor's address editor pane. Signed-off-by: James Fournie Signed-off-by: Mike Rylander 2011-07-29 Dan Wells * Open-ILS/src/perlmods/lib/OpenILS/Application/Vandelay.pm, Open-ILS/web/js/ui/default/vandelay/vandelay.js, Open-ILS/web/templates/default/vandelay/inc/queue.tt2, Open-ILS/web/templates/default/vandelay/inc/upload.tt2: Vandelay fix for merging without loading new This fix is derivative of da3a453442050482a419deff91d3dc92fdbf132a in master, but with new feature code removed for backport to 2.1 and 2.0. It does the following: - renames 'vlUploadQueueAutoImport' to 'vlUploadQueueImportNoMatch' to match identical change in master and to increase code clarity - honors this flag when doing a merge. Previously, if you checked one of the two auto-merge boxes, any records which did not merge loaded as new records even if the 'Auto-Import Non-Colliding Records' box was not checked. You can now do one, the other, or both together (auto-importing and merging) as needed. Signed-off-by: Dan Wells Signed-off-by: Mike Rylander 2011-07-20 Liam Whalen * Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Biblio.pm: Deleted a line the removed single quotes (') from search strings The multiclass_query function replaces single quotes with spaces (') ( ). This causes a problem when toggling between Advanced and Basic search. If a search is conducted with a ' in it, that quote appears in the basic search box displayed above the results. However, if the user then clicks the 'Advanced' button to toggle to the advanced search the single quote is missing from the search term. By removing the line $query =~ /s/'/ /go; from Biblio.pm this problem is resolved. Signed-off-by: Liam Whalen Signed-off-by: Mike Rylander 2011-08-03 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0589.money.materialized_summary_payment -triggers.sql: Upgrade script for a patch from Steven Callender addressing payment types in money.materialized_summary_payment Signed-off-by: Mike Rylander 2011-07-28 Steven Callender * Open-ILS/src/sql/Pg/080.schema.money.sql, Open-ILS/src/sql/Pg/1.4.0.5-1.6.0.0-upgrade-db.sql: A fix so that the last payment types will be cash_payment and check_payment rather than bnm_payment for cash and check payments. Signed-off-by: Steven Callender Signed-off-by: Mike Rylander 2011-08-02 Joseph Lewis * Open-ILS/web/Makefile.am, Open-ILS/web/opac/skin/craftsman/css/default.css, Open-ILS/web/opac/skin/craftsman/css/layout.css, Open-ILS/web/opac/skin/craftsman/js/rdetail.js, Open-ILS/web/opac/skin/craftsman/js/result_common.js, Open-ILS/web/opac/skin/craftsman/js/search_bar.js, Open-ILS/web/opac/skin/craftsman/js/sidebar.js, Open-ILS/web/opac/skin/craftsman/xml/advanced/adv_global_row.xml, Open-ILS/web/opac/skin/craftsman/xml/advanced/advanced_global.xml, Open-ILS/web/opac/skin/craftsman/xml/body.xml, Open-ILS/web/opac/skin/craftsman/xml/common/altcanvas.xml, Open-ILS/web/opac/skin/craftsman/xml/common/cn_browse.xml, Open-ILS/web/opac/skin/craftsman/xml/common/css_common.xml, Open-ILS/web/opac/skin/craftsman/xml/common/fonts.xml, Open-ILS/web/opac/skin/craftsman/xml/common/holds.xml, Open-ILS/web/opac/skin/craftsman/xml/common/libselect.xml, Open-ILS/web/opac/skin/craftsman/xml/common/login.xml, Open-ILS/web/opac/skin/craftsman/xml/common/logo.xml, Open-ILS/web/opac/skin/craftsman/xml/common/orgtree.xml, Open-ILS/web/opac/skin/craftsman/xml/common/searchbar.xml, Open-ILS/web/opac/skin/craftsman/xml/common/sidebar.xml, Open-ILS/web/opac/skin/craftsman/xml/common/statusbar.xml, Open-ILS/web/opac/skin/craftsman/xml/common/tips.xml, Open-ILS/web/opac/skin/craftsman/xml/footer.xml, Open-ILS/web/opac/skin/craftsman/xml/home/homesearch.xml, Open-ILS/web/opac/skin/craftsman/xml/home/index_body.xml, Open-ILS/web/opac/skin/craftsman/xml/page_cnbrowse.xml, Open-ILS/web/opac/skin/craftsman/xml/page_myopac.xml, Open-ILS/web/opac/skin/craftsman/xml/page_rdetail.xml, Open-ILS/web/opac/skin/craftsman/xml/rdetail/rdetail_cn_details.xml , Open-ILS/web/opac/skin/craftsman/xml/rdetail/rdetail_copyinfo.xml, Open-ILS/web/opac/skin/craftsman/xml/rdetail/rdetail_extras.xml, Open-ILS/web/opac/skin/craftsman/xml/rdetail/rdetail_summary.xml, Open-ILS/web/opac/skin/craftsman/xml/result/filtersort.xml, Open-ILS/web/opac/skin/craftsman/xml/result/result_info.xml, Open-ILS/web/opac/skin/craftsman/xml/result/result_lowhits.xml, Open-ILS/web/opac/skin/craftsman/xml/result/result_table.xml, Open-ILS/web/opac/theme/craftsman/css/colors.css: Remove craftsman skin. Via LP: https://bugs.launchpad.net/evergreen/+bug/820010 And this email thread: http://libmail.georgialibraries.org/pipermail/open-ils-dev/2010-August/006269.html Signed-off-by: Joseph Lewis Signed-off-by: Thomas Berezansky 2011-07-24 Dan Scott * README: Format an unordered list appropriately The list of developer prereqs was munged inline rather than as a list. Signed-off-by: Dan Scott Signed-off-by: Thomas Berezansky 2011-07-21 Dan Scott * README: Provide Fedora-friendly instructions for the DBD libraries We had only provided the Debian / Ubuntu location of the libdbi-libdbd libraries, so add the Fedora location as well. Signed-off-by: Dan Scott Signed-off-by: Thomas Berezansky 2011-07-21 Dan Scott * README: Bring more of the wiki docs over to the README Document Perl prerequisites for a standalone PostgreSQL server. Include a section on starting Evergreen and basic troubleshooting. Signed-off-by: Dan Scott Signed-off-by: Thomas Berezansky 2011-07-21 Dan Scott * README: Update the README to include database installation instructions A long time ago, the database server was installed by default. Nowadays, installing the database server is a separate step reserved for whatever machine you want to devote to PostgreSQL. Not that you can't put it on the same machine as the rest of Evergreen and OpenSRF... Signed-off-by: Dan Scott Signed-off-by: Thomas Berezansky 2011-07-21 Dan Scott * Open-ILS/src/extras/Makefile.install: Correct varname for PostgreSQL RPMs On Fedora, Red Hat, and CentOS, we were still trying to install the set of PostgreSQL RPMs for PostgreSQL 8.4 using PGSQL_84_RPMS. This had been updated to PGSQL_90_RPMS to match the updated database version - using the right varname resolves the problem (at least on Fedora). Signed-off-by: Dan Scott Signed-off-by: Thomas Berezansky 2011-08-02 Bill Erickson * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0588.schema.replace_field-default-value .sql, Open-ILS/src/sql/Pg/upgrade/XXXX.schema.replace_field-default-value .sql: Stamped upgrade script for user/miker/replace_field_fix Signed-off-by: Bill Erickson 2011-08-02 Mike Rylander * Open-ILS/src/sql/Pg/012.schema.vandelay.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.schema.replace_field-default-value .sql: Have replace_field return input XML when no replace rule is provided Signed-off-by: Mike Rylander Signed-off-by: Bill Erickson 2011-08-01 Bill Erickson * Open-ILS/web/templates/default/conify/global/config/record_attr_def inition.tt2: Avoid xml_transform retrieval in record attr def editor config.xml_transform stores large chunks of XML. Fetching it angers Ejabberd on my test system. All we need is the name, so use the new AutoFieldWidget.searchOptions param to do just that. Signed-off-by: Bill Erickson Signed-off-by: Lebbeous Fogle-Weekley 2011-08-01 Bill Erickson * Open-ILS/web/js/dojo/openils/widget/AutoFieldWidget.js: AutoFieldWidget support for augmenting pcrud search options Adds a new searchOptions attribute to AutoFieldWidget for specifying additional parameters to pcrud when retrieving linked objects. The initial use case is for supporting a "select" list to allow AutoFieldWidget to retrieve only the display column of a linked object and not the whole object. Example: // fetch 'remote_field_name' on the remote objects instead of // fetching the entire object myGrid.overrideWidgetArgs.some_field = {searchOptions : {"select":{"some_hint":["remote_field_name"]}}}; Signed-off-by: Bill Erickson Signed-off-by: Lebbeous Fogle-Weekley 2011-07-14 Jason Etheridge * Open-ILS/src/perlmods/lib/OpenILS/Application/Circ.pm: calculate penalties when letting Mark Item Damaged add bills Signed-off-by: Jason Etheridge Signed-off-by: Galen Charlton 2011-08-02 Thomas Berezansky * Open-ILS/src/sql/Pg/950.data.seed-values.sql: Fix oils_i18n_gettext id numbers config.metabib_field ids 29/30 had 28 for translation id. Signed-off-by: Thomas Berezansky 2011-07-31 Jason Etheridge * Open-ILS/xul/staff_client/server/cat/spine_labels.js: use isNaN here, since NaN == NaN => false Signed-off-by: Jason Etheridge 2011-07-21 Jason Etheridge * Open-ILS/xul/staff_client/server/patron/standing_penalties.js: Correctly populate certain columns in the patron Messages interface When applying penalties, the csp's referenced by the ausp's are fleshed. Signed-off-by: Jason Etheridge Signed-off-by: Bill Erickson 2011-07-28 Dan Scott * Open-ILS/src/perlmods/lib/OpenILS/Utils/MFHD/test/mfhd.t: Fix broken builds due to test that can't find its data LP 817699 reports a problem that began with commit e9cd992fa4dbf1013346336193cb7469ecee10a8, reintroducing a problem that had previously been resolved with commit f017d1261c369b9b5cc3c9cfc4f50d3cdf12a445. In short, tests can and are run from different directories, but a new test opened a file without making any allowance that the test might be run from anything other than the /test/ directory. This fix uses the dirname(__FILE__) approach to provide the appropriate relative directory for the test data, and enables the tests to be processed without dying. Signed-off-by: Dan Scott Signed-off-by: Lebbeous Fogle-Weekley 2011-07-28 Lebbeous Fogle-Weekley * Open-ILS/web/js/dojo/openils/acq/nls/acq.js, Open-ILS/web/js/ui/default/acq/common/li_table.js: Make users confirm they really want to delete lineitems from POs... ... when they've already been ordered. There's really no reason to ever make such a deletion this that I can think of, but I use a confirm() instead of stricter measures in case I'm missing something. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Galen Charlton 2011-07-28 Bill Erickson * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0587.maintain_control_numbers_with_OCLC _awareness.sql, Open-ILS/src/sql/Pg/upgrade/xxxx.maintain_control_numbers_with_OCLC _awareness.sql: Stamped upgrade for user/dbs/oclcnumbers Signed-off-by: Bill Erickson 2011-07-21 Dan Wells * Open-ILS/src/sql/Pg/002.functions.config.sql, Open-ILS/src/sql/Pg/upgrade/xxxx.maintain_control_numbers_with_OCLC _awareness.sql: Prevent control numbers from duplicating In maintain_control_numbers(), if you have more than one 001 or 003, and at least one is the correct one, you will end up duplicating the correct number every time the record is saved. For example, if the incoming record was record ID # 12345, and the record contained: 001: 12345 001: ocm10202 ... then after maintain_control_numbers() ran, the record would contain: 001: 12345 001: 12345 Also, clean up some leftovers from the refactor I suggested in the previous commit. Signed-off-by: Dan Wells Signed-off-by: Dan Scott 2011-07-21 Dan Scott * Open-ILS/src/sql/Pg/002.functions.config.sql, Open-ILS/src/sql/Pg/950.data.seed-values.sql, Open-ILS/src/sql/Pg/upgrade/xxxx.maintain_control_numbers_with_OCLC _awareness.sql: Add an unwrapped upgrade script for OCLC-aware control numbers The upgrade script creates the SCN and LCCN search indexes and populates them using metabib.full_rec as a source; cheating, but the normalized values will work for non-exact search purposes. Sites can reingest all of their bibs if they want exact search to work. Also, refactor maintain_control_numbers() using a suggestion by Dan Wells to eliminate some duplicate code. Signed-off-by: Dan Scott Signed-off-by: Bill Erickson 2011-07-21 Dan Scott * Open-ILS/src/sql/Pg/002.functions.config.sql, Open-ILS/src/sql/Pg/950.data.seed-values.sql: Treat OCLC numbers specially in maintain_control_numbers For some reason, many records that come with OCLC numbers in the 001 field are not populated with a 003 field. This resulted in the OCLC number being thrown away entirely, rather than being moved into the 035, as there was no corresponding control number identifier field. However, given that we know that control numbers starting with "ocm" or "ocn" are special OCLC numbers, we can generate the 035 accordingly even in the absence of a 003. This update to maintain_control_numbers() teaches it to do the right thing for OCLC numbers. In addition, add an identifier search index so we can easily find records by their system control numbers (035 $a subfields). Signed-off-by: Dan Scott Signed-off-by: Bill Erickson 2011-07-25 Dan Scott * Open-ILS/src/extras/Makefile.install: Ubuntu Lucid needs MARC::Record from CPAN As Ubuntu Lucid ships with MARC::Record 2.0.0, and Serials requires 2.0.1 or greater, we must install MARC::Record from CPAN or face failing open-ils.search requests. Signed-off-by: Dan Scott 2011-07-21 Michael Peters * Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CopyLocations.pm: LP#813151 Copy Location sort order in Advanced Search This patch addresses the unintuitive copy location sort order in Advanced Search when searching at a specific branch. Thanks to Dan Wells for the code suggestion which changes the order in the listbox to alphabetical sort by asset.copy_location.name. Tested, and confirmed working in 2.0.4 test and production environments. Signed-off-by: Michael Peters Signed-off-by: Thomas Berezansky 2011-06-10 James Fournie * Open-ILS/web/opac/skin/default/xml/rdetail/rdetail_extras.xml, Open-ILS/web/opac/skin/default/xml/result/result_table.xml: NOVELIST/CHILIFRESH include statements missing a hash which was causing (none) errors. Signed-off-by: James Fournie Signed-off-by: Thomas Berezansky 2011-07-20 Jason Etheridge * Open-ILS/xul/staff_client/server/circ/util.js, Open-ILS/xul/staff_client/server/patron/util.js: adjust legacy xul column definitions for dates/timestamps to ensure correct sorting Signed-off-by: Jason Etheridge Signed-off-by: Lebbeous Fogle-Weekley 2011-07-18 Jason Etheridge * Open-ILS/xul/staff_client/server/admin/transit_list.js, Open-ILS/xul/staff_client/server/admin/work_log.js, Open-ILS/xul/staff_client/server/cat/copy_browser.js, Open-ILS/xul/staff_client/server/cat/copy_buckets.js, Open-ILS/xul/staff_client/server/cat/copy_summary.xul, Open-ILS/xul/staff_client/server/cat/record_buckets.js, Open-ILS/xul/staff_client/server/cat/z3950.js, Open-ILS/xul/staff_client/server/circ/alternate_copy_summary.js, Open-ILS/xul/staff_client/server/circ/checkin.js, Open-ILS/xul/staff_client/server/circ/checkout.js, Open-ILS/xul/staff_client/server/circ/copy_details.xul, Open-ILS/xul/staff_client/server/circ/copy_status.js, Open-ILS/xul/staff_client/server/circ/in_house_use.js, Open-ILS/xul/staff_client/server/circ/renew.js, Open-ILS/xul/staff_client/server/circ/util.js, Open-ILS/xul/staff_client/server/patron/hold_details.js, Open-ILS/xul/staff_client/server/patron/holds.js, Open-ILS/xul/staff_client/server/patron/items.js, Open-ILS/xul/staff_client/server/serial/manage_dists.js, Open-ILS/xul/staff_client/server/serial/manage_items.js, Open-ILS/xul/staff_client/server/serial/manage_subs.js: remove circ.util.std_map_row_to_columns; default to the one provided by list.js Signed-off-by: Jason Etheridge 2011-07-18 Jason Etheridge * Open-ILS/xul/staff_client/chrome/content/util/list.js, Open-ILS/xul/staff_client/server/circ/util.js: Better sort support for xul lists (see launchpad bug ://bugs.launchpad.net/evergreen/+bug/751745) Example of supplying a sort_value function for item Create Date, and automatic sort_value for fm_columns-generated timestamp and money column definitions. Need to provide more such functions, and eventually move everything over to fm_columns Signed-off-by: Jason Etheridge 2011-07-25 Bill Erickson * Open-ILS/web/opac/skin/default/js/holds.js, Open-ILS/web/opac/theme/default/css/colors.css: Manage parts holds warning (and removal) w/ CSS Use add/removeCSSClass to apply and remove holds parts selector warning instead of inline style.border management, which (when using 'auto') causes problems in IE. Signed-off-by: Bill Erickson Signed-off-by: Lebbeous Fogle-Weekley 2011-07-20 Jason Etheridge * Open-ILS/xul/staff_client/server/circ/util.js: sort hold Queue Position column correctly in xul lists Signed-off-by: Jason Etheridge Signed-off-by: Lebbeous Fogle-Weekley 2011-07-25 Thomas Berezansky * Open-ILS/web/opac/skin/default/js/holds.js: Comment out line that breaks holds placement in IE auto is not a valid option for a border, and IE faults on it. Other browsers seem to ignore it, as far as I can tell. Signed-off-by: Thomas Berezansky Signed-off-by: Lebbeous Fogle-Weekley 2011-07-20 Michael Peters * Open-ILS/xul/staff_client/server/circ/checkout.js: LP#647121 Event handling on override abort Discussed on IRC, phasefx discovered that several events were not being properly handled when they were empty strings. Tested and working on Evergreen 2.0.4. Signed-off-by: Michael Peters Signed-off-by: Thomas Berezansky 2011-07-19 Dan Wells * Open-ILS/src/perlmods/lib/OpenILS/Utils/MFHD.pm, Open-ILS/src/perlmods/lib/OpenILS/Utils/MFHD/Holding.pm, Open-ILS/src/perlmods/lib/OpenILS/Utils/MFHD/test/mfhd.t, Open-ILS/src/perlmods/lib/OpenILS/Utils/MFHD/test/mfhddata2.txt: MFHD compressed holding fixes 1. Add new utility method to MFHD.pm: holdings_by_caption(): return all holdings attached to a given caption 2. Add 'passthru_open_ended' option to get_decompressed_holdings() Previously, attempts to decompress an open-ended holding would error out. Now, in the absence of this option, open-ended holdings are discarded and you get a warning (since they cannot logically be decompressed), while if this option is 'true' they are passed back unaffected 3. compressed_to_last() on an open-ended holding now more correctly returns 'undef' rather than the unaltered holding 4. get_compressed_holdings() will now honor an open-ended holding by treating it as "infinite", and thus absorbing any holdings which would follow 5. Overloaded comparison operator now correctly detects "swap" cases (where only the second operand is a holding) 6. Overloaded comparison operator now consistently treats open-ended holdings as "greater-than" a single or closed holding which has the same starting point 7. Fix 2 thinkos in comparison operator for overlapping compressed holdings 8. Add new compressed_end() method to Holding.pm which can add or set a new ending to a holding, making compressed if needed 9. Correctly recognize partially compressed holdings If a holding is defined as: 863 40 $81.1 $a1 $b2-10 this actually means: 863 40 $81.1 $a1-1 $b2-10 so let's make sure to treat it that way. 9. Expand the MFHD test suite to better cover the improvements in this commit There is also the beginnings of a _get_truncated_holdings() method for handling odd cases where an open-ended holding is followed by a single/closed holding, but it is currently commented out, pending further design consideration. Signed-off-by: Dan Wells Signed-off-by: Lebbeous Fogle-Weekley 2011-07-19 Galen Charlton * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0583.schema.aging_circ_view.sql: rerun DB update 0582 to avoid upgrade problem This implements the same update as 0582.schema.aging_circ_view.sql, and exists purely the the sake of avoid a potential upgrade glitch for somebody who's upgrading from 2.0.8+ that includes a version of this fix that's not compatible with with 2.1+. Signed-off-by: Galen Charlton 2011-07-18 Steven Callender * Open-ILS/xul/staff_client/server/patron/display.js: lp#812550: Removed nulls from showing for patron penalties when no note attached to penalty. Signed-off-by: Steven Callender Signed-off-by: Michael Peters Signed-off-by: Galen Charlton 2011-07-18 Dan Scott * Open-ILS/xul/staff_client/server/cat/spine_labels.js: Address minor code formatting consistency The rest of the code has spaces around the conditional clause in an if() statement, so do likewise here. Signed-off-by: Dan Scott 2011-06-06 James Fournie * Open-ILS/xul/staff_client/server/cat/spine_labels.js: Spine label editor assumes LC as reported in LP #780665. This patch encapsulates the LC-assuming code in an IF block which considers the asset.call_number.volume.label_class. If that is equal to 3, it will use the LC formatting. Signed-off-by: James Fournie Signed-off-by: Dan Scott 2011-07-14 Jason Etheridge * Open-ILS/xul/staff_client/server/patron/bill2.js: fix bill ui display update bug where total owed and total checked were not updated if the total owed as paid off in full Signed-off-by: Jason Etheridge Signed-off-by: Mike Rylander 2011-07-16 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0582.schema.aging_circ_view.sql, Open-ILS/src/sql/Pg/upgrade/XXX.schema.aging_circ_view.sql: Stamping upgrade script for "Bad join condition all_circulation view" Signed-off-by: Mike Rylander 2011-07-16 Mike Rylander * Open-ILS/src/sql/Pg/090.schema.action.sql, Open-ILS/src/sql/Pg/upgrade/XXX.schema.aging_circ_view.sql: Bad join condition in secondary (physical) address lookup, causing terrible performance of circ aging Signed-off-by: Mike Rylander 2011-07-13 mrpeters-isl * Open-ILS/xul/staff_client/server/cat/copy_browser.js: LP795032 Fix cursor rendering and dropdown position in holdings maintenance OU dropdown Signed-off-by: mrpeters-isl Signed-off-by: Mike Rylander 2011-07-16 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0581.data.opac_renewal_reuse_circ_lib.s ql, Open-ILS/src/sql/Pg/upgrade/XXXX.opac_renewal_reuse_circ_lib.sql: Stamping upgrade script for "Opac Renewal at original circ library" Signed-off-by: Mike Rylander 2011-07-16 Mike Rylander * Open-ILS/src/sql/Pg/950.data.seed-values.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.opac_renewal_reuse_circ_lib.sql: Default to existing behaviour for the new circ-behaviour global flag Signed-off-by: Mike Rylander 2011-07-05 Thomas Berezansky * Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm: Cache global flag at first use This way only the first opac renewal per backend has to ask the database for the global flag. Signed-off-by: Thomas Berezansky Signed-off-by: Mike Rylander 2011-07-05 Thomas Berezansky * Open-ILS/src/sql/Pg/upgrade/XXXX.opac_renewal_reuse_circ_lib.sql: Unwrapped upgrade script Signed-off-by: Thomas Berezansky Signed-off-by: Mike Rylander 2011-07-02 Thomas Berezansky * Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm, Open-ILS/src/sql/Pg/950.data.seed-values.sql: Opac Renewal at original circ library Fixes multiple potential issues: 1 - Bad home ou on patron breaks circ rules Ex. Patron edited while editor would let you pick bad home ou 2 - Item not allowed to circ at patron home ou Ex. Patron went to where they were allowed to pick it up 3 - Fines change to patron home ou fine rules Ex. Patron's home ou doesn't charge fines but circ lib does Ex. Circ lib doesn't charge fines but Patron's home ou does Signed-off-by: Thomas Berezansky Signed-off-by: Mike Rylander 2011-07-16 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0580.schema.aou_parent_protect.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.aou_parent_protect.sql: Stamping upgrade script for "Prevent OU loops at DB level" Signed-off-by: Mike Rylander 2011-06-15 Thomas Berezansky * Open-ILS/src/sql/Pg/upgrade/XXXX.aou_parent_protect.sql: Unwrapped upgrade script for ou loop protect May need to be split into "create function" and "add trigger" pieces. Signed-off-by: Thomas Berezansky Signed-off-by: Mike Rylander 2011-06-15 Thomas Berezansky * Open-ILS/src/sql/Pg/005.schema.actors.sql: Prevent OU loops at DB level Database trigger to prevent actor.org_unit from being parent of self Actually detects any loops, even those above the current point Signed-off-by: Thomas Berezansky Signed-off-by: Mike Rylander 2011-07-07 Dan Wells * Open-ILS/src/perlmods/lib/OpenILS/Application/Search.pm: Make spell-checking case insensitive As it stands, if you search for a proper noun using lower case, but manage to trigger the "did you mean" functionality, all the words are 'corrected' even if just the case is wrong. However, we are stripping out the best correction precisely because it is the same word, different case. It is a bit confusing to explain, but here is an example: daniel potatoe gets corrected to: Daniela potato This happens because the current spell check is case sensitive, so 'daniel' is spelled wrong, but then we remove 'Daniel' from the list of corrections (presumably to avoid possibly suggesting terms which would yield the same exact result set). So, we either need to make the spell-check itself case insensitive, or stop removing the re-cased corrections. Since the catalog search itself is already case-insensitive, I think it makes sense that the spell check should follow suit. Signed-off-by: Dan Wells Signed-off-by: Mike Rylander 2011-07-16 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0579.schema.fix_checkout_overrides.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.fix_checkout_overrides.sql: Stamping upgrade script for "INDB Circ Matrix + Checkout Overrides Fix" Signed-off-by: Mike Rylander 2011-06-07 Thomas Berezansky * Open-ILS/src/sql/Pg/upgrade/XXXX.fix_checkout_overrides.sql: Unwrapped upgrade script for checkout overrides Replace the function. Signed-off-by: Thomas Berezansky Signed-off-by: Mike Rylander 2011-06-06 Thomas Berezansky * Open-ILS/src/sql/Pg/100.circ_matrix.sql: INDB Circ Matrix + Checkout Overrides Fix Move most failures to after matchpoint lookup. This prevents "no duration rule" errors on overridable errors. Signed-off-by: Thomas Berezansky Signed-off-by: Mike Rylander 2011-07-15 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0578.schema.part_holds_bib_report.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.part_holds_bib_report.sql: Stamping upgrade script for "Fix part holds in reporter.hold_request_record" Signed-off-by: Mike Rylander 2011-07-15 Thomas Berezansky * Open-ILS/src/sql/Pg/upgrade/XXXX.part_holds_bib_report.sql: Unwrapped upgrade script Signed-off-by: Thomas Berezansky Signed-off-by: Mike Rylander 2011-07-15 Thomas Berezansky * Open-ILS/src/sql/Pg/reporter-schema.sql: Fix part holds in reporter.hold_request_record Specifically, make them show a bib id, instead of null. Signed-off-by: Thomas Berezansky Signed-off-by: Mike Rylander 2011-07-14 Lebbeous Fogle-Weekley * Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm, Open-ILS/web/opac/skin/default/js/holds.js: Corrected the logic of format string building for metarecord holds and... made hold possiblity checking for metarecord holds respect the format string (so you can't place holds on formats for which there will never be anything targetable) Made possible by much concerted effort from Mike Rylander Signed-off-by: Lebbeous Fogle-Weekley 2011-07-14 Bill Erickson * Open-ILS/src/sql/Pg/upgrade/0563.data.collections_exempt_perm.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.data.collections_exempt_perm.sql: Stamped upgrade script for collections_exempt_perm Signed-off-by: Bill Erickson 2011-06-03 Bill Erickson * Open-ILS/src/sql/Pg/950.data.seed-values.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.data.collections_exempt_perm.sql: Un-stamped upgrade script for collection exempt perm Signed-off-by: Bill Erickson Signed-off-by: Mike Rylander 2011-06-03 Bill Erickson * Open-ILS/src/sql/Pg/950.data.seed-values.sql, Open-ILS/web/js/ui/default/actor/user/register.js: Permission to control patron-collections-exempt Adds a new permission 'UPDATE_PATRON_COLLECTIONS_EXEMPT' which controls who can toggle the circ.collections.exempt user setting in the patron registration interface. Signed-off-by: Bill Erickson Signed-off-by: Mike Rylander 2011-07-14 Mike Rylander * Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/act ion.pm: Correct CDBI thinko -- search_where is smart about wantarray, search is not Signed-off-by: Mike Rylander 2011-07-13 Galen Charlton * Open-ILS/src/sql/Pg/upgrade/0576.fix_maintain_901_quoting.sql: for realz, this time Signed-off-by: Galen Charlton 2011-07-13 Galen Charlton * Open-ILS/src/sql/Pg/upgrade/0576.fix_maintain_901_quoting.sql: fix backporting thinko Signed-off-by: Galen Charlton 2011-07-12 Jason Etheridge * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0576.fix_maintain_901_quoting.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.fix_maintain_901_quoting.sql: pin an upgrade version for fix_maintain_901_quoting Signed-off-by: Jason Etheridge 2011-07-12 Galen Charlton * Open-ILS/src/sql/Pg/upgrade/XXXX.fix_maintain_901_quoting.sql: upgrade script for bugfix for lp#809540 Signed-off-by: Galen Charlton Signed-off-by: Jason Etheridge 2011-07-12 Galen Charlton * Open-ILS/src/sql/Pg/002.functions.config.sql: lp#809540: quote replacement values properly in maintain_901() Prevents a failure if, for example, the tcn_value of a bib to be added or updated contains the string '\1'. Signed-off-by: Galen Charlton Signed-off-by: Jason Etheridge 2011-07-12 Jason Etheridge * Open-ILS/web/opac/locale/en-US/opac.dtd, Open-ILS/web/opac/skin/default/js/advanced.js, Open-ILS/web/opac/skin/default/xml/common/sidebar.xml: alert the user when the OPAC's Quick Search->Item Barcode function returns a pre-cataloged item Signed-off-by: Jason Etheridge Signed-off-by: Galen Charlton 2011-07-11 Galen Charlton * Open-ILS/web/js/ui/default/acq/common/li_table.js: append line items to table in specified order Prior to this patch, the order that line items were displayed in (e.g.) a purchase order view was effetively randomized based on the amount of time it would take for async calls to fetch additional line item details to return. Signed-off-by: Galen Charlton Signed-off-by: Lebbeous Fogle-Weekley 2011-07-06 Mike Rylander * Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/CDBI/biblio.p m: Correct CDBI field name on biblio::peer_bib_copy_map Signed-off-by: Mike Rylander Signed-off-by: Jason Etheridge 2011-07-07 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm: Ignore part-mapped copies for mr/title/volume holds Signed-off-by: Bill Erickson Signed-off-by: Jason Etheridge 2011-06-24 Mike Rylander * Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/CDBI.pm, Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/CDBI/biblio.p m, Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/dbi .pm: Add Class::DBI linking for monograph parts (and some for conjoined items AKA peer bibs) Signed-off-by: Mike Rylander Signed-off-by: Jason Etheridge 2011-06-24 Mike Rylander * Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Biblio.pm: Correct a documentation comment Signed-off-by: Mike Rylander Signed-off-by: Jason Etheridge 2011-06-24 Mike Rylander * Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/act ion.pm: Filter out copies that have a monograph part designator when the hold is a non-P hold Signed-off-by: Mike Rylander Signed-off-by: Jason Etheridge 2011-06-28 Bill Erickson * Open-ILS/web/opac/locale/en-US/opac.dtd, Open-ILS/web/opac/skin/default/js/holds.js, Open-ILS/web/opac/skin/default/xml/common/holds.xml: Suggest parts selection on failed parts-capable hold When a title has copy parts and the user does not select a specific part for the hold, treat it as a regular title hold. If the title hold fails, suggest to the user that he/she should select a specific part, since that opens the door to a new set of potentially capturable copies, which allow the hold to be successfully placed. Signed-off-by: Bill Erickson Signed-off-by: Jason Etheridge 2011-07-07 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0573.schema.staff_search_find_no_copies .sql, Open-ILS/src/sql/Pg/upgrade/XXXX.staff_search_find_no_copies.sql: Stamping upgrade version number for staff_search_find_no_copies branch (backport) Signed-off-by: Mike Rylander 2011-07-06 Thomas Berezansky * Open-ILS/src/sql/Pg/300.schema.staged_search.sql: Allow staff search to find bibs sans copies AKA, no call number OR no call numbers with copies Signed-off-by: Thomas Berezansky Signed-off-by: Mike Rylander 2011-07-06 Thomas Berezansky * Open-ILS/src/sql/Pg/upgrade/XXXX.staff_search_find_no_copies.sql: Unwrapped upgrade script Signed-off-by: Thomas Berezansky Signed-off-by: Mike Rylander 2011-06-17 Jason Etheridge * Open-ILS/xul/staff_client/server/cat/copy_editor.js: in unified vol/copy editor disallow editing of item attributes when no copies except via templates Signed-off-by: Jason Etheridge Signed-off-by: Bill Erickson 2011-06-16 Thomas Berezansky * Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm: Delete protection - Ensure you can touch group Same protection editing a user seems to get: If you don't have the right group_application.user perm, reject Signed-off-by: Thomas Berezansky Signed-off-by: Dan Wells 2011-07-05 Thomas Berezansky * Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm: Can't use 0 in true/false, use defined instead This allows for setting renewals/grace period to 0 by force Signed-off-by: Thomas Berezansky Signed-off-by: Mike Rylander 2011-07-02 Thomas Berezansky * Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm: Fix checkout on alternate patron barcode Specifically, when a non-primary patron barcode is used. Such as via SIP2. NOTE: This does not change the behavior of inactive cards, nor will stock Evergreen usage produce a situation where this fix comes into play. --miker Signed-off-by: Thomas Berezansky Signed-off-by: Mike Rylander 2011-07-05 Dan Scott * Open-ILS/src/templates/password-reset/request-form.tt2, Open-ILS/src/templates/password-reset/reset-form.tt2: LP805971: Specify UTF8 encoding in password reset templates As reported by Liam Whalen in Launchpad bug 805971: "The file /openils/var/template/password-reset/reset-form.tt2 does not display utf-8 characters. I modified it to include '' inside the tag, and the fr-CA version of the page now displays correctly." I duplicated the problem in Firefox 5 and confirmed that the addition of the META tag corrects the problem. Signed-off-by: Dan Scott 2011-07-01 Mike Rylander * Open-ILS/src/sql/Pg/030.schema.metabib.sql, Open-ILS/src/sql/Pg/upgrade/0571.schema.facet_normalizer.sql: Normalize facet values Spotted by Lebbeous Fogle-Weekley, facet values were not being normalized. This is due to changes in how facets are stored in 2.1+. This alternate implementation mirrors the way search_field index definitions work, which is a bit cleaner than inserting normalization into the field extraction process. Signed-off-by: Mike Rylander 2011-07-01 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0570.schema.fix-authsort.sql, Open-ILS/src/sql/Pg/upgrade/0yyy.schema.fix-authsort.sql: Stampping upgrade for authorsort fix from Lebbeous Signed-off-by: Mike Rylander 2011-06-30 Lebbeous Fogle-Weekley * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/950.data.seed-values.sql, Open-ILS/src/sql/Pg/upgrade/0yyy.schema.fix-authsort.sql: Fix the SVF authorsort field (metabib.record_attr->'authorsort') It's important not to include things like $0 that we wouldn't want in there. Signed-off-by: Lebbeous Fogle-Weekley 2011-07-01 Mike Rylander * : commit 16e6d2959b6a39d3ffac1ae0b427061bff126b9b Author: Jason Etheridge Date: Tue Jun 14 14:50:33 2011 -0400 2011-06-14 Jason Etheridge * Open-ILS/xul/staff_client/chrome/content/util/print.js: when using params.data keys as print macros, render bare numbers correctly, and treat nulls as empty strings Signed-off-by: Jason Etheridge Signed-off-by: Bill Erickson 2011-06-28 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/990.schema.unapi.sql, Open-ILS/src/sql/Pg/upgrade/0569.schema.unapi-auri-fix.sql: Correct copy-paste-o spotted by Dan Scott Signed-off-by: Mike Rylander 2011-06-28 Lebbeous Fogle-Weekley * Open-ILS/web/templates/default/acq/common/li_table.tt2: Michael Peters provided a patch to add some missing labels... ... to a key acquisitions interface. It works. Also fixed some unclosed tags while I was at it. Wasn't sure whether to copy and paste Michael's sign-off or what, but here's the link to his original patch for purists: https://launchpadlibrarian.net/74191964/0001-LP802578-Acquisitions-Batch-copy-update-missing-head.patch Signed-off-by: Lebbeous Fogle-Weekley 2011-06-24 Dan Scott * Open-ILS/web/opac/skin/default/js/result_common.js: Fix broken images for items without ISBNs in search results The search results code happily sets the src attribute of the cover image to an empty string (as returned by cleanISBN()) if currentISBN has not been defined (which is generally the case if an item doesn't have an ISBN, such as a DVD or a thesis or an old book). Protect against the empty string and set the src attribute to '/opac/images/blank.png' to avoid broken image indicators in search results. Signed-off-by: Dan Scott Signed-off-by: Dan Scott Signed-off-by: Mike Rylander 2011-06-27 Jason Etheridge * Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm, Open-ILS/web/opac/locale/en-US/lang.dtd, Open-ILS/xul/staff_client/chrome/content/main/constants.js, Open-ILS/xul/staff_client/server/cat/util.js, Open-ILS/xul/staff_client/server/locale/en-US/cat.properties, Open-ILS/xul/staff_client/server/patron/holds.js: Saner behavior for Actions for Selected Holds -> Transfer to Marked Title * Transfer the actual selected title holds, rather than all title holds for the bibs referenced by those selected. * middle layer method for changing the target and resetting specified holds * label change for clarity, Transfer All Title Holds Signed-off-by: Jason Etheridge Signed-off-by: Bill Erickson 2011-06-27 Mike Rylander * Open-ILS/src/sql/Pg/999.functions.global.sql, Open-ILS/src/sql/Pg/upgrade/0568.cache_visibility_speed_boost.sql: Cleanup of missed commit from the original topic branch (cherry picked from commit b22d801e97565fc64205bf67e5a55d44090e1408) Signed-off-by: Mike Rylander 2011-06-27 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/999.functions.global.sql, Open-ILS/src/sql/Pg/upgrade/0568.cache_visibility_speed_boost.sql: Backport of cache visbility trigger speedup Backporting: cdcbbbbc520e91f003b68d716dcd0d75a2b68971 27bed378975a1164232d0b922cd03ce7493dee82 f762b75ac430ed70365ebc0385d2c9d0da04ab26 from master Signed-off-by: Mike Rylander 2011-06-24 Jason Etheridge * Open-ILS/src/perlmods/lib/OpenILS/Application/Circ.pm: with scan missing pieces, retarget affected holds prior to recirculating to previous patron, lest the checkout reset the holds for us without retargeting Signed-off-by: Jason Etheridge Signed-off-by: Bill Erickson 2011-06-22 Jason Etheridge * Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm: retarget title holds after transfering to a new bib Signed-off-by: Jason Etheridge Signed-off-by: Bill Erickson 2011-06-24 Dan Scott * Open-ILS/src/extras/Makefile.install, README: Support Fedora 15 as a target in Makefile.install Add Fedora 15 to the Makefile.install as a simple clone of the Fedora 14 target for now. Correct Makefile.install target names in README, and point out that nothing special is required for Fedora 15 for PostgreSQL 9 support. While we're in the README, rip out the Dojo toolkit install info as packaged releases include Dojo now (we retain the developer instructions for installing Dojo manually for git users, of course). Signed-off-by: Dan Scott Signed-off-by: Dan Scott 2011-06-13 Ben Webb * Open-ILS/src/Makefile.am, Open-ILS/src/apachemods/Makefile.am, Open-ILS/src/perlmods/Makefile.am, Open-ILS/web/Makefile.am, Open-ILS/xul/staff_client/Makefile.am: Respect DESTDIR during the build process Add $(DESTDIR) to paths it is currently missing from Manually specify the apxs2 install location so that DESTDIR can be prepended Attempt to create the apache directory if it does not exist Signed-off-by: Ben Webb Signed-off-by: Dan Scott 2011-06-24 Bill Erickson * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0566.schema.unAPI_XMLAGG_cleanup.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.schema.unAPI_XMLAGG_cleanup.sql: Stamped DB upgrade script for for XMLAGG cleanup Signed-off-by: Bill Erickson 2011-06-24 Mike Rylander * Open-ILS/src/sql/Pg/upgrade/XXXX.schema.unAPI_XMLAGG_cleanup.sql: Upgrade script for the XMLAGG cleanup Signed-off-by: Mike Rylander Signed-off-by: Bill Erickson 2011-06-24 Mike Rylander * Open-ILS/src/sql/Pg/990.schema.unapi.sql: Address LP#801129, in-db unAPI failure Cleanup of improper use of XMLAGG in the unAPI stored procs first identified by Bill Erickson in https://bugs.launchpad.net/bugs/801129 Signed-off-by: Mike Rylander Signed-off-by: Bill Erickson 2011-06-23 Jason Etheridge * Open-ILS/xul/staff_client/Makefile.am: bump xulrunner version Signed-off-by: Jason Etheridge 2011-06-22 Jason Stephenson * Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Validator.pm: Check if hold is really available in Trigger::Validator. Add checks for shelf time and no fulfillment time in HoldIsAvailable in OpenILS::Application::Trigger::Validator. We've had some issues with poorly migrated data and people messing with holds that causes the original logic to trigger for unfilled holds. Plus, the extra precaution of checking more precise conditions of an actually filled hold can't hurt, can it? Signed-off-by: Jason Stephenson Signed-off-by: Mike Rylander 2011-06-22 Mike Rylander * Open-ILS/src/perlmods/lib/OpenILS/Application/Actor/Container.pm, Open-ILS/src/perlmods/lib/OpenILS/WWW/TemplateBatchBibUpdate.pm, Open-ILS/web/opac/common/js/config.js: Make bucket content retrieval authoritative LP#492036, we neeed all bucket methods to be authoritative. Some already were, this finishes the job. Signed-off-by: Mike Rylander 2011-06-22 Michael Peters * Open-ILS/xul/staff_client/server/locale/en-US/patron.properties, Open-ILS/xul/staff_client/server/patron/search_result.js: LP#790639: Provide actual text, rather than id values in patron search results for various columns Cleaned up some tabs versus spaces and a needless trailing comma from original patch. Not porting to master, hoping to use collab/phasefx/fm_columns instead. Signed-off-by: Jason Etheridge Signed-off-by: Michael Peters 2011-06-21 Dan Wells * Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Serial.pm, Open-ILS/web/opac/skin/default/js/rdetail.js, Open-ILS/xul/staff_client/chrome/content/cat/opac.js, Open-ILS/xul/staff_client/server/locale/en-US/serial.properties, Open-ILS/xul/staff_client/server/serial/sdist_editor.js, Open-ILS/xul/staff_client/server/serial/ssub_editor.js: Further clean-up of Serials interfaces When trying to come up with good tests, found a few bugs (imagine!). Some have been nagging for a while now. 1) For 'MFHDDrawn' event, make sure it runs if deleting the last serials data of any kind for that record (to unpopulate the menus properly) 2) Make sure global mfhd member (g.mfhd) is cleared in the same case (i.e. deleting the last serials data for that record) 3) Add a string to better indicate when no MFHD records are available for 'Legacy Record Entry' drop-down 4) Convert submitted empty drop-down values to 'null' as needed in distribution editor 5) Mark subscription 'start date' as a required field 6) Make serial virtual records better handle deleted 'legacy record entries' attached to distributions, and also expose non-deleted record entries even if in 'use_sdist_only' summary mode Signed-off-by: Dan Wells Signed-off-by: Jason Etheridge 2011-06-17 Dan Wells * Open-ILS/xul/staff_client/chrome/content/cat/opac.js, Open-ILS/xul/staff_client/server/serial/sdist_editor.js: Better coordination of MFHD/SRE adding/deleting Adding or deleting MFHD records from the XUL menus requires coordinating the OPAC display, the XUL menus, and the Serial Control distribution editors. The previous code frequently required some non-obvious manual refreshing to make it work. This commit keeps them in sync using custom events instead. Signed-off-by: Dan Wells Signed-off-by: Jason Etheridge 2011-06-21 Dan Scott * Open-ILS/src/perlmods/t/14-OpenILS-Utils.t: Add unit tests for LP 800269 - holdings for captions only Running "prove -l lib" in Open-ILS/src/perlmods shows that the two new unit tests pass, whereas they fail using the previously installed version of MFHD.pm. Good evidence that the fix from dbwells does indeed solve the reported bug. Signed-off-by: Dan Scott 2011-06-21 Dan Wells * Open-ILS/src/perlmods/lib/OpenILS/Utils/MFHD.pm: MFHD compressed holdings short-circuit logic If you attempt to get compressed (or uncompressed) holdings from a MFHD record with only a caption, the code should short-circuit and return an empty list. Signed-off-by: Dan Wells Signed-off-by: Dan Scott 2011-06-21 Michael Peters * Open-ILS/xul/staff_client/server/skin/patron_display.css: LP#783590 fix patron alert message highlighting Signed-off-by: Michael Peters Signed-off-by: Jason Etheridge 2011-06-21 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0561.schema.tnf_index.sql: Reserve 0561 (used in 2.0) to avoid confusion Signed-off-by: Mike Rylander 2011-06-17 Dan Scott * Open-ILS/examples/opensrf.xml.example: Set AC timeout value to 3 seconds and describe tradeoffs As discussed on the Evergreen Development mailing list, the higher the AC timeout value, the greater the risk of a denial of service. 30 is therefore too high to be comfortable as a default setting, so we're dropping it down to 3 as a compromise between the original value of 1 (which resulted in a number of request timing out where added content was actually available) and the much-less-safe 30. In addition, we document inline the risk/reward of different values and provide some justification for the default value that we chose, so that Evergreen system administrators will have guidance when tweaking this setting. Signed-off-by: Dan Scott Signed-off-by: Mike Rylander 2011-06-20 Dan Scott * Open-ILS/src/sql/Pg/upgrade/0559.schema.biblio.extract_located_uris .sql: DROP biblio.reingest_uris() after use We will hopefully only need to reingest URIs in bulk once, and can therefore DROP the biblio.reingest_uris() function after it has been successfully invoked. Signed-off-by: Dan Scott Signed-off-by: Galen Charlton 2011-06-20 Dan Scott * Open-ILS/src/sql/Pg/upgrade/0559.schema.biblio.extract_located_uris .sql: Protect URI reingest from failure due to malformed XML In an ideal world, there would be no malformed XML. But our world is the real world of libraries, and while the well_formed_xml() protects against malformed XML in Evergreen 2.0 systems, in some cases bad XML has been able to find its way into Evergreen systems in the past. A single biblio.record_entry row containing malformed XML in the marc column will prevent the call to reingest URIs from succeeding. By limiting the set of records to those with well-formed XML, we can increase the chance of the URI reingest succeeding at the cost of more processing time. Signed-off-by: Dan Scott Signed-off-by: Galen Charlton 2011-06-14 Thomas Berezansky * Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/act ion.pm: Grace period is an interval. Convert to seconds. Signed-off-by: Thomas Berezansky Signed-off-by: Galen Charlton 2011-06-17 Thomas Berezansky * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0560.fix_opac_copy_vis_cache.sql: lp#788763 - final upgrade script Signed-off-by: Thomas Berezansky Signed-off-by: Galen Charlton 2011-06-17 Thomas Berezansky * Open-ILS/src/sql/Pg/999.functions.global.sql: lp#788763 - fix updating copy status, locations, and OU visibiilty Signed-off-by: Thomas Berezansky Signed-off-by: Galen Charlton 2011-06-16 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/Order.pm: Repaired exchange rate PO activation bug Code was using the wrong hash key to read data from cstore request, resulting in a NULL debit amount when activating a PO with a different provider => fund currencies. This resulted in POs that could not be activated. Signed-off-by: Bill Erickson 2011-06-16 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0559.schema.biblio.extract_located_uris .sql, Open-ILS/src/sql/Pg/upgrade/XXXX.biblio.extract_located_uris.sql: Move the user/dbs/lp797304_lp797307 upgrade script into place with a number Signed-off-by: Mike Rylander 2011-06-16 Mike Rylander * Open-ILS/src/sql/Pg/030.schema.metabib.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.biblio.extract_located_uris.sql: Merging branch user/dbs/lp797304_lp797307 Cherry picking the following: commit 7be2a32620587af27de4316e42a308e913e9314c Author: Dan Scott Date: Tue Jun 14 22:35:26 2011 -0400 Add a stored procedure to reingest problematic URIs Assuming that href = label in asset.uri is a red enough flag for the problem in LP 797307 where the perfectly good label was being thrown away, reingest the unique set of records connected with such asset.uri rows. commit 39fe0c4a8a3074ff4c1e427ad9f00a0760bac260 Author: Dan Scott Date: Tue Jun 14 21:54:51 2011 -0400 Add unwrapped upgrade script for biblio.extract_located_uris See XXXX.biblio.extract_located_uris.sql for the upgrade script, waiting to be signed off and committed. create mode 100644 Open-ILS/src/sql/Pg/upgrade/XXXX.biblio.extract_located_uris.sql commit 7e6d2bfd7e9a5cbe57e4aacdf0b4b015a566883d Author: Dan Scott Date: Tue Jun 14 21:34:15 2011 -0400 Avoid duplicate row issues in biblio.extract_located_uris As there is currently no unique constraint on the non-ID columns of asset.uri, ensure that we only select a single ID from the tables until we dedupe the tables. Use an ORDER BY to grab the matching row with the lowest ID so we can clear out the rows with higher IDs. commit e79a805299ec734a29ee5bfa77dc74bc1fd208cd Author: Dan Scott Date: Tue Jun 14 14:02:49 2011 -0400 Fix LP 797304 and 797307 - asset.uri parsing bugs Per 797304: one would expect asset.uri.label to be populated with the value of 856 $y, however, it was getting populated with 856 $u - perhaps as a result of the ordering of array entries in XPATH() not matching the XPath expression. Instead of including 856 $u in the XPath expression for uri_label, just assign its value to uri_label if uri_label is otherwise NULL. Per 797307: biblio.extract_located_uris() tries to reuse an existing active asset.uri entry rather than create a new row; however, it does not handle the case where there is no public note aka "use restriction" and will end up creating a duplicate row every time the record is reingested. Teach it to handle NULL values properly. (cherry picked from commit da70b778268afff19c3dd4f2e9e4c9e85cfeb7e3) Signed-off-by: Mike Rylander Signed-off-by: Dan Scott Signed-off-by: Dan Scott Signed-off-by: Dan Scott Signed-off-by: Dan Scott Signed-off-by: Mike Rylander 2011-06-15 Jason Etheridge * Open-ILS/xul/staff_client/server/patron/bill2.js: lp797321: Disable the Apply Payment button during payment processing to mitigate chance of duplicate payments. I can't actually reproduce the creation of duplicate payments locally with trunk/2.x, but there are reports of it, and this doesn't seem to hurt. Not a complete solution, but better than before Signed-off-by: Jason Etheridge Signed-off-by: Galen Charlton 2011-06-13 Dan Scott * Open-ILS/src/extras/Makefile.install: Resolve Squeeze installation problems with PostgreSQL 9.0 When you install OpenSRF on Debian Squeeze, one of the packages (apache2-prefork-dev) installs 8.4 versions of libpq5 and libpq-dev as dependencies. These conflict with the 9.0 versions that are required as dependencies for PostgreSQL 9.0 - so get them out of the way, pin the 9.0 versions of the packages, and reinstall apache2-prefork-dev. We will probably need to do something similar for Lucid. Signed-off-by: Dan Scott 2011-06-13 Lebbeous Fogle-Weekley * Open-ILS/xul/staff_client/server/serial/batch_receive.js: Fix a serial batch receive problem reported by Sally Fortin That prevents receiving items when not using units in some cases. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Dan Wells 2011-06-13 Dan Scott * Open-ILS/examples/opensrf.xml.example: Set a more generous AC timeout value A timeout value of 1 second is a bit too tight for many added content providers; set the default to 30 seconds to avoid too many artificial timeouts. Signed-off-by: Dan Scott 2011-06-07 Dan Wells * Open-ILS/xul/staff_client/server/locale/en-US/serial.properties, Open-ILS/xul/staff_client/server/serial/editor_base.js, Open-ILS/xul/staff_client/server/serial/scap_editor.js, Open-ILS/xul/staff_client/server/serial/sdist_editor.js: Support for required fields in Serial Control editors Adds a basic check for any fields marked as 'required', and alerts and prevents submitting if they are blank. Signed-off-by: Dan Wells 2011-06-13 Jason Etheridge * Open-ILS/xul/staff_client/server/locale/en-US/cat.properties: clearer label for not charging last patron when marking an item damaged Signed-off-by: Jason Etheridge 2011-06-13 Galen Charlton * : updated favicon to match staff client logo Favicon created by Michael Peters Signed-off-by: Galen Charlton Signed-off-by: Dan Scott 2011-06-13 Mike Rylander * Open-ILS/src/sql/Pg/990.schema.unapi.sql, Open-ILS/src/sql/Pg/upgrade/0557.schema.in-db_unapi_copy_related_vi sibility-1.sql, Open-ILS/src/sql/Pg/upgrade/0558.schema.in-db_unapi_copy_related_vi sibility-2.sql: Typo, we need commas Signed-off-by: Mike Rylander 2011-06-13 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0557.schema.in-db_unapi_copy_related_vi sibility-1.sql, Open-ILS/src/sql/Pg/upgrade/0558.schema.in-db_unapi_copy_related_vi sibility-2.sql: Backporting 36b0a67a4520151082e72056893d92ad3bf797f1, in-db unAPI improvement Signed-off-by: Mike Rylander 2011-06-13 Jason Etheridge * Open-ILS/web/opac/locale/en-US/lang.dtd, Open-ILS/xul/staff_client/server/locale/en-US/cat.properties: more s/Foreign/Conjoined/ Items label changes Signed-off-by: Jason Etheridge 2011-06-13 Jason Etheridge * : commit 23ba3ddad28e8fcc8019a7486a6a3faf671e627f Author: Jason Etheridge Date: Mon Jun 13 10:35:29 2011 -0400 2011-05-31 Dan Scott * Open-ILS/web/opac/common/js/Cookies.js, Open-ILS/web/reports/oils_rpt_common.xhtml, Open-ILS/xul/staff_client/server/admin/cash_reports.xhtml, Open-ILS/xul/staff_client/server/admin/copy_locations.xhtml, Open-ILS/xul/staff_client/server/admin/hold_pull_list.xhtml, Open-ILS/xul/staff_client/server/admin/hold_pull_list_classic.xhtml , Open-ILS/xul/staff_client/server/admin/non_cat_types.xhtml, Open-ILS/xul/staff_client/server/admin/stat_cat_editor.xhtml, Open-ILS/xul/staff_client/server/patron/user_edit.xhtml: Remove all references to Cookie(s).js and Cookies.js Dojo toolkit is the new Cookie manager, so any lingering references to Cookie.js (a typo in any case) are no longer valid, and we no longer need to ship Cookies.js with Evergreen. Cookie.js typo was reported by Steven Chan in LP 790429 Signed-off-by: Dan Scott Signed-off-by: Dan Scott 2011-06-07 Dan Scott * Open-ILS/web/opac/skin/default/xml/result/result_table.xml: Use the new status.opac_visible attribute in search summary Until we exposed the OPAC visibility of the status element as set in config.copy_status, We previously had to hardcode the logic for whether a given copy should be displayed based on its status. Now we can simply use the status.opac_visible attribute to determine visibility. Signed-off-by: Dan Scott 2011-06-07 Dan Scott * Open-ILS/src/perlmods/lib/OpenILS/Application/SuperCat.pm: Add opac_visible attribute to copy and serial unit statuses config.copy_status defines an opac_visible column, but that attribute was not being exposed in the holdings XML, so code that displayed copies and serial units based on the holdings XML had to hardcode the display based on the status ID or name instead of using the configured setting. To simplify display logic, teach holdings XML about the opac_visible column and expose its value in the status element as a new opac_visible attribute. Signed-off-by: Dan Scott 2011-06-06 Dan Scott * Open-ILS/web/opac/skin/default/xml/result/result_table.xml: Make copy status visibility match default config.copy_status settings Previous version of this patch had hardcoded copy status settings to 0, 7, 12 to match the "Available" settings, rather than the OPAC visibility settings available from config.copy_status for each status. Until config.copy_status.opac_visible translates into an opac_visible attribute on the status element in the holdings XML, this is probably the best we can do. Signed-off-by: Dan Scott 2011-05-30 Dan Scott * Open-ILS/web/opac/skin/default/xml/result/result_table.xml: Plug the many OPAC visibility holes in search result item display Check volume and circ_lib and copy status OPAC visibility (and deleted status in the case of volumes) in addition to the existing copy and copy-location checks. Worst hack is hard-coded copy status IDs of 0, 7, 12 - but this is currently used throughout the code, so one more can't hurt that much (OWWW). Signed-off-by: Dan Scott 2011-06-13 Thomas Berezansky * Open-ILS/updates/check: Updater apparently reads extensionVersion Without it no updates are ever found. :( Signed-off-by: Thomas Berezansky Signed-off-by: Jason Etheridge 2011-06-11 Dan Scott * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0549.unnest_oils_xpath_table.sql, Open-ILS/src/sql/Pg/upgrade/0550.unnest_biblio_extract_metabib_fiel d_entry.sql, Open-ILS/src/sql/Pg/upgrade/0551.unnest_metabib_remap_metarecord_fo r_bib.sql, Open-ILS/src/sql/Pg/upgrade/0552.unnest_biblio_map_authority_linkin g.sql, Open-ILS/src/sql/Pg/upgrade/0553.unnest_action_hold_request_permit_ test.sql, Open-ILS/src/sql/Pg/upgrade/0554.unnest_search_query_parser_fts.sql , Open-ILS/src/sql/Pg/upgrade/0555.unnest_oils_xpath_table.sql, Open-ILS/src/sql/Pg/upgrade/0556.unnest_biblio_extract_metabib_fiel d_entry.sql: Update upgrade files that had conflicting numbers 0549 and 0550 were taken by other commits over time. Signed-off-by: Dan Scott 2011-06-11 Dan Scott * : commit 6976c0594ff133aef7b5958a07b75d88782f02fc Author: Thomas Berezansky Date: Wed Jun 8 14:07:48 2011 -0400 2011-06-07 Thomas Berezansky * Open-ILS/xul/staff_client/server/cat/copy_editor.js: Correct error in call number owning library change Send IDs to the backend, not objects. Signed-off-by: Thomas Berezansky Signed-off-by: Jason Etheridge 2011-06-10 Thomas Berezansky * Open-ILS/web/js/ui/default/actor/user/register.js: Mark invalid home ous as such in patron editor Signed-off-by: Thomas Berezansky Signed-off-by: Bill Erickson 2011-06-10 Jason Etheridge * Open-ILS/xul/staff_client/chrome/locale/en-US/offline.properties: missing string for MFHD deletion Signed-off-by: Jason Etheridge 2011-06-08 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm: Extend hold shelf expire date beyond closed dates If the shelf_expire_time on a hold would land on a closed date for the pickup library, push the expire time out to just beyond the close date range, similar to the circulation due date overlap logic. In the current iteration, the time component of the date is pushed out to the end of the day (23:59:59). If this is not generally the desired behavior, an org setting could be added to bypass this step so that the time matches "now" (i.e. capture time) instead. Signed-off-by: Bill Erickson Signed-off-by: Jason Etheridge 2011-05-26 Jason Etheridge * Open-ILS/xul/staff_client/server/cat/copy_browser.js: honor ui.unified_volume_copy_editor setting with Add Volumes in Holdings Maintenance Signed-off-by: Jason Etheridge Signed-off-by: Bill Erickson 2011-06-01 Jason Etheridge * Open-ILS/xul/staff_client/server/cat/copy_editor.js, Open-ILS/xul/staff_client/server/cat/volume_copy_creator.js: make unified vol/copy editor honor required stat cats Signed-off-by: Jason Etheridge Signed-off-by: Bill Erickson 2011-06-07 Dan Scott * Open-ILS/src/sql/Pg/002.functions.aggregate.sql, Open-ILS/src/sql/Pg/002.functions.config.sql, Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/030.schema.metabib.sql, Open-ILS/src/sql/Pg/110.hold_matrix.sql, Open-ILS/src/sql/Pg/300.schema.staged_search.sql, Open-ILS/src/sql/Pg/pgmemcache-ou_tree_traversal_cache.sql, Open-ILS/src/sql/Pg/upgrade/0549.unnest_oils_xpath_table.sql, Open-ILS/src/sql/Pg/upgrade/0550.unnest_biblio_extract_metabib_fiel d_entry.sql, Open-ILS/src/sql/Pg/upgrade/0551.unnest_metabib_remap_metarecord_fo r_bib.sql, Open-ILS/src/sql/Pg/upgrade/0552.unnest_biblio_map_authority_linkin g.sql, Open-ILS/src/sql/Pg/upgrade/0553.unnest_action_hold_request_permit_ test.sql, Open-ILS/src/sql/Pg/upgrade/0554.unnest_search_query_parser_fts.sql: Use native unnest() db function instead of explode_array() Per LP 789747, the custom explode_array() database function was found to generate significantly slower results for searches than using the native (and equivalent) unnest() array function. Given that unnest() has been part of PostgreSQL since 8.4 and Evergreen 2.0 requires a minimum of PostgreSQL 8.4, this patch removes the definition of the explode_array() functions and replaces its usage with unnest(). Signed-off-by: Dan Scott 2011-06-03 Lebbeous Fogle-Weekley * Open-ILS/web/js/ui/default/actor/user/register.js: Prevent future dates of birth in patron editor The patron editor form allowed staff to enter a date of birth that takes place in the future. While it is theoretically conceivable (hah) that a library might register patrons that have yet to be born, it is unlikely enough that we will not even assign this behavior to an org-unit setting, but we will take the bold move of using a regular expression to prevent a future dates of birth at all. Note that if a library system travels into the past, this will cause all sorts of problems in the patron editor interface (not to mention overdues). Please do not mix Evergreen and time travel. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Dan Scott 2011-06-02 Dan Wells * Open-ILS/web/opac/skin/default/js/rdetail.js: Fix false MFHD editing cues (LP #791974) The in-DB serial holdings use the same general display code as the MFHD records, but were falsely triggering MFHD administration widgets when in fact no MFHD record exists. These holdings were already being marked, so this fix honors that mark. Signed-off-by: Dan Wells Signed-off-by: Dan Scott 2011-06-02 Dan Wells * Open-ILS/web/opac/skin/default/js/rdetail.js: Tweak MFHD scoping Three changes: 1) Add a closure for 'entryNum' value (currently used for some display placement and menu-entry correlation) 2) Remove depth-climb to simplify code and better approximate copy scoping 3) Move 'here' assignment out of the foreach Signed-off-by: Dan Wells Signed-off-by: Dan Scott 2011-05-27 Dan Scott * Open-ILS/web/opac/skin/default/js/rdetail.js: Fix rendering of MFHD records when ownership is out of scope Dojo would die with a null reference error when an MFHD record was retrieved that was outside of the current OU search scope. For example, if a given bib record had one linked MFHD record for BR1, and one linked MFHD record for BR4, the details page would choke trying to draw the MFHD holdings in a scope that only included BR1 and end up drawing nothing. Ungood. Moving the ownership check and invoking _holdingsDrawMFHD() only after ensuring that the record is within our scope resolves the problem. Signed-off-by: Dan Scott 2011-06-06 Dan Scott * Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Biblio.pm, Open-ILS/web/opac/common/js/config.js: LP 791546: advanced search ISBN/ISSN in .staff mode In 1.6, advanced search ISBN/ISSN searches always operated in .staff mode, returning results whether the results should have been visible to the user or not. This confused patrons who saw records to which they had no access. In 2.0, this behaviour changed so that advanced search ISBN/ISSN searches never operated in .staff mode. This confused staff who were used to retrieving records via the ISBN/ISSN search when they wanted to add holdings for their own library to the records. The pattern for addressing this problem and satisfying both use cases is the same - use the multiclass.query.staff method if we invoke the ISBN or ISSN searches with the .staff method name. One could easily refactor many of the search method bodies in this module to use the exact same logic, keying off the method name to identify the identifier field and the .staff portion of the method name to determine whether to invoke .staff mode or not. For now we just address the ISBN and ISSN entry points. Signed-off-by: Dan Scott Signed-off-by: Dan Wells 2011-06-06 Jason Etheridge * Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm: fix View Holds by preventing an empty IN list with cstore, and stubbing out part_holds Signed-off-by: Jason Etheridge Signed-off-by: Jason Stephenson 2011-06-01 Jason Etheridge * Open-ILS/xul/staff_client/server/circ/alternate_copy_summary.js, Open-ILS/xul/staff_client/server/circ/util.js: for the Circulate as Type column in xul lists, display the actual citm value instead of the code Signed-off-by: Jason Etheridge Signed-off-by: Galen Charlton 2011-06-01 Jason Etheridge * Open-ILS/xul/staff_client/chrome/content/OpenILS/data.js: Fix Circulate as Type in the item editor. The citm retrieval method was changed to use open-ils.fielder, which doesn't return actual fieldmapper objects, so when data.js went to convert the retrieved list to a hash, it broke. Signed-off-by: Jason Etheridge Signed-off-by: Galen Charlton 2011-06-01 Jason Etheridge * Open-ILS/xul/staff_client/chrome/content/util/functional.js: Allow util.functional.convert_object_list_to_hash to handle more than fieldmapper-like objects Signed-off-by: Jason Etheridge Signed-off-by: Galen Charlton 2011-06-03 Bill Erickson * Open-ILS/web/js/ui/default/acq/po/view_po.js: PO activation date display improvement Use the smarter Util.js date parsing code to prevent small time offsets in PO activation date display. Signed-off-by: Bill Erickson 2011-06-03 Jason Etheridge * Open-ILS/xul/staff_client/server/cat/copy_editor.js: tweak function name Signed-off-by: Jason Etheridge 2011-06-03 Dan Scott * Open-ILS/xul/staff_client/server/cat/copy_editor.js: Refactor the "show copy notes button" functionality Collapse the duplicated code for showing / hiding the "show copy notes button" into a single method. Might make maintenance a bit easier some day. Signed-off-by: Dan Scott Signed-off-by: Jason Etheridge 2011-06-01 Jason Etheridge * Open-ILS/xul/staff_client/server/cat/copy_editor.js: fix the Copy Notes button in the unified vol/copy editor Signed-off-by: Jason Etheridge Signed-off-by: Dan Scott 2011-06-03 Dan Wells * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/950.data.seed-values.sql, Open-ILS/src/sql/Pg/upgrade/0547.data.perm_list_cleanup.sql: Clean up a few stock perm mistakes This upgrade file does cleanup for two errors: 1) accounts for spelling errors (Admin != Administrator) 2) adds a group missed in 0542, for upgraders Signed-off-by: Dan Wells 2011-06-03 Dan Wells * Open-ILS/src/sql/Pg/upgrade/0542.data.perm-list.misc-cat.sql: Fixed and extended upgrade file 0542 (stock permissions) This upgrade file did not work on a multi-upgraded DB, as a bunch of new permissions and groups never made it into any upgrade. The changes here are intended to both fix the upgrade and rectify the missing pieces, where needed. Signed-off-by: Dan Wells 2011-06-01 Dan Scott * Open-ILS/src/perlmods/lib/OpenILS/Application/Reporter.pm: Whitespace cleanup in aisle 3 (O:A:Reporter) Signed-off-by: Dan Scott 2011-06-01 Michael Peters * Open-ILS/src/perlmods/lib/OpenILS/Application/Reporter.pm: LP#740466 Sort report folders by name Add order_by to Reporter.pm to sort report folders by name Signed-off-by: Michael Peters Signed-off-by: Dan Scott 2011-06-01 Dan Wells * Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Serial.pm, Open-ILS/src/perlmods/lib/OpenILS/Application/Serial.pm, Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0543.data.reformat_generated_coverage.s ql: Serial holdings display consistency fix When holdings are sourced from both MFHD and the DB, display may be inconsistent due to a hard-coded ', ' in Serial.pm. This patch works around the problem by storing generated_coverage as a JSON array instead of a string, leaving display formatting to the OPAC. Signed-off-by: Dan Wells 2011-06-01 Dan Wells * Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Serial.pm, Open-ILS/src/perlmods/lib/OpenILS/Application/Serial.pm, Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0543.data.reformat_generated_coverage.s ql: Revert "f424dd8" for bad commit message This reverts commit 997eef7b50acf10ec2afcb8d8933b75317e0410f. 2011-06-01 Dan Wells * Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Serial.pm, Open-ILS/src/perlmods/lib/OpenILS/Application/Serial.pm, Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0543.data.reformat_generated_coverage.s ql: f424dd8 2011-06-01 Dan Wells * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0542.data.perm-list.misc-cat.sql: Missing db upgrade number bump plus backport fix Signed-off-by: Dan Wells 2011-06-01 Dan Wells * Open-ILS/src/sql/Pg/950.data.seed-values.sql, Open-ILS/src/sql/Pg/upgrade/0542.data.perm-list.misc-cat.sql: Remove specific admin perms, reorganize seed file The various administrators already have 'EVERYTHING' at their respective levels, so no need to assign new perms there. The seed file is now more consistently organized. Signed-off-by: Dan Wells Signed-off-by: Jason Etheridge 2011-06-01 Dan Wells * Open-ILS/src/sql/Pg/upgrade/0542.data.perm-list.misc-cat.sql: Change a few permission levels and assignments In an attempt to be consistent with existing perms, a few were moved to levels lower than 'Consortium', and ADMIN_SERIAL_ITEM is only in the 'Serial' group. Signed-off-by: Dan Wells Signed-off-by: Jason Etheridge 2011-05-26 Jason Etheridge * Open-ILS/src/sql/Pg/950.data.seed-values.sql: Push the grp perm mappings into the seed data Signed-off-by: Jason Etheridge Signed-off-by: Dan Wells 2011-05-26 Jason Etheridge * Open-ILS/src/sql/Pg/upgrade/0542.data.perm-list.misc-cat.sql: wrong group ids for system admin and global admin Signed-off-by: Dan Wells 2011-05-26 Jason Etheridge * Open-ILS/src/sql/Pg/upgrade/0542.data.perm-list.misc-cat.sql: put CREATE_PURCHASE_REQUEST into Users, not Staff Signed-off-by: Dan Wells 2011-05-26 Jason Etheridge * Open-ILS/src/sql/Pg/upgrade/0542.data.perm-list.misc-cat.sql: map these perms to stock perm groups Signed-off-by: Jason Etheridge Signed-off-by: Dan Wells 2011-05-26 Jason Etheridge * Open-ILS/src/sql/Pg/950.data.seed-values.sql, Open-ILS/src/sql/Pg/upgrade/0542.data.perm-list.misc-cat.sql: added other permissions missing in rel_2_1 Signed-off-by: Dan Wells 2011-05-26 Jason Etheridge * Open-ILS/src/sql/Pg/950.data.seed-values.sql, Open-ILS/src/sql/Pg/upgrade/0542.data.perm-list.misc-cat.sql: some recent cataloging permissions, but I'm unsure about the new upgrade/ script regime Signed-off-by: Jason Etheridge Signed-off-by: Dan Wells 2011-05-31 Michael Peters * Open-ILS/web/opac/locale/en-US/opac.dtd: LP#739444 Incrementing opac.dtd copyright date Signed-off-by: Michael Peters Signed-off-by: Dan Scott 2011-05-27 Jason Etheridge * Open-ILS/web/opac/locale/en-US/lang.dtd: indicate what date format to use for offline patron registration Signed-off-by: Jason Etheridge 2011-05-27 Thomas Berezansky * Open-ILS/xul/staff_client/server/circ/checkin.xul: Fix Hold Capture checkin mode oils_persist was trumping hardcoded values. Also, change how checked is set/unset for reliability. Signed-off-by: Thomas Berezansky Signed-off-by: Jason Etheridge 2011-05-26 Mike Rylander * Open-ILS/web/opac/skin/default/xml/home/index_body.xml: Patch suggested by Jason Boyer for LP#788601 The